Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StrippableSystem blunders #26166

Merged
merged 4 commits into from
Mar 16, 2024
Merged

Fix StrippableSystem blunders #26166

merged 4 commits into from
Mar 16, 2024

Conversation

Krunklehorn
Copy link
Contributor

About the PR

#25994 wasn't airtight. I never thought to test on animals, zombies or dead / crit players.

This PR fixes the following issues:
#26144
#26145
#26150

  • Zombies and animals couldn't be stripped because I was checking for target hands too early
  • Dead/Crit was instantly stripping because I turned the strip time multiplier into a TimeSpan

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑 Krunk

  • fix: Zombies and animals can be stripped once again.
  • fix: Dead or critical mobs can no longer be stripped instantly.

@metalgearsloth metalgearsloth merged commit 8ecb78e into space-wizards:master Mar 16, 2024
11 checks passed
@SimpleStation14 SimpleStation14 mentioned this pull request Apr 22, 2024
Closed
@VMSolidus VMSolidus mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Krunklehorn @metalgearsloth