Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-resprites labcoats #26209

Closed
wants to merge 2 commits into from
Closed

Conversation

Flareguy
Copy link
Contributor

About the PR

Completely reshades most labcoats and gives them new inhands.
Also removes the geneticist labcoat, since it was probably never going to get used anyways + could probably easily be confused with medical. Even if genetics is added, it'll probably just be in the scientist job, and not its own thing.

Does not touch senior labcoats. They're unused, their designs suck, and I don't feel like making new ones right now.

Why / Balance

With a year's worth of experience under my belt after I made the previous iteration of these, I felt like these could use a touchup to make them more fitting & more detailed. The comically low color count definitely wasn't helping matters, at least.

Media

Content Client_vxGsqDMulJ

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

The genetics labcoat has been removed, as mentioned before, but it's been migrated already so it should be fine.

Changelog

  • tweak: Resprited labcoats.

@github-actions github-actions bot added Changes: Sprites Changes: Might require knowledge of spriting or visual design. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Mar 17, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Mar 17, 2024
Copy link
Contributor

github-actions bot commented Mar 17, 2024

RSI Diff Bot; head commit 122a8ca merging into 4357b9e
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/OuterClothing/Coats/labcoat.rsi

State Old New Status
equipped-OUTERCLOTHING Modified
icon-open Modified
icon Modified
inhand-left Modified
inhand-right Modified
open-equipped-OUTERCLOTHING Modified
open-inhand-left Removed
open-inhand-right Removed

Resources/Textures/Clothing/OuterClothing/Coats/labcoat_chem.rsi

State Old New Status
equipped-OUTERCLOTHING Modified
icon-open Modified
icon Modified
inhand-left Modified
inhand-right Modified
open-equipped-OUTERCLOTHING Modified
open-inhand-left Removed
open-inhand-right Removed

Resources/Textures/Clothing/OuterClothing/Coats/labcoat_cmo.rsi

State Old New Status
equipped-OUTERCLOTHING Modified
icon-open Modified
icon Modified
open-equipped-OUTERCLOTHING Modified
inhand-left Added
inhand-right Added

Resources/Textures/Clothing/OuterClothing/Coats/labcoat_robo.rsi

State Old New Status
equipped-OUTERCLOTHING Modified
icon-open Modified
icon Modified
inhand-left Modified
inhand-right Modified
open-equipped-OUTERCLOTHING Modified
open-inhand-left Removed
open-inhand-right Removed

Resources/Textures/Clothing/OuterClothing/Coats/labcoat_viro.rsi

State Old New Status
equipped-OUTERCLOTHING Modified
icon-open Modified
icon Modified
inhand-left Modified
inhand-right Modified
open-equipped-OUTERCLOTHING Modified
open-inhand-left Removed
open-inhand-right Removed

Resources/Textures/Clothing/OuterClothing/Coats/labcoat_gene.rsi

State Old New Status
equipped-OUTERCLOTHING Removed
icon-open Removed
icon Removed
inhand-left Removed
inhand-right Removed
open-equipped-OUTERCLOTHING Removed
open-inhand-left Removed
open-inhand-right Removed

Resources/Textures/Clothing/OuterClothing/Coats/rd_coat.rsi

State Old New Status
equipped-OUTERCLOTHING Removed
icon-open Removed
icon Removed
inhand-left Removed
inhand-right Removed
open-equipped-OUTERCLOTHING Removed
open-inhand-left Removed
open-inhand-right Removed

Resources/Textures/Clothing/OuterClothing/Coats/rndcoat.rsi

State Old New Status
equipped-OUTERCLOTHING Removed
icon-open Removed
icon Removed
inhand-left Removed
inhand-right Removed
open-equipped-OUTERCLOTHING Removed
open-inhand-left Removed
open-inhand-right Removed

Resources/Textures/Clothing/OuterClothing/Coats/labcoat_rd.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon-open Added
icon Added
inhand-left Added
inhand-right Added
open-equipped-OUTERCLOTHING Added

Resources/Textures/Clothing/OuterClothing/Coats/labcoat_sci.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon-open Added
icon Added
inhand-left Added
inhand-right Added
open-equipped-OUTERCLOTHING Added

Edit: diff updated after 122a8ca

# Conflicts:
#	Resources/migration.yml
@github-actions github-actions bot added S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Mar 17, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@potato1234x
Copy link
Contributor

why remove geneticist labcoat? how could it get confused with med labcoat its got the blue stripes

@Flareguy Flareguy mentioned this pull request Mar 25, 2024
1 task
@Flareguy
Copy link
Contributor Author

I decided fixing the weird submodule issue would be more effort then it's worth, so I've just moved to a new branch. #26425

@Flareguy Flareguy closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants