Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some abnormally high-capacity boxes #28314

Merged
merged 4 commits into from
May 30, 2024

Conversation

Lamrr
Copy link
Contributor

@Lamrr Lamrr commented May 27, 2024

About the PR

Fixed some abnormally high-capacity boxes to be more inline with existing expectations around box capacity.

  • Dart boxes now have a normal storage capacity and 1 less dart of each colour.
  • Candle boxes are now whitelisted to candles only (akin to replacement light boxes), and have a smaller capacity (6x4, the same as light boxes) with slightly less coloured candles.
  • Replacement light boxes have had duplicated yaml removed through parenting.
  • Deathrattle implant box, a nukeops only item, has been moved to the syndicate.yml box fills and given a new sprite. It retains its abnormally high capacity.

Fixes #28271

Media

Screenshot from 2024-05-27 21-25-21

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: Candle boxes can now only hold candles.

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label May 27, 2024
@lzk228
Copy link
Contributor

lzk228 commented May 27, 2024

good pr
i was about to fix some of it in #25458 , but got some tests failing
you can check which was done in my pr to make sure not to dupe work

@Lamrr
Copy link
Contributor Author

Lamrr commented May 27, 2024

good pr i was about to fix some of it in #25458 , but got some tests failing you can check which was done in my pr to make sure not to dupe work

From what you've done there, this PR covers:

  • Replacement light box parenting
  • Changes to candle boxes (I've also changed their capacity and added a whitelist)
  • Changes to dart boxes (I've also changed their capacity in this)
    I'd just resolve those conflicts when your PR gets unfrozen (not sure why it got caught by the feature freeze)

@lzk228
Copy link
Contributor

lzk228 commented May 27, 2024

ok im good with it, after this pr merge i will fix merge conflicts in my branch

@AJCM-git AJCM-git merged commit aa94a85 into space-wizards:master May 30, 2024
12 checks passed
@Forzii Forzii mentioned this pull request Feb 13, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

darts box is a tardis with no whitelist
3 participants