Fix ghosting in lobby #29648
Closed
Fix ghosting in lobby #29648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
S: Merge Conflict
github-actions
bot
removed
the
S: Merge Conflict
metalgearsloth
requested changes
Jul 3, 2024
Content.Server/Ghost/GhostCommand.cs
Outdated
Comment on lines
21
to
23
| var player = shell.Player; | ||
| var ticker = _entities.System<GameTicker>(); | ||
|
|
There was a problem hiding this comment.
We have a system for this now.
There was a problem hiding this comment.
space-wizards/RobustToolbox#5267
MindSystem also needs updating to use it.
metalgearsloth
added
the
S: Awaiting Changes
github-actions
bot
added
S: Needs Review
lzk228
force-pushed
the
07-01-fix-ghost-lobby
branch
from
d3fa5ec to
49a0216
Compare
github-actions
bot
added
the
S: Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
title
fixes #21695
Why / Balance
bug
Technical details
Media
Breaking changes
Changelog
🆑