Displaying the administrator's position in ahelp and webhook #30075

chavonadelal · 2024-07-15T21:03:02Z

About the PR

Displaying the administrator's position in ahelp and webhook.

Why / Balance

This way, it will be easier for people to understand what position the administrator who communicates with them in ahelp. I think it's time to add this to the official repository, since it's on many servers and it's very convenient!😎

Technical details

Gets the admin title from AdminData. If the admin does not have his own title, then the name of the admin rank that the admin has is taken. Several cvars are used to determine whether it is worth adding an admin prefix to the ahelp, webhook. Cvar has also been added to determine whether to use custom names of admin ranks.

Media

I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

deltanedas · 2024-07-15T21:17:06Z

time to metagrudge trialmins in ahelp

GrigoriyGalintano · 2024-07-15T22:07:59Z

It's very cool, now it's convenient to see who writes to you

IProduceWidgets · 2024-07-15T22:37:17Z

I have no strong opinion one way or the other on this, but if we merge this we should probably change at least the couple that are uh... exceptional... to something more normal lol.

chavonadelal · 2024-07-15T22:46:27Z

I have no strong opinion one way or the other on this, but if we merge this we should probably change at least the couple that are uh... exceptional... to something more normal lol.

I don't really understand what you mean

chavonadelal · 2024-07-15T22:55:44Z

I really don't see any reason why this can't be merged. This has been around on many servers for over a year now. Unless there is something wrong with the technical part

NotSoDana · 2024-07-15T23:18:04Z

useless

chavonadelal · 2024-07-15T23:26:00Z

useless

You are laughing at me? this is literally a logical function to understand who is writing to you and whether it is within his competence and adds convenience. Adds friendliness to the interface. Beginners may not know about the adminwho command

chavonadelal · 2024-07-15T23:26:17Z

what's wrong with people...

Mirino97 · 2024-07-15T23:44:42Z

After talking to a few admins, I see no pros for having this feature, but I do see a few cons:

Trialmin discrimination is going to be a real thing
There is no reason to know the "rank" of an admin talking to you. All admins are equal in the ahelp.

Does someone have a positive to this that I'm not seeing?
Edit: accidentally pressed comment without finishing

NotSoDana · 2024-07-15T23:52:47Z

useless

You are laughing at me? this is literally a logical function to understand who is writing to you and whether it is within his competence and adds convenience. Adds friendliness to the interface. Beginners may not know about the adminwho command

Like a mod, like a player, like a contributor i really don't see any practical use of this feature. It doesn't really matter for players to know "WAT RANK IS THE MOD AR WRITING 2 ME". It's just another clogging of ahelp, bruh. If you received bwoink - you doing something wrong, and it's don't making sense whether host writing you, or just jr. moderator. For mods - annoying prefix, for players - don't have any sense, cuz of "adminwho" or simply memorizing administration nicknames.
As already written above, the entire administration is equal in ahelp. Event masters usually don’t write to it, unless you call them by yourself, so there’s no particular need to single them out. I am completely against merge this feature.

what's wrong with people...

And take criticism of your PRs more calmly, it doesn’t look very pleasant to read something like this.

chavonadelal · 2024-07-15T23:53:49Z

After talking to a few admins, I see no pros for having this feature, but I do see a few cons:

Trialmin discrimination is going to be a real thing

There is no reason to know the "rank" of an admin talking to you. All admins are equal in the ahelp.

Does someone have a positive to this that I'm not seeing?
Edit: accidentally pressed comment without finishing

Do you really think so? This is available on 90 percent of servers and, first of all, is necessary to understand who is in front of you and whether he has the authority to take certain actions. if someone is really going to insult admins for being interns, then they will go ahead and use the adminwho command. I submitted this pull request because I'm tired of seeing official developer repository lagging behind on this issue, even though it's already a standard in the rest of the community.

chavonadelal · 2024-07-15T23:54:51Z

And insulting trainee administrators is a banal ban

IProduceWidgets · 2024-07-16T00:01:18Z

I have no strong opinion one way or the other on this, but if we merge this we should probably change at least the couple that are uh... exceptional... to something more normal lol.

I don't really understand what you mean

It's not an issue with your pr, there's just some admins who have outlandish titles for meme reasons that this would make public. I was just mentioning they should be reevaluated if this is merged. (One of them is like a whole sentence, etc.)

IProduceWidgets · 2024-07-16T00:09:06Z

As far as pros to this,

it could be used to show mentors if we wanted to try to make those work within ahelp (which I personally think would better than an mhelp window).

chavonadelal · 2024-07-16T00:17:05Z

No offense, but in my opinion, the concerns you presented are more likely to be that it will be easier for players to get objective information about what kind of admin he is and whether he is exceeding his authority. Personally, I don’t see any downsides to this.
In any case, it would be fair if we were judged by an authoritative reviewer who is not related to the administration. Since in many ways I represent the side of ordinary players and you represent the side of admins.

Mirino97 · 2024-07-16T00:20:57Z

You do understand that there is no "rank" to admins, right?
We are all admins.
There are no "kind of admins", we're all the same.

Mirino97 · 2024-07-16T00:22:02Z

As far as pros to this,

* it could be used to show mentors if we wanted to try to make those work within ahelp (which I personally think would better than an mhelp window).

That would be a good reason, I believe. But I think mhelp is being done separately because ahelp code is spaggethi? I could be wrong

chavonadelal · 2024-07-16T00:30:18Z

You do understand that there is no "rank" to admins, right?
We are all admins.
There are no "kind of admins", we're all the same.

Ok, what about the trainee admins? or senior admins? Initially, the feature was added simply for convenience, but if you take it into such an area, then I will say that it would encourage trainee admins to work harder. And no arguments about insulting admin trainees are appropriate in my opinion because there is a console command adminwho. A signature of who the admin is writing about you would add more context.

metalgearsloth · 2024-07-16T00:31:01Z

Isn't adminwho disabled

Mirino97 · 2024-07-16T00:34:04Z

You do understand that there is no "rank" to admins, right?
We are all admins.
There are no "kind of admins", we're all the same.

Ok, what about the trainee admins? or senior admins? Initially, the feature was added simply for convenience, but if you take it into such an area, then I will say that it would encourage trainee admins to work harder. And no arguments about insulting admin trainees are appropriate in my opinion because there is a console command adminwho. A signature of who the admin is writing about you would add more context.

Adminwho is blocked, only admins can use it in Wizard's den, to block people who hunt for servers with no admins to grief.

We do not have senior admins. All admins are admins.

Trialmins are also treated as admins, the difference being that they work under supervision. Whatever they say is correct unless stated otherwise.

chavonadelal · 2024-07-16T00:34:51Z

Isn't adminwho disabled

As far as I remember, no, and on the server I play on it still works properly

sleepyyapril · 2024-07-16T00:35:28Z

Isn't adminwho disabled

As far as I remember, no, and on the server I play on it still works properly

Is it a fork?

LankLTE · 2024-07-16T00:38:23Z

Ok, what about the trainee admins? or senior admins? Initially, the feature was added simply for convenience, but if you take it into such an area, then I will say that it would encourage trainee admins to work harder. And no arguments about insulting admin trainees are appropriate in my opinion because there is a console command adminwho. A signature of who the admin is writing about you would add more context.

adminwho is disabled upstream. It’s also simply not the player’s job to decide if admins are acting within their authority or not. This could maybe be accepted as a cvar but upstream I can think of almost no reason that we’d want players being explicitly told what rank of admin they’re speaking to.

chavonadelal · 2024-07-16T00:39:04Z

Isn't adminwho disabled

As far as I remember, no, and on the server I play on it still works properly

Is it a fork?

Of course. So Google translator is not so bad 😁

chavonadelal · 2024-07-16T00:43:01Z

Ok, what about the trainee admins? or senior admins? Initially, the feature was added simply for convenience, but if you take it into such an area, then I will say that it would encourage trainee admins to work harder. And no arguments about insulting admin trainees are appropriate in my opinion because there is a console command adminwho. A signature of who the admin is writing about you would add more context.

adminwho is disabled upstream. It’s also simply not the player’s job to decide if admins are acting within their authority or not. This could maybe be accepted as a cvar but upstream I can think of almost no reason that we’d want players being explicitly told what rank of admin they’re speaking to.

Isn’t it up to the player to think about whether the admins are doing something within their powers? Do you disrespect the player so much that you don’t want to once again give the players a reason to find out that the admin has exceeded his authority? Or are you afraid that the players will have another reason to find out that the admin has exaggerated his authority? The eternal struggle between admin and player.

Chief-Engineer

I think this needs both:

A cvar to determine if it is enabled at all
A cvar to determine if custom rank names are used (if it is false, it'd use the actual rank name regardless of the individual's title)

I'm also not sure that adding the info to the webhook would do anything other than be clutter

Chief-Engineer · 2024-07-16T07:45:45Z

I think this needs both:

A cvar to determine if it is enabled at all

A cvar to determine if custom rank names are used (if it is false, it'd use the actual rank name regardless of the individual's title)

I'm also not sure that adding the info to the webhook would do anything other than be clutter

@Chief-Engineer admin title assumes that if a custom rank name is used then the admin title will be equal to it. If a specific admin does not have a custom name for the rank name, then the name of the admin rank that he has is used. As I checked. if this is not so please show me and correct me.

I'm saying that there should be a cvar that allows you to prevent the custom name from overriding the group name in the ahelp display

KingFroozy · 2024-07-16T11:43:33Z

Would it calm the criticism if I'd suggest the feature being toggleable?
Like, via a config or smth.

chavonadelal · 2024-07-16T16:55:58Z

I think this needs both:

A cvar to determine if it is enabled at all

A cvar to determine if custom rank names are used (if it is false, it'd use the actual rank name regardless of the individual's title)

I'm also not sure that adding the info to the webhook would do anything other than be clutter

@Chief-Engineer admin title assumes that if a custom rank name is used then the admin title will be equal to it. If a specific admin does not have a custom name for the rank name, then the name of the admin rank that he has is used. As I checked. if this is not so please show me and correct me.

I'm saying that there should be a cvar that allows you to prevent the custom name from overriding the group name in the ahelp display

@Chief-Engineer i have made the changes you indicated. Cvars are now used.

Content.Server/Administration/Systems/BwoinkSystem.cs

Content.Shared/CCVar/CCVars.cs

Chief-Engineer · 2024-07-17T06:49:18Z

Would it calm the criticism if I'd suggest the feature being toggleable? Like, via a config or smth.

That's what they've done

I think this needs both:

A cvar to determine if it is enabled at all

A cvar to determine if custom rank names are used (if it is false, it'd use the actual rank name regardless of the individual's title)

I'm also not sure that adding the info to the webhook would do anything other than be clutter

@Chief-Engineer admin title assumes that if a custom rank name is used then the admin title will be equal to it. If a specific admin does not have a custom name for the rank name, then the name of the admin rank that he has is used. As I checked. if this is not so please show me and correct me.

I'm saying that there should be a cvar that allows you to prevent the custom name from overriding the group name in the ahelp display

@Chief-Engineer i have made the changes you indicated. Cvars are now used.

Thank you. For the rank one I meant that it'd just override it for the relay/ahelp display instead of globally, but I guess this is fine, use of that cvar is probably going to be relatively rare anyway

chavonadelal · 2024-07-19T16:49:53Z

Would it calm the criticism if I'd suggest the feature being toggleable? Like, via a config or smth.

That's what they've done

I think this needs both:

A cvar to determine if it is enabled at all

A cvar to determine if custom rank names are used (if it is false, it'd use the actual rank name regardless of the individual's title)

I'm also not sure that adding the info to the webhook would do anything other than be clutter

@Chief-Engineer admin title assumes that if a custom rank name is used then the admin title will be equal to it. If a specific admin does not have a custom name for the rank name, then the name of the admin rank that he has is used. As I checked. if this is not so please show me and correct me.

I'm saying that there should be a cvar that allows you to prevent the custom name from overriding the group name in the ahelp display

@Chief-Engineer i have made the changes you indicated. Cvars are now used.

Thank you. For the rank one I meant that it'd just override it for the relay/ahelp display instead of globally, but I guess this is fine, use of that cvar is probably going to be relatively rare anyway

@Chief-Engineer Please tell me if it can already be merged? You've already approved it.

Chief-Engineer · 2024-07-20T11:16:52Z

Would it calm the criticism if I'd suggest the feature being toggleable? Like, via a config or smth.

That's what they've done

I think this needs both:

A cvar to determine if it is enabled at all

A cvar to determine if custom rank names are used (if it is false, it'd use the actual rank name regardless of the individual's title)

I'm also not sure that adding the info to the webhook would do anything other than be clutter

@Chief-Engineer admin title assumes that if a custom rank name is used then the admin title will be equal to it. If a specific admin does not have a custom name for the rank name, then the name of the admin rank that he has is used. As I checked. if this is not so please show me and correct me.

I'm saying that there should be a cvar that allows you to prevent the custom name from overriding the group name in the ahelp display

@Chief-Engineer i have made the changes you indicated. Cvars are now used.

Thank you. For the rank one I meant that it'd just override it for the relay/ahelp display instead of globally, but I guess this is fine, use of that cvar is probably going to be relatively rare anyway

@Chief-Engineer Please tell me if it can already be merged? You've already approved it.

I think it's mergeable but I'm not going to merge it myself to give someone else a chance to look through it and double check me

chavonadelal · 2024-07-22T21:49:35Z

Would it calm the criticism if I'd suggest the feature being toggleable? Like, via a config or smth.

That's what they've done

I think this needs both:

A cvar to determine if it is enabled at all

A cvar to determine if custom rank names are used (if it is false, it'd use the actual rank name regardless of the individual's title)

I'm also not sure that adding the info to the webhook would do anything other than be clutter

@Chief-Engineer admin title assumes that if a custom rank name is used then the admin title will be equal to it. If a specific admin does not have a custom name for the rank name, then the name of the admin rank that he has is used. As I checked. if this is not so please show me and correct me.

I'm saying that there should be a cvar that allows you to prevent the custom name from overriding the group name in the ahelp display

@Chief-Engineer i have made the changes you indicated. Cvars are now used.

Thank you. For the rank one I meant that it'd just override it for the relay/ahelp display instead of globally, but I guess this is fine, use of that cvar is probably going to be relatively rare anyway

@Chief-Engineer Please tell me if it can already be merged? You've already approved it.

I think it's mergeable but I'm not going to merge it myself to give someone else a chance to look through it and double check me

@Chief-Engineer I am really afraid and I think that no one but you will pay attention to this pull request due to the huge workload on the maintainers and more than 150 new pull requests after this pull request...

Chief-Engineer · 2024-07-23T19:39:37Z

It's not been unusual for PRs to to take weeks or more to review due to the high rate of contributions combined with the limited number of volunteer maintainers. This PR is not critical or urgent. It's likely seen by other maintainers as having even lower priority because it sounds like every server that currently intends to use it has already implemented it downstream.

I understand the frustration with PRs taking a long time to be reviewed and merged, I've had my own PRs sit for significant periods of time without review, but I can't force volunteers to review the PR and I don't feel comfortable merging this without another maintainer looking over it

chavonadelal · 2024-07-23T20:08:18Z

It's not been unusual for PRs to to take weeks or more to review due to the high rate of contributions combined with the limited number of volunteer maintainers. This PR is not critical or urgent. It's likely seen by other maintainers as having even lower priority because it sounds like every server that currently intends to use it has already implemented it downstream.

I understand the frustration with PRs taking a long time to be reviewed and merged, I've had my own PRs sit for significant periods of time without review, but I can't force volunteers to review the PR and I don't feel comfortable merging this without another maintainer looking over it

@Chief-Engineer And how do you understand what is really needed now? For example, I objectively lose the desire to contribute because there is a high probability that my attempts will be ignored, that is, the work was in vain. I can implement as many ideas as I want, but if others ignore it, then it was all in vain.

Chief-Engineer · 2024-07-24T07:29:45Z

It's not been unusual for PRs to to take weeks or more to review due to the high rate of contributions combined with the limited number of volunteer maintainers. This PR is not critical or urgent. It's likely seen by other maintainers as having even lower priority because it sounds like every server that currently intends to use it has already implemented it downstream.
I understand the frustration with PRs taking a long time to be reviewed and merged, I've had my own PRs sit for significant periods of time without review, but I can't force volunteers to review the PR and I don't feel comfortable merging this without another maintainer looking over it

@Chief-Engineer And how do you understand what is really needed now? For example, I objectively lose the desire to contribute because there is a high probability that my attempts will be ignored, that is, the work was in vain. I can implement as many ideas as I want, but if others ignore it, then it was all in vain.

All maintainers are volunteers and each has their own criteria for deciding how they prioritize PRs. I have reviewed your PR, but don't feel comfortable merging it until another maintainer reviews it too, so there's nothing more I can do. There are over 350 open PRs and every other contributor of those PRs might also lose the desire to contribute if their PRs aren't merged in whatever they think is a timely manner, but unless you're offering to hire maintainers for us, there's nothing we can do to prevent some people from becoming discouraged. The maintainer team doesn't have enough people to review every PR within a week

TheShuEd · 2024-07-30T11:38:36Z

@Chief-Engineer feel free to merg it
This is a useful feature that can be disabled by those who don't like it.

Chief-Engineer · 2024-08-03T03:58:51Z

removed CL based on the responses to https://discord.com/channels/310555209753690112/900426319433728030/1268977104926801961

…ards#30075) * Adding the admin prefix to the ahelp * Updating the admin prefix * The second update of the admin prefix * Configuration correction

@deltanedas

* Fix Bwoink Player sorting again.... (space-wizards#30580) Keep players that have had messages in the round at the top * Automatic changelog update * Marathon had extra pipes under windows (space-wizards#30584) Deletes extra pipes * Packed Singulo Substation & Chemistry Windoors (space-wizards#30572) * Rearrange Engineering Wires * Replaces chemistry windoors with correct access * Toxins Guidebook spelling mistakes (space-wizards#30585) Corrects spelling mistakes and changes dosages to doses * Recolor winter boots (space-wizards#30350) * Recolor winter boots * fix inhands * better colors * FOOT * Automatic changelog update * Greyscale Winter Coats and Hoods, some reorganizing of rsi. (space-wizards#30314) * reorganize coats, greyscale coats and hoods * fix inhands * make rsi validator happy * even mo' hap' * comma schmomma * oops theres a recipe * armor credits * painflicts * Add Ngl to chatsan (space-wizards#30589) * Ngl added fr this time * Update speech-chatsan.ftl Not gonna lie sounds more realistic than not going to lie * Display the administrator's title in ahelp and ahelp relay (space-wizards#30075) * Adding the admin prefix to the ahelp * Updating the admin prefix * The second update of the admin prefix * Configuration correction * Shotgun spread refactor (space-wizards#27773) * Moves spread data to new component * Refactors shotgun spread code * Makes shotgun cartridges and projectiles use new component * Attempts to fix nullable build error * Fixes hitscan weapons that I broke :( * Saviour commit? --------- Co-authored-by: EmoGarbage404 <[email protected]> * SpeakOnUseSystem and phrases for figurines (space-wizards#30455) * commit 1 * 2 * add more text * apply review * apply review 2 Co-authored-by: slarticodefast <[email protected]> --------- Co-authored-by: slarticodefast <[email protected]> * Automatic changelog update * Made the dank pizza actually dank (space-wizards#30430) * made the dank pizza actually dank * made the dank pizza also contain some nutritional value * Automatic changelog update * fix(GhostRoleAntagSpawner): Create a new mind before transfering (space-wizards#30354) * IN MY WALLS! IN MY WALLS THEY ARE IN MY WALLS HELP HEELP HEKP PA DADOEAMD EODM AOM D *DIES* IM NOT DEAD ADADADDADIAMSDIM * RUN I SAID RUN! THEY TOOK MY UKELELE Co-authored-by: EmoGarbage404 <[email protected]> * Many have fallen * It's all emo's fault --------- Co-authored-by: EmoGarbage404 <[email protected]> * Docking ports now block air only in the direction their port is. (space-wizards#30195) speedholes. * Fix a typo in the raid suit's description (space-wizards#30612) fix typo (for real this time i swear) * Update Credits (space-wizards#30620) Co-authored-by: PJBot <[email protected]> * Add mapping editor (space-wizards#23427) * Add mapping editor (space-wizards#757) * Remove mapping actions, never again * Cleanup actions system * Jarvis, remove all references to CM14 * Fix InventoryUIController crashing when an InventoryGui is not found * Rename mapping1 to mapping * Clean up context calls * Add doc comments * Add delegate for hiding decals in the mapping screen * Jarvis mission failed * a * Add test * Fix not flushing save stream in mapping manager * change * Fix verbs * fixes * localise --------- Co-authored-by: DrSmugleaf <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> * added relevant guides to help menus (space-wizards#30462) * added relevant guides to help menus * fixed ALL missing help-menu links * missed one * fix(ChargerSystem): Don't show battery level twice. (space-wizards#30625) * Automatic changelog update * Make pointing cooldown a cvar (space-wizards#30623) * Make pointing cooldown a cvar * Remove empty line * Don't show toggle internals verb if no breath tools are found while off (space-wizards#30622) * Don't show toggle internals verb if no breath tools are found * only if not working * Automatic changelog update * fix(Solutions): Implement missing bounds check (space-wizards#30239) * Fix verbs in mapping state (space-wizards#30631) * Remove unused variable from ThownInsertContainerSystem (space-wizards#30611) * replace all uses of TryGetContainingContainer with non-obsolete overload (space-wizards#30583) * replace all uses of TryGetContainerContainer with non-obsolete overload * rerun * Give rotten meat `Trash` and `Recyclable` tag (space-wizards#30594) * Automatic changelog update * Meta Robotics Console (space-wizards#30652) Adds robotics console to Meta * Cluster Christmas Removal (space-wizards#30635) No Fun Allowed * Update Core (space-wizards#30633) add * Box Atmos Miners Grille Removal (space-wizards#30610) Removes Grilles from around atmos miners * Fland Atmos Gas Miners Grille Removal (space-wizards#30615) Removes grilles from atmos gas miners on Fland * fml to chatsan (space-wizards#30651) * tweak(grammar): Correct multiple instances of incorrect "it's" usage (space-wizards#30641) * tweak(grammar): Correct multiple instances of incorrect "its" usage (space-wizards#30640) * Fix GhostRoleRadio icons (space-wizards#30650) Co-authored-by: plykiya <[email protected]> * Fix falsely showing damage color effect to entities that aren't allowed to be attacked (space-wizards#30661) * Explosion resistance is now predicted! (space-wizards#30654) * First commit * Added Network and access * Automatic changelog update * Fix some descriptions (space-wizards#30644) * Improve communications console countdown formatting (space-wizards#30495) * improve communications console countdown formatting * tostring * Gets rid of all leftover usages of IEyeManager.CurrentMap (space-wizards#30022) * Gets rid of all leftover usages of CurrentMap * args works * reverty * skill issue --------- Co-authored-by: plykiya <[email protected]> * Sleeper agents event no longer occurs when evacuation is called (space-wizards#30646) no more evac sleeper agents * Automatic changelog update * Give Mice Combat Mode and a 0 Damage Attack (space-wizards#30487) * Automatic changelog update * Fix warnings in ShuttleSystem.GridFill.cs (space-wizards#30253) * Fix warnings in ShuttleSystem.GridFill.cs * remove the thingie --------- Co-authored-by: metalgearsloth <[email protected]> * Move PaperSystem to Shared (space-wizards#30592) * Fix paper system late localization * IS THIS WHAT YOU WANT * well I guess this is happening now * fix the BUI * did that even do anything before? * again with the escapeformatting... * Dirtying * Move dirty to function * Rename PaperSystem to PaperVisualizerSystem * Fix namespace * how many namespace changes must I suffer through * SetContent is for Setting Content * minor shuffling * review --------- Co-authored-by: plykiya <[email protected]> Co-authored-by: metalgearsloth <[email protected]> * JobRequirement refactor (space-wizards#30347) * refactor JobRequirements * add profile support * fix * Update quartermaster.yml * sloth fixes * inport 30208 * Update DepartmentPrototype.cs * species restriction * left tweak stick * stringbuilder is cool! * Automatic changelog update * Restore the longer traitor briefing message (space-wizards#30404) * Restore the long traitor briefing * highlights * De-duplicate loadout gear (space-wizards#30341) * De-duplicate loadout gear Needs supporting code, probably with an interface with StartingGearPrototype which would also use it, but I regexed the yaml. * Code updates * Remaining yaml * Fix automatic naming * raiseEvent * Don't code when tired kids * Change the mimebot and killer tomato's descriptions (space-wizards#30639) fix those two descriptions * Update submodule to 229.1.0 (space-wizards#30664) * add(Spawners): Add a honk bot spawner (space-wizards#30616) * Missing mime mask sprites for Vox (space-wizards#30607) mime-mask-vox * Automatic changelog update * Debug command to set either your hunger or thirst to one of their respective threshold levels (space-wizards#30563) * Debug command to set either your hunger or thirst to one of their respective threshold levels * code updates * code + loc changes * Automatic changelog update * Fix random unused field warnings (space-wizards#29948) * Fix random unused field warnings Not many but it counts. * caught * Field * Change Thief Syndie & Chameleon kit contents, add Syndie codeword paper (space-wizards#30446) * Initial commit * more like bYE * Fix exception during test * Automatic changelog update * Add slowdown to low temperatures (space-wizards#29692) * TemperatureSpeed component * temperature slowdown prediction (done right) * remove unnecessary changes * that too * get in line * make it readonly * auto pause * Automatic changelog update * Refactor the `hungry` debug command to be in line with `thirsty` (space-wizards#30591) refactor the hungry debug command to be in line with thirsty Co-authored-by: metalgearsloth <[email protected]> * Fix verb sub (space-wizards#30667) * Fix verb sub Mapping casualty, verbs are weird. * also this * tweak(SolutionTransfer): Raise default max transfer amount. (space-wizards#29969) * fix(jugs): Make max and minimum transfer amounts make sense * fix name * Better * Implement bounds checks * large beaker too * More logical solution * Bleh * remove * Doesn't make sense yet WAS MISTAKEN AAAAAAAAAAAAAAD@ @! * Fix admin logs cache caching rounds forever if multiple game servers are ran on the same db (space-wizards#30687) * add(fland): Add a space cleaner dispenser to flands janitoral department (space-wizards#30695) * add(reach): Add a space cleaner dispenser to flands janitoral department (space-wizards#30697) * add(emergency_omega): Add defib to medical treatment area (space-wizards#30693) * Make biofab distinct from biogen (space-wizards#30696) * Make biofab distinct from biogen * biocube fabricator * Add comment into jetpack system, to prevent future grid jetpack PRs (space-wizards#30682) Update SharedJetpackSystem.cs * Automatic changelog update * Vox nukies and ninjafix (space-wizards#29783) * Nukie species gear * antagselectionsystem autointernals * nukie vox * skrek * Remove duplicate code * skrek * EVA tank loadouts, vox ninja update * fix prototype duplication * skrek * fix summary * fixed empty startinggear error * enable vox ninjas * Comments * removed comment because startinggearprototype should not be used on antagselection aaaanyway * squish that if * Update Content.Shared/Clothing/LoadoutSystem.cs --------- Co-authored-by: metalgearsloth <[email protected]> * better examine text for radiation collectors (space-wizards#30606) * better examine text for radiation collectors * this? * penis * Automatic changelog update * Add whitelist to cryostorage (space-wizards#30574) * Automatic changelog update * Replace xform.WorldPosition with xformSystem method for Setting/Getting (space-wizards#30029) * GET WORLD POSITON, ROTATION * Missing parentheses * ui system depndency * the issue * Unused * Let the function do the transform --------- Co-authored-by: plykiya <[email protected]> * Vox head displacement map (space-wizards#30699) * head displacement for vox * fixe * Automatic changelog update * fix(emergency_meta): Lock the doors on evac shuttle (space-wizards#29255) * fix(emergency_meta): Lock the doors on evac shuttle * marathon update (space-wizards#30714) * marathon update * marathon update * packed update (space-wizards#30716) * train update (space-wizards#30721) * train update * train * Add mapping load acts (space-wizards#30722) Smug doesn't seem to have time to fix mapping state and I don't want to dump more time into it so. * Add more storage admin logs & fix some interaction validation (space-wizards#30725) * bagel update (space-wizards#30727) * bagel update * remove invalid * Fix Mind Transfer and Role Assignment Logic for Antagonists (space-wizards#30711) * AntagSelectionSystemFix * readded the stuff that shouldn've been deleted in the first place * re-arrange * undo indentation --------- Co-authored-by: Nemanja <[email protected]> * Vox Medical Mask sprite fix (space-wizards#30702) vox medical mask * Automatic changelog update * fix(FieldGenerators): Add missing connection check (space-wizards#30468) . * Replace IClickAlert with events (space-wizards#30728) * Replace IAlertClick with events * whoop * eek! * Space Dragons can't be flashed (space-wizards#30658) * added flash immunity component to Space Dragon * Changed use of component to use of whitelist * Automatic changelog update * bagel update (space-wizards#30730) big gas miners * martathon update (space-wizards#30731) martathon * Dragdrop fold rollerbed (space-wizards#30002) * Deploy foldable * Add NetworkedComponent and access to the component * Add handled to afterinteract * Use drop target location instead of setcoordinates * Put back in hand after failed deploy This prevents dropping the bed when clicking while inside a locker. * Created BaseDeployFoldable for folding chairs, body bags, and rollerbeds * Add dragdrop to fold rollerbed to hand * Automatic changelog update * Updated remaining ghostroles for species loadouts (space-wizards#29746) * LoadoutSystem change, deathsquad species loadout * survival gear loadouts for disaster victims * skrek * centcom * syndicate agent * cburn * ERT * syndicates * Is it ever gonna be enough? * Take what you can * Move startingGearEquippedEvent after Loadouts are spawned * skreee * even more formatting * Unbreak auto internals activation * undo AddAllRoleLoadouts change * syndicate reinforcement survival loadouts * re-enable vox ghostroles * Automatic changelog update * Rename mining walls as "mining walls" (space-wizards#30729) * fix * re-check * re-check vol.2 season battle pass episode * да иди ты нахуй уже * re-cheeeck * Fix warning cone rotation in inventory (space-wizards#30672) * butter is slippery (space-wizards#29772) * butter slippery * rerun tests * standardize * Automatic changelog update * Don't disable collision on dead mobs, fixes an issue with pulling (space-wizards#30532) Update MobStateSystem.Subscribers.cs * Add more advertisements (space-wizards#30653) * Strip drag drop test (space-wizards#30754) * Add test for drag drop to open strip menu * Make screencoords change based on deadzone * Add verbose (client predicted!) examine text to Gas Miners (space-wizards#30480) * add verbose examine text to gas miners so their behaviour can be understood * no need for these to be properties * use an enum instead of two booleans for the miner state * require the gas miner to be anchored in order to not be disabled * xmldoc * pr feedback * file-scope namespace * it's to late to hide my transgressions in a rebase * turns out the normal examine distance is totally fine for this * Automatic changelog update * Update submodule to 229.1.2 (space-wizards#30764) Tests should work decently again * Remove obsolete occurrences of IComponent.Owner being assigned just before AddComponent (space-wizards#30724) * Improved Spanish accent (space-wizards#30551) * Spanish and French comment * Added the interrobang * Make spanish accent use sting builder * Automatic changelog update * remove GenericAntag completely (space-wizards#28218) Co-authored-by: deltanedas <@deltanedas:kde.org> Co-authored-by: metalgearsloth <[email protected]> * Add EntityWorldTargetAction (space-wizards#29819) * Add EntityWorldTargetAction initial implementation * Update obsolete methods * Partially working EntityWorldTargetAction * Fix entity selection * Move and clean up AfterInteract * Fix building new walls * Readd no entity or coordinates error * Consolidate action validation code * Add summaries to component --------- Co-authored-by: Ed <[email protected]> * ai stays seated and pulled while cuffed. (space-wizards#30397) * ai stays seated while cuffed. * Do the thing I thought was dumb.... whatever. * less than * more consistent CentComm naming (space-wizards#29217) * first-commit * second commit * i think i get git kinda maybe * all of resources i think * last easy changes * oops * Update Resources/Prototypes/Entities/Clothing/Head/hoods.yml --------- Co-authored-by: stroopwafel <[email protected]> Co-authored-by: Plykiya <[email protected]> Co-authored-by: metalgearsloth <[email protected]> * Buff EMP implant and grenade range (space-wizards#30660) Co-authored-by: plykiya <[email protected]> * Automatic changelog update * Teleport and delete buttons in objects tab. (space-wizards#28914) * Тыкнул и нету ЦК * review --------- Co-authored-by: metalgearsloth <[email protected]> * Add BreakOnDropItem, update do afters, remove unnecessary declarations (space-wizards#30361) * Add BreakOnDropItem, update do afters, remove unnecessary declarations * bola * Changed my mind about the nuke * gennies too * Make the comments more clear. * Sorry for the trailing commas * Revert "Sorry for the trailing commas" This reverts commit e60fd9a. --------- Co-authored-by: plykiya <[email protected]> * Automatic changelog update * Thief beacons (try 2) (space-wizards#29997) content * Automatic changelog update * Fix for issue 30781 (space-wizards#30788) Fixed typos in name and description of syndicate recruit jumpsuit. * Remove suspect figurine line (space-wizards#30795) * train update (space-wizards#30797) train fix * Add RD labcoat in RD's dresser (space-wizards#30671) * Automatic changelog update * Better DNA forensics & ReagentData (space-wizards#26699) * Added the ability for blood to track DNA using ReagentData; Forensic Scanner now accounts for solution DNA, non-DNA holders have "Unknown DNA" * Removes touch DNA for puddles, adds DNA to vomit * DNA now leaves traces in containers and those marked without don't show DNA on scan (except for puddles), gibbed parts have DNA * Fix stupid metamorphic glass bug grrr * Removed SpillableComponent since DnaSubstanceTraceComponent is used instead * Removes data field from maps, adds DNA tracking for some missed items * Give default value, fix missing values. * Fixes recipe bug * Review changes * Make the Data list into a nullable type * Revert map changes * Move gibbed unknown DNA to forensicssystem * Automatic changelog update * Scrap (space-wizards#30762) * jnk sprites * scrap pt 2 * metal inhands * hell yeah brudda * Update meta.json * Update scrap.yml --------- Co-authored-by: Flareguy <[email protected]> * Add butter slices (space-wizards#30789) * Automatic changelog update * full sticky prediction (space-wizards#30230) * move all sticky stuff to shared and cleanup/grammar fix * update imports and ref --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Secret stash refractor (space-wizards#29396) * First commit * Will do this in another PR! * maybe? * Moved stuff to ToolOpenableSystem because its smarter and cooler * offgrid mob friction (space-wizards#29383) * offgrid mob friction * save the world... * Automatic changelog update * remove UntrackedMapBoundUserInterface (space-wizards#30752) * Add random seed options to tests (space-wizards#30735) * Add random seed options to tests * Ensure profile randomization * Create Generic DamageOnInteract/Attacked Comps/Systems (space-wizards#30244) * Everything but the submodule * stuff I forgot * heat * missed lights * behonky * LocId * I guess it was a skill issue? * predicted audio * It works with lights now * Borg equality * Gorilla gauntlet grants protection from anomaly returned damage when attacking it * woops, there we go * NONE * Use DamageModifierSets, remove Behonker damage * Reviews dealt with --------- Co-authored-by: plykiya <[email protected]> * Implement a playerpanel (space-wizards#30238) * Basic structure for the player panel ui * Ensure basic functionality Player panel now receives and displays basic info * Make whitelistcommands accept user ids * Make PlayerPanel use GUIDs where possible * Add functionality to most playerpanel buttons * Implement remaining playerpanel features * Localize everything * Finish up * Put command arguments in quotes I am not sure if it's even possible to have something like a space in them considering they are guids and usernames but sure why not * Make playerpanel a verb * Add Logs button to player panel * Change Notesbutton text and make whitelistbutton a confirmtion button * Add freeze button that does not mute the player * Add sharedconnections counter to playerpanel * Make the playetime format clearer * Allow for copying of the a player's username * Do minor cleanup * Rearrange buttons * Fix unfreeze button not updating * Fix wrong localisation text * "Fix" the same role ban counting multiple times The way rolebans are stored is horrible. As such if you ban someone from a departmenrt or something role bans are individually placed for every role. The only way I found to distinguish them is the bantime. This is horrible but I do not want to rewrite how all the bans are stored right now. * Add Delete and Rejuvenate buttons to player panel By popular demand * Marginally improve ui * Add logs * review update * Fix verb * Fix double notes --------- Co-authored-by: metalgearsloth <[email protected]> * Automatic changelog update * require the warden to notify admins on disconnect (space-wizards#30745) * Automatic changelog update * Fix decal megadiffs (space-wizards#30732) Just preserves the uids and doesn't care about trying to re-map the decals lower. We have a uint to work with anyway. * Fix Panic bunker and Baby Jail being up to 14hrs incorrect. (space-wizards#30581) Fix a potential bypass for Panic bunker and baby Jail * Automatic changelog update * Add replacement words to Russian accent (space-wizards#30554) * add(FaxComponent): Allows for setting defaults in the component. (space-wizards#30484) * add(FaxComponent): Allows for setting defaults in the component. This wires up the Fax component to allow the default paper and office paper to be set. The defaults are what they were before, and it's an optional option. Now Fax machines can be set to print different paper when using Print File or other cases where the default paper style is used. * Requested change to EntProtoId. * Fix build failure. * Add minimum required trigger speed to mouse traps (space-wizards#30593) Co-authored-by: plykiya <[email protected]> * Create In-Guidebook Errors (space-wizards#28942) * Create in-guidebook errors * Localize client-facing parser error * Uncomment line * Missed another localization string * Add tooltips to the agent ID job icons and improve status icon prototypes (space-wizards#28575) * add tooltips to agentid job icons * forgot to stage this * make StatusIconPrototype abstract * minor visual improvements * cleanup * use currentculture to sort job names * review * Automatic changelog update * UI to edit silicon laws from admin verb (space-wizards#28483) * UI to edit silicon laws from admin verb (peak shitcode) * Improve UI * Use Moderator admin flag * Reviews * Automatic changelog update * Head bandana ingestion blocking fix (space-wizards#28910) * Automatic changelog update * tweak(HealthAnalyzer): Stop showing poup when used on self or when cancelled (by twitter) (space-wizards#30467) * . * Log enrichment: Explosion damage to players (space-wizards#29762) * Log enrichment: Explosion damage to players * Update Content.Server/Explosion/EntitySystems/ExplosionSystem.Processing.cs Co-authored-by: Chief-Engineer <[email protected]> * Revert to total damage variant only, currently serialised as string. * Make this its own log type. --------- Co-authored-by: Chief-Engineer <[email protected]> * Add admin logs to Rehydration comp. (space-wizards#30597) * Automatic changelog update * Fix(CuffableSystem): Check if cuffs can be transferred(dropped) (space-wizards#30465) * ugh * Revert "ugh" This reverts commit 8b5b0e2. * Revert "Automatic changelog update" This reverts commit 4f8b634. * Revert "Revert "Automatic changelog update"" This reverts commit 9fc2a33. * Revert "Revert "Revert "Automatic changelog update""" This reverts commit 1ae733b. * Revert "Revert "Automatic changelog update"" This reverts commit 9fc2a33. * Revert "" This reverts commit 1cc0953. * Revert "" This reverts commit edca368. * Revert "Revert "ugh"" This reverts commit 3ac15df. * Revert "Revert "Revert "ugh""" This reverts commit b952a45. * Revert "Revert "Revert "Revert "ugh"""" This reverts commit ff1a151. * Revert "ugh" This reverts commit 8b5b0e2. * Update SharedCuffableSystem.cs * Make hotplate and grill anchorable on table part 2 (space-wizards#29454) * Make hotplate and grill anchorable on table part 2 * Update hotplate.yml * add ghost role raffle to sentient artifact (space-wizards#30746) arti raffle * setgamepreset command rework (space-wizards#30756) * gameticker.gamepreset namespace * setgamepreset now has a finite duration * comments, cleanup * Make clickable 1% nicer (space-wizards#29706) * Make vox roundstart I believe all the issues are fixed. * Click detection bandaid * Make clickable 1% nicer Still bad. Still doesn't handle multi-viewports well. * Automatic changelog update * New decals for mapping (space-wizards#30374) * new decals * license * re-check * Automatic changelog update * Add access to gun components (space-wizards#30688) * Add access to gun components Found from an rmc14 PR. * Admin verbs proving why access needs to exist * Someone is probably going to post this pr to le reddit and complain about self-merges. * Revert "setgamepreset command rework" (space-wizards#30807) Revert "setgamepreset command rework (space-wizards#30756)" This reverts commit de86fdb. * Improve Criminal Records Computer usability (space-wizards#30292) * Avoid destroying and recreating record list on every update message * Add early-out on nullptr input * Remove sussy null suppress --------- Co-authored-by: Eoin Mcloughlin <[email protected]> Co-authored-by: metalgearsloth <[email protected]> * improve job special (space-wizards#30753) * cleanup of AddComponentSpecial * add RemoveComponentSpecial * require --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Resprite the equipped gas canister suit slots (space-wizards#30809) * add * red and generic * add meta * Automatic changelog update * Fix for stripping doafters (space-wizards#30821) Apparently I need to check if they're holding an item Co-authored-by: plykiya <[email protected]> * [Sprites/Fix] In hand for BlueSpace beaker & CMO's equipped cloak (space-wizards#28719) * [Fix] CMO's equipped cloak * [Fix] CMO's equipped cloak * [Sprites] In hands for bluespace beaker * [Sprites] In hands for bluespace beaker * [Sprites] In hands for bluespace beaker * [Sprites] In hands for bluespace beaker * Add arm64 support to packager for windows and osx (space-wizards#29723) Wanted to package a server for the funny on my macbook and noticed it was not working cause of this... now it will workie :3 * Buckling an entity requires a do-after (space-wizards#29621) * Buckling an entity requires a do-after * Works but feels like bad code? * Cleanup --------- Co-authored-by: plykiya <[email protected]> * Automatic changelog update * Crowbar variants (space-wizards#28988) * add * comma * sprites * yaml-ify * add s * lathe and engi belt * yes * fix maybe * progress * nearly there * fix * fix yaml linter having a stroke * Automatic changelog update * Crowbars fix (space-wizards#30828) * Crowbars fix * oops * Network WallMountComponent (space-wizards#30837) * Revert "Make hotplate and grill anchorable on table part 2" (space-wizards#30830) Revert "Make hotplate and grill anchorable on table part 2 (space-wizards#29454)" This reverts commit 268cab9. * Automatic changelog update * Entity Tables (EntitySpawnEntry replacement) (space-wizards#30579) * Entity table code * entity table examples * fix dat shit * access * tests tests tests * sloth review * Automatic changelog update * Changed chemistry airlock color (space-wizards#30666) * chem * re-check * re-check. again * checks just die. last try * re-check :blessrng: * Automatic changelog update * Bent pipes deal 8 thrown damage (space-wizards#30634) 8 pipe throw damage * Automatic changelog update * [S] hopefully prevents a repeat of 4 am on 8/10/2024 in the #server-leviathan-use channel (space-wizards#30851) cant test this because the documentation sucks ass but fuck it we ball * Change siren.ogg to gamma.ogg (space-wizards#30836) * remove TerminatorRoleComponent (space-wizards#30733) * Add Rat Kings wideswinging (space-wizards#30808) Update regalrat.yml * Automatic changelog update * Added suitskirt for psychologist (space-wizards#30709) * Added jumpskirt * added locale * Added spaces in code * Updated the meta * Automatic changelog update * ERT Chaplain Loadout fixer (space-wizards#30855) Chaplain fixy * Automatic changelog update * Infer type for EntSelector (space-wizards#30856) Infer type for EntSelector.cs * Partially revert light tube sprites (space-wizards#29091) * add * reduce contrast * Automatic changelog update * Cursed Mask (space-wizards#29659) * Cursed Mask * extra expressions * block ingestion * mind returning * okay fix the removal shit * Fix some locales (space-wizards#30860) * Fix some locales * forgor * space-wizards#30851 followup - murderficates links (space-wizards#30863) kneecaps links while we're at it * Remove meta voiceline from the passenger figure (space-wizards#30868) Update figurines.ftl * Standartize clothing recipes (space-wizards#29315) * Automatic changelog update * Reach tweaks reattempt 2 (space-wizards#30782) * uhhh fix stuff maybe * - added a fax machine - made botany slightly bigger to accommodate a nutrimax vending machine - added air alarms, scrubbers and a waste pipe network * tweak(snowy_labs): Remove non-valid holoparasite (space-wizards#30875) * Custom burgers - FoodSequence system (space-wizards#30755) * setup foodsequence * name generation and max layers limit * move to nutrition * move code to serverside * move to appearance data * marked fields as required * Update foodsequence.yml * b * burgeers! * Update produce.yml * Update meat.yml * Update burger.yml * fix duplicate naming * Update Resources/Locale/en-US/nutrition/components/food-sequence.ftl Co-authored-by: Hrosts <[email protected]> * merge flavor profiles * make food trash List<> * merge trash * Update FoodComponent.cs * Update FoodComponent.cs * organs and cannabis support --------- Co-authored-by: Hrosts <[email protected]> * Automatic changelog update * chore(bagel): Remove EntityStorageComponent (space-wizards#30881) * chore(meta): Remove EntityStorageComponent (space-wizards#30883) * chore(omega): Remove EntityStorageComponent (space-wizards#30879) * chore(marathon): Remove EntityStorageComponent (space-wizards#30877) * chore(atlas): Remove EntityStorageComponent (space-wizards#30876) * tweak(oasis): Lower the engineering borg spawn (space-wizards#30874) * add(meta): Add missing airvent to airlock (space-wizards#30871) * Updated Core boxing ring beacon (space-wizards#30800) Updated boxing ring beacon to be correctly labeled * tweak(Shuttle_honki): Replace clown spiders with honkbots (space-wizards#30617) * Automatic changelog update * Vox Minor Clothing Update 2: Electric Boogaloo (space-wizards#30838) * more vox masks n stuff * cluwne * fix * merc gas mask * bunny tail height fix * Automatic changelog update * Remove lube and glue grenades from roundstart loadouts. * Revert "Added Medical Patches (space-wizards#452)" This reverts commit e40a34c. * Revert "Revert "Added Medical Patches (space-wizards#452)"" This reverts commit c4aab23. * Revert "Revert "Revert "Added Medical Patches (space-wizards#452)""" This reverts commit ac172da. * Revert "Set Outfit as an admin works again!!!!!! (space-wizards#392)" This reverts commit 87700a9. * Please * Finally fixed? --------- Co-authored-by: Repo <[email protected]> Co-authored-by: PJBot <[email protected]> Co-authored-by: JustCone <[email protected]> Co-authored-by: Alzore <[email protected]> Co-authored-by: IProduceWidgets <[email protected]> Co-authored-by: OrangeMoronage9622 <[email protected]> Co-authored-by: to4no_fix <[email protected]> Co-authored-by: RiceMar1244 <[email protected]> Co-authored-by: EmoGarbage404 <[email protected]> Co-authored-by: lzk <[email protected]> Co-authored-by: slarticodefast <[email protected]> Co-authored-by: Joel Zimmerman <[email protected]> Co-authored-by: Brandon Hu <[email protected]> Co-authored-by: voidnull000 <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DrSmugleaf <[email protected]> Co-authored-by: DrSmugleaf <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> Co-authored-by: Ian <[email protected]> Co-authored-by: Mervill <[email protected]> Co-authored-by: Ubaser <[email protected]> Co-authored-by: Plykiya <[email protected]> Co-authored-by: plykiya <[email protected]> Co-authored-by: beck-thompson <[email protected]> Co-authored-by: Killerqu00 <[email protected]> Co-authored-by: Cojoke <[email protected]> Co-authored-by: Simon <[email protected]> Co-authored-by: Ed <[email protected]> Co-authored-by: Errant <[email protected]> Co-authored-by: foboscheshir <[email protected]> Co-authored-by: SlamBamActionman <[email protected]> Co-authored-by: Nemanja <[email protected]> Co-authored-by: Flareguy <[email protected]> Co-authored-by: Emisse <[email protected]> Co-authored-by: Leon Friedrich <[email protected]> Co-authored-by: NakataRin <[email protected]> Co-authored-by: Lye <[email protected]> Co-authored-by: ShadowCommander <[email protected]> Co-authored-by: Ko4ergaPunk <[email protected]> Co-authored-by: Mr. 27 <[email protected]> Co-authored-by: TakoDragon <[email protected]> Co-authored-by: deltanedas <[email protected]> Co-authored-by: strO0pwafel <[email protected]> Co-authored-by: stroopwafel <[email protected]> Co-authored-by: Vigers Ray <[email protected]> Co-authored-by: saintmuntzer <[email protected]> Co-authored-by: dffdff2423 <[email protected]> Co-authored-by: themias <[email protected]> Co-authored-by: nikthechampiongr <[email protected]> Co-authored-by: Psychpsyo <[email protected]> Co-authored-by: CaasGit <[email protected]> Co-authored-by: Thomas <[email protected]> Co-authored-by: Stalen <[email protected]> Co-authored-by: TsjipTsjip <[email protected]> Co-authored-by: Chief-Engineer <[email protected]> Co-authored-by: Ilya246 <[email protected]> Co-authored-by: eoineoineoin <[email protected]> Co-authored-by: Eoin Mcloughlin <[email protected]> Co-authored-by: MureixloI <[email protected]> Co-authored-by: Vasilis <[email protected]> Co-authored-by: deathride58 <[email protected]> Co-authored-by: Unkn0wn_Gh0st <[email protected]> Co-authored-by: shamp <[email protected]> Co-authored-by: MerrytheManokit <[email protected]> Co-authored-by: Kukutis96513 <[email protected]> Co-authored-by: Hrosts <[email protected]> Co-authored-by: Preston Smith <[email protected]>

# Description  Link to every PR I cherry-picked: 1. new-frontiers-14/frontier-station-14#2283 2. space-wizards/space-station-14#29219 3. space-wizards/space-station-14#30075 4. space-wizards/space-station-14#28639 5. space-wizards/space-station-14#32527 6. space-wizards/space-station-14#28030 7. space-wizards/space-station-14#28178 The main purpose of this PR is the first cherry-picked PR. It adds the ability for admins to reply to ahelps via discord using an HTTP POST request. See all relevant details in the initial PR by Myzumi. --------- Co-authored-by: Myzumi <[email protected]> Co-authored-by: Whatstone <[email protected]> Co-authored-by: Whatstone <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> Co-authored-by: to4no_fix <[email protected]> Co-authored-by: Repo <[email protected]> Co-authored-by: Chief-Engineer <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Leon Friedrich <[email protected]> Co-authored-by: ShadowCommander <[email protected]>

# Description  Link to every PR I cherry-picked: 1. new-frontiers-14/frontier-station-14#2283 2. space-wizards/space-station-14#29219 3. space-wizards/space-station-14#30075 4. space-wizards/space-station-14#28639 5. space-wizards/space-station-14#32527 6. space-wizards/space-station-14#28030 7. space-wizards/space-station-14#28178 The main purpose of this PR is the first cherry-picked PR. It adds the ability for admins to reply to ahelps via discord using an HTTP POST request. See all relevant details in the initial PR by Myzumi. --------- Co-authored-by: Myzumi <[email protected]> Co-authored-by: Whatstone <[email protected]> Co-authored-by: Whatstone <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> Co-authored-by: to4no_fix <[email protected]> Co-authored-by: Repo <[email protected]> Co-authored-by: Chief-Engineer <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Leon Friedrich <[email protected]> Co-authored-by: ShadowCommander <[email protected]> (cherry picked from commit b8e75dae0e25301da4ffdd1f6ca5b4aebdf5a2b8)

* Fix Power Attacks Being Faster Than Left Clicks (#1252) # Description This fixes some stupid math. Power attacks are now correctly slower than left clicks. Previously they were faster. # Changelog :cl: - fix: Power Attacks now correctly apply a penalty on swing speed, and are no longer faster than left clicking. (cherry picked from commit 049a995f64c42734e5286229b524161a730aaea9) * Automatic Changelog Update (#1252) (cherry picked from commit 8a88bfd11f1384fa2fb01fd7ace6477202a68499) * Tweak Wizden Trait Descriptions (#1260) # Description Converted the descriptions of most wizden traits to a more formal and roleplay-oriented style, also clarifying some aspects of other traits in the process. --- TODO: - [ ] Test this --- # Changelog :cl: - tweak: Tweaked the descriptions of most Wizden traits to be more vivid and descriptive. --------- Signed-off-by: Mnemotechnican <[email protected]> (cherry picked from commit 411cb213ac9ab2e6a0b790e72b25a142a4945217) * More Trait Functions (PushMarkup & AddArmor) (#1253) # Description This PR effectively "Reworks" several of the Bionic Traits through use of new modular TraitFunctions. These being, **TraitPushDescription**: Ensures that an entity has the new ExtendDescriptionComponent, then writes to said component. ExtendDescriptionComponent serves as a new highly modular "One stop shop" for any system wanting to add text to the shift-click examine window. It even accepts arguments for text color, font size, and whether or not a person must be standing within touching distance to "See" the provided texts. It accepts arbitrarily any number of descriptions. **TraitAddArmor**: This takes advantage of a new functionality for the DamageableSystem, whereby entities are able to have more than one DamageModifierSet. This allows arbitrarily any number of traits to add as many modifier sets as desired, without fear of any compatibility issues. These can be both negative and positive, and as Skubman has pointed out, this can also be used to create negative traits that make a character more vulnerable to a given damage type! Additionally, most of the Bionics Traits have been reworked. CyberEyes has been split into two modules, one for the base implant, and one for the Flash Protection. Dermal Armor has been reworked using TraitAddArmor, so that it no longer replaces your original modifier set, and instead stacks multiplicatively with whatever your original species modifier set was. Thus, it can now be taken by any species. # TODO <details><summary><h1>Media</h1></summary> <p> TraitPushDescription ![image](https://github.com/user-attachments/assets/4661671a-6f20-4cb1-9fad-41c36f7ad79e) TraitAddArmor ![image](https://github.com/user-attachments/assets/bbc823e1-73bf-471d-b5f6-ef8cdf35c746) </p> </details> # Changelog :cl: - add: Five new functions for the Trait System, AddArmor, PushDescription, ModifyMobThresholds, AddSolutionContainer, and ModifyStamina. - tweak: CyberEyes Basic System has been split, now Flash Protection is a separate module. - add: Dermal Armor no longer replaces your original species damage resistances. It now stacks multiplicatively with your original resistances. - tweak: Dermal Armor can now be taken by any species, not just Humans. - add: Dermal Armor, and Bionic Arms can now be revealed by a close examination. Shift click on someone within touching distance will reveal if they have these "Obvious" cyberware. --------- Signed-off-by: VMSolidus <[email protected]> Co-authored-by: Remuchi <[email protected]> (cherry picked from commit 29d2cb1ed85ab089d83c702f7405e938a0d9374c) * Automatic Changelog Update (#1260) (cherry picked from commit 8d54aa2fffdd3726e948d6d228287b01c0a81413) * Feat: Anomaly Scanner Data Copying (#1250) # Description Makes it so that using one anomaly scanner on another transfers the anomaly data onto the used scanner. <details><summary><h1>Media</h1></summary> <p> ![image](https://github.com/user-attachments/assets/b212e6e8-58a3-4a64-a216-3ba496a81d4a) </p> </details> # Changelog :cl: - add: You can now touch one anomaly scanner with another to copy the anomaly scan data from it. (cherry picked from commit 0574be444b90137808c07f85e10b59c464f054cf) * Automatic Changelog Update (#1253) (cherry picked from commit 6fa8d6817fa81e6d6d20b61f5ec4b7b96fdb185b) * Automatic Changelog Update (#1250) (cherry picked from commit 1b5704535ce42041c068d201cdb447af42004c20) * Rename "Pierce" Typo to "Piercing" (#1267) # Description Oops. Some files refer to the non-existent **Pierce** damage type when the proper name is **Piercing**. # Changelog :cl: Skubman - fix: Piercing damage can now dismember body parts, just like Blunt and Slash damage. (cherry picked from commit 992b2e486855cea6646cf5d4af51ca8cbf61b29d) * Buff Medical Due to Shitmed Changes Cherry-Pick (#1259)  # Description  + Buffed applicable medication heal values. + Buffed applicable medication stack sizes. + Slightly buffed dylovene, burn, and brute chems. + Buffed applicable medication doAfter delay from 3s to 2s. --- ## Why / Balance  This change was made with the advent of the new Limb Damage system. This PR seeks to achieve making SS14 Medical more equivalent to SS13 Medical when it comes to healing damage values. This was done as Bruise Packs and Ointment only heal 5 Brute or 5 Burn respectively when applied to a limb. When each limb has a 100 Crit threshold, this can make it extremely hard even with surgery to heal limbs in the absence of Chemicals. Furthermore on higher pop, this will lead to people burning through applicable meds even faster than before Limb Damage was implemented. It would take 34 bruise packs to heal someone with 170 Blunt spread out across their limbs, with this change it would reduce that to 12 bruise packs. Full list of numerical val changes: - Healing component doAfter Delay reduced. was 3s, now its 2s. - Applicable medical items now have a max stack size of 15 (was 10). - Ointment heals 15 of each burn type, 10 caustic (was 5 of each burn type, 1.5 caustic) - Mesh now heals 20 of each burn type (was 10 of each burn type). - Bruise Packs now heal 15 of each brute type (was 5 of each brute type) - Sutures now heal 20 of each brute type (was 10 of each brute type) - Bloodpacks now heal 2.5 Bloodloss & restore 10% bloodlevel (was .5 Bloodloss and 5%) - Gauzes now heal 15 Slash and 20 Pierce (was 5 Slash and 10 Pierce) - Dylovene now heals 1.5 Poison per .5u (was 1 Poison per .5u) - Bicaridine now heals 2.5 Brute per .5u (Was 2 Brute per .5u) - Dermaline now heals 2 Burn per .5u (was 1.5 Burn per .5u) - Epinephrine now heals 1 Burn & 1 Brute per .5u (was .5 for each per .5u) - Kelotane now heals .5 Burn per .5u (was .33 Burn per .5u) - Omnizine now heals 3 Burn, Toxin, Airloss, and Brute per .5u (was 2 per .5u) - Lacerinol now heals 4 Slash per .5u (was 3 per .5u) - Bruizine now heals 4 Blunt per .5u (was 3.5 per .5u) # TODO  - [x] Cherry-pick Medical changes merged in Goobstation ---  --- ## Breaking changes  Should values be overtuned, they can be reduced in a future PR or before this PR is merged. **Changelog**  :cl: - tweak: Increased applicable medication heal values. - tweak: Increased stack size of applicable medications. - tweak: Slightly increased dylovene, burn, and brute chemicals heal values. - tweak: Decreased Medical item application time from 3s to 2s --------- Signed-off-by: sleepyyapril <[email protected]> Signed-off-by: Tmanzxd <[email protected]> Co-authored-by: sleepyyapril <[email protected]> (cherry picked from commit b431d24f86f94433ea0c53982db83e40ef1d3f2c) * Automatic Changelog Update (#1267) (cherry picked from commit 02dd8ab06333a5b2dabe03845bfd6719ca09ef48) * Automatic Changelog Update (#1259) (cherry picked from commit 09d59007d4c55ee9f7daa0f56cae672c51951843) * The Blood Cult (#1001)  # Description Adds a new game mode - The Blood Cult. Hail to Nar'Sie! --- # TODO - [x] Gamemode - [x] Roles - [x] Runes - [x] Constructs - [x] Structures - [x] Forge - [x] Archives - [x] Altar - [x] Pylon - [x] Structure - [x] Placement System - [x] Airlocks - [x] Repulsor system - [x] Construction system - [x] Items - [x] Eldritch Whetstone - [x] Construct Shell - [x] Mirror Shield - [x] True Nar'sian Hardened Armor - [x] Flagellant's Robe - [x] Eldritch Longsword - [x] Zealot's Blindfold - [ ] Night vision system - [x] Shuttle Curse - [x] Veil Shifter - [x] Void Torch - [x] Reagents - [x] Holy Water - [ ] Actions - [x] Cult Magic - [x] Stun - [x] Teleport - [x] Electromagnetic Pulse - [x] Shadow Shackles - [x] Twisted Construction - [x] Summon Combat Equipment - [x] Summon Ritual Dagger - [x] Blood Rites - [ ] Cult Leader Magic - [ ] Final Reckoning - [ ] Mark Target - [ ] Eldritch Pulse - [ ] Construct's Magic - [ ] Artificer - [ ] Summon Cult Floor - [ ] Summon Cult Wall - [ ] Greater Conjuration - [ ] Summon Soulstone - [ ] Wraith - [ ] Phase Shift - [ ] Juggernaut - [ ] Shield - [ ] Gauntlet Echo - [x] Cult leader selection system - [ ] Rending/Apocalypse rune placement markers EXTRA: - [ ] Spirit Realm rune - [x] Eldritch language - [ ] Conceal magic - [ ] Ru locale ---  <details><summary><h1>Media</h1></summary> <p> ![Example Media Embed](https://example.com/thisimageisntreal.png) </p> </details> --- # Changelog :cl: - add: Added Blood Cult Gamemode. --------- Signed-off-by: VMSolidus <[email protected]> Signed-off-by: Remuchi <[email protected]> Co-authored-by: VMSolidus <[email protected]> (cherry picked from commit 150020866ddd383f297dfccd7717017c23222d82) * fix * Automatic Changelog Update (#1001) (cherry picked from commit a179e186fa812e5dbce34983e11ef7af56ccdcf4) * Engine Update v237.2.0 (#1270)  # Description  Updates to engine version v237.2.0. Fixes disposals systems breaking and not using the proper direction. --------- Co-authored-by: sleepyyapril <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> (cherry picked from commit dcc1c38fb729b00fdb15b79b38372f3e1e8bc951) * [QoL] Show Oni Damage Bonus In Damage Examine (#1268) # Description Examining an item's damage values as an Oni now calculates your bonus damage, and it also works with all of the Oni combat traits. ## Technical details `OniSystem`, instead of adding melee damage through `MeleeHitEvent`, now adds damage through `GetMeleeDamageEvent`, the same event that examining melee weapon damage raises through `GetDamage`. ## Media **Normal damage values** <img src="https://github.com/user-attachments/assets/9de255ef-29e6-4119-93cc-356349812a6f" width=300px> **Oni damage values** <img src="https://github.com/user-attachments/assets/18d44aaf-5a70-4ba9-a8c8-be29e92d7267" width=300px> # Changelog  :cl: Skubman - tweak: As an Oni, examining the damage values of weapons now takes into account the melee damage bonus from your species or trait. (cherry picked from commit 613e7937392d5d4fd9bf906f571adc237c706367) * Automatic Changelog Update (#1268) (cherry picked from commit 5fe4b1e94b987f787807cc10df06f667b87d124e) * Loadouts V4 (#1164) # Description # TODO - [x] Custom name/desc/color tint, toggleable individually per-loadout - [x] Fix them not changing correctly between profiles in-editor - [x] Preview colors in the lobby - [x] Allow the users to null the color themselves (and default it to such) - [x] Pick what should be allowed to be recolored - [x] Guidebook links - [x] Make an example - [x] Special components for loadouts - [x] Heirlooms - [x] Pick what should have heirlooms - [x] Decimate lag - [x] Fix live character preview - Maybe do characters per job - Rethink unusable --- <details><summary><h1>Media</h1></summary> <p>  https://github.com/user-attachments/assets/bcf61517-6b64-40d2-b299-7462e2469fe2 </p> </details> --- # Changelog :cl: - add: Players can set custom names, descriptions, and color tints for their loadout items - add: Certain loadouts may have Guidebook pages shown in the editor - add: Players can pick a list of loadout items to have one randomly be their family heirloom for a mood bonus or deficit if they are carrying it - fix: Loadouts have almost as little lag as possible (hopefully none) - fix: Everything properly updates your character editor's live preview --------- Signed-off-by: DEATHB4DEFEAT <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: VMSolidus <[email protected]> Co-authored-by: Pspritechologist <[email protected]> (cherry picked from commit f0463062812428625da9e8adad60c8a567fdacbe) * Automatic Changelog Update (#1164) (cherry picked from commit 57917a746f514aba3f142d870a9280c9b1eb9a4f) * [Fix] Added Robust.Xaml to the Project Solution (#1266) Mirrors https://github.com/space-wizards/space-station-14/pull/31573 Signed-off-by: Remuchi <[email protected]> (cherry picked from commit 1d65d548e69862295926fb08aee962d8fbd0b5c4) * Update Credits (#1274) This is an automated Pull Request. This PR updates the GitHub contributors in the credits section. Co-authored-by: SimpleStation Changelogs <[email protected]> (cherry picked from commit 39f4ad8a8884bc5bb9e64530b1a708ea41b4de32) * Fixes Make Cultist Admin Verb to Act on Target Not Self (#1289) There's a small error on the admin verb for blood cultists which made the verb only work on self. This fixes it. (cherry picked from commit 6c2b2a8a4ab7c7b0c5e18d796ccd94d09b087509) * IPC Instrument Menu Fix (#1287)  # Description  Fixes IPCs being unable to use the midi menu. --- # Changelog  :cl: - fix: Fixed IPCs being unable to use the midi menu. (cherry picked from commit f133b9b7cf175815a3c6de59d541e12f0fc60790) * Automatic Changelog Update (#1287) (cherry picked from commit 92a6e099fca1581ea8a0cfd16bf7f13ae8d1108a) * Change Target Doll Icon For Ashen Theme (#1282) # Description ![target_doll](https://github.com/user-attachments/assets/1fdcd665-251f-4a3f-b80e-e11b77f13eef) (cherry picked from commit 327247585612d9d65e20b8b856864701ceb1c933) * Fix Applicable Medication Stack Bug (#1278)  ## About the PR  - Fixed a bug where applicable medication stacks would revert back to 10 after 1 use. ## Why / Balance  - Did you know maxstacks were stored in a separate YML? Me neither, until now. **Changelog**   :cl: - fix: Fixed a bug where applicable medication stacks would revert back to 10 after 1 use from full. Signed-off-by: Tmanzxd <[email protected]> (cherry picked from commit d4879f9129ae484f24f57eb642cc7d600f2323e0) * Automatic Changelog Update (#1278) (cherry picked from commit 8d485e8c0d4e3932835aeed210388e85988a0213) * Re-Enable Language Color and Font (#1294) # Description Re-enables language font and colors showing up in chat messages. The language font/colors were bugged after adding language names in chat (https://github.com/Simple-Station/Einstein-Engines/pull/1165) I also overhauled the format for chat messages to be more aesthetically pleasing, and made sure chat bubbles use the language color/font. ## Media **Nekomimetic** ![image](https://github.com/user-attachments/assets/4cb88d7b-7466-42ed-bf2d-b68c68edb62c) ![image](https://github.com/user-attachments/assets/adec7fd7-0a84-4e21-9eff-c1a387e2d529) **Bubblish** ![image](https://github.com/user-attachments/assets/c49f5573-ac96-4375-a584-e8b2cc6f5fee) ![image](https://github.com/user-attachments/assets/c739c249-9d1e-453e-9e92-3f7ef24a4d61) **Tau-Ceti Basic (Default Language)** ![image](https://github.com/user-attachments/assets/e6660039-ac2f-449b-96e0-44e0142d3715) ![image](https://github.com/user-attachments/assets/2baec2ca-975d-4111-85b0-3b2056fdd7f7) **Rootspeak** ![image](https://github.com/user-attachments/assets/99d94f8d-9a1c-4be9-8c98-b42c9c7cffd7) ![image](https://github.com/user-attachments/assets/c20b4621-1ca7-42f5-a22a-82c9a4d1dddf) ## Changelog :cl: Skubman - fix: Language colors and fonts will show up in text messages again, both on in-person messages and on the radio. - tweak: The text on chat bubbles now uses the color and font of the language being spoken. - tweak: The language prefix before the name on chat messages now uses the language's color. (cherry picked from commit 1a9763528a9b15f11f474a2fa7ecfdde98aa9a15) * Automatic Changelog Update (#1294) (cherry picked from commit 7d802e35dc45c37016681c3a009bdaebe2707178) * Shitmed Update 2 - [Insert Snarky Remark] (#1271) # Description ![image](https://github.com/user-attachments/assets/b10f1e33-94fb-4ded-a644-b9945b58dbc5) Honey wake up, another shitmed PR with 5 features and a trillion bugs! I love bloat. --- # Known Bugs - A lot of shit with changelings lol - Markings suddenly disappear from your entity apparently at random. Wizden exclusive issue as of now. - Fire heretics explode when ascending due to part damage shitcode (sorry) - Some exceptions/null point references at round end, tentatively related to salvage corpses. - Slots having wonky behavior due to not being networked. More of a broad issue with how I implemented them initially. - Arachne are FUCKED with surgery, I was incredibly tempted to set them to roundstart: false, but I'll try to hotfix it this week. --- # Changelog :cl: Mocho, Deltanedas - add: Ported Ghetto Surgery from Deltanedas! - add: Ported fishops organs from Deltanedas! - add: Added different step durations to each surgery step. - add: Added a T2 research for advanced surgical tools - add: Added a T3 research for an omnitool for surgery. - add: Added Surgical and Advanced Surgical modules for Mediborgs - add: Mediborgs can now perform surgery! - add: Added lobotomies as an operation. Godspeed you psychopaths. - add: Added cybernetic arms, legs and eyes. - add: Added EMP weaknesses to all cybernetic parts (the day of reckoning will come for IPCs soon) - add: Losing your eyes now blinds you. - fix: Fixed a few species that did not inherit from BasePart's, thus taking damage types they shouldn't on their limbs. - fix: Fixed harpy lungs not being usable in surgeries. - fix: Fixed biosynthetic and other printable parts not allowing you to attach body parts to them. - fix: Fixed fire being able to destroy your chest. - fix: Fixed entities being able to take over your body by just inserting a brain or another head on top of you. - fix: Fixed some shitcode that didnt let rejuvenate or godmode work properly. - fix: Fixed bionic arm, and cybernetic eyes traits not working properly due to shitty networking. - tweak: Increased tend wounds's speed by double, and bumped up the values on its calculations. DEATH TO TOPICALS, LEAVE THOSE TO TIDERS. - tweak: Beheading an entity now doesnt let it move, speak, and forces it to the ground immediately (literally 1984!!11!!) - tweak: Changed sprites on most surgical tools to now use /tg/ sprites. - tweak: Unbound shitmed targeting doll keybinds by default (did you know we have those). --------- Signed-off-by: gluesniffler <[email protected]> Co-authored-by: FoxxoTrystan <[email protected]> Co-authored-by: goet <[email protected]> Co-authored-by: Saphire Lattice <[email protected]> (cherry picked from commit 2eafa0d47e7b9a3270ae797f82dd7b1772dffb15) * Admin Tooling Cherry Picks (#1290)  # Description  Link to every PR I cherry-picked: 1. https://github.com/new-frontiers-14/frontier-station-14/pull/2283 2. https://github.com/space-wizards/space-station-14/pull/29219 3. https://github.com/space-wizards/space-station-14/pull/30075 4. https://github.com/space-wizards/space-station-14/pull/28639 5. https://github.com/space-wizards/space-station-14/pull/32527 6. https://github.com/space-wizards/space-station-14/pull/28030 7. https://github.com/space-wizards/space-station-14/pull/28178 The main purpose of this PR is the first cherry-picked PR. It adds the ability for admins to reply to ahelps via discord using an HTTP POST request. See all relevant details in the initial PR by Myzumi. --------- Co-authored-by: Myzumi <[email protected]> Co-authored-by: Whatstone <[email protected]> Co-authored-by: Whatstone <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> Co-authored-by: to4no_fix <[email protected]> Co-authored-by: Repo <[email protected]> Co-authored-by: Chief-Engineer <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Leon Friedrich <[email protected]> Co-authored-by: ShadowCommander <[email protected]> (cherry picked from commit b8e75dae0e25301da4ffdd1f6ca5b4aebdf5a2b8) * Automatic Changelog Update (#1271) (cherry picked from commit d58d397a69fc2bb5b2bbce9280a978d5d899bba0) * More Loadout Equipment (#1281) # Description This PR adds a bunch more equipment selections for Engineering loadouts, plus Suit/Skirt selections for the jobs that were missing it. <details><summary><h1>Media</h1></summary> <p> ![image](https://github.com/user-attachments/assets/031224b4-e348-4030-9ea4-7f2dbc64c87d) </p> </details> # Changelog :cl: - add: All engineering roles have had their equipment loadouts significantly expanded upon. Engineers can now buy construction materials with their loadout points. - fix: All engineering jobs now have their Suit/Skirt selection via loadouts. - add: Salvage techs can now select from a variety of knife options to start their spess adventures with. - add: Epistemics staff now have *some* equipment selection options that they share. More to come when I finish making the Potentiometer. (cherry picked from commit 0bd9a9ea81c2e6e9ef775a131b547b8b861548b1) * Automatic Changelog Update (#1281) (cherry picked from commit c7f1b4fa3c57f3650154150e1c30ce28e3302230) * Dynamic Hostname System (#1296)  # Description  Change your hostname whenever map, preset, or runlevel changes! Variables given on all hostname locale strings: - {$mapName} - The name of the current map. - {$preset} - The name of the current preset. - {$originalHostname} - What you originally had game.hostname set to, before updating. ---  <details><summary><h1>Media</h1></summary> <p> ![image](https://github.com/user-attachments/assets/97cba40b-5ceb-40f8-91e4-93450cd22b78) ![image](https://github.com/user-attachments/assets/2cf27e65-b493-4916-bedd-aa69eaa0135b) ![image](https://github.com/user-attachments/assets/234f5be0-7a8c-41e1-abdf-10e9c6700a90) ![image](https://github.com/user-attachments/assets/522525d6-fb23-45b9-b559-deffb3f37a58) </p> </details> --- # Changelog  nah (cherry picked from commit de98c2aec2c072abeb6c81c74b830d72e29ba0c8) * Religious Headgear For Character Customization (#1297) # Description This PR adds a few articles of various kinds of religious headgear to loadouts, namely a Hijab, Turban, and Kippah. All 3 are whitescale items that are set as colorable, allowing players to make them whatever color is desired. Farida can finally have the pink Hijab she was always supposed to have. <details><summary><h1>Media</h1></summary> <p> ![image](https://github.com/user-attachments/assets/35fca330-98ba-439b-8e23-eec917b0d30c) </p> </details> # Changelog :cl: - add: Added various articles of religious headgear to loadouts, such as Hijab, Kippah, and Turban. All of these are set to allow custom colors. (cherry picked from commit e46a8636eb235e627023cdd3d42428b34c134353) * Automatic Changelog Update (#1297) (cherry picked from commit 56be69053045a2d2184c975c2325889df69838e0) * Don't Require Running in Release to Test Mood (#1257) (cherry picked from commit f2871885b6dd13b418dfd7ff55ffe0559a4f7044) * Update Credits (#1300) This is an automated Pull Request. This PR updates the GitHub contributors in the credits section. Co-authored-by: SimpleStation Changelogs <[email protected]> (cherry picked from commit 9ef825252a0dc0054b1ba9626e7283d296150f3b) * Start of Lore Documents (cherry picked from commit dfb12e53abf1ef5d767240a19b28ba12dd35ef9b) * Finally Done (cherry picked from commit 2a8bf58dfc61f24796a55940e4a7ab6be3ced3ec) * Automatic Changelog Update (#1298) (cherry picked from commit 8a368bbdce5dd05adae998ec55f15fd5ff04b52f) * Fashion Update: Earrings & Makeup (#1299) # Description Adds **38** new earrings, **31** new face markings, and **16** bracelet/watch markings, based from Aurorastation cosmetics. Each earring, bracelet, and watch marking is applied to just one side of the body, allowing for greater customizability and mixing-and-matching markings. Most notably, the new face markings unlock **full customization of every pixel** in the 5x4 pixel space of the face. Examples of this are shown below. Arachne now have access to **more than a hundred** markings above the leg, after not having any markings in their 2 years of existence. ## Media ### Pauline <img height=270px src="https://github.com/user-attachments/assets/8316effb-34b3-4fa1-a80f-af2a3cd670c2"> <img height=270px src="https://github.com/user-attachments/assets/be75770a-c5bb-46a7-afb4-2ec54bd5a5e5"> **Head (Side):** Drop Earrings (Left), Drop Earrings (Right) **Left Hand:** Left Bracelet ### Red and Blue <img height=270px src="https://github.com/user-attachments/assets/8c1356fc-6eaa-484f-afb6-5ace7f45d895"> **Head:** Cheek Spot (Left), Eye Corner (Left), Cheek Spot (Right), Eye Corner (Right) **Head (Side):** Double Gemstone Earrings (Left), Double Gemstone Earrings (Right) **Left Hand:** Left Watch (Colorable) **Left Arm:** Left Arm Bracelet **Right Hand:** Right Watch (Colorable) **Right Arm:** Right Arm Bracelet ### Pink <img height=270px src="https://github.com/user-attachments/assets/ae376cc3-7cd5-4e91-a3a0-ebe48202f5e6"> **Head (Side):** Hoop Earrings (Left), Double Gemstone Earrings (Right) **Left Hand:** Left Bracelet **Left Arm:** Left Arm Bracelet **Right Hand:** Right Bracelet **Right Arm:** Right Arm Bracelet ### Psychic <img height=270px src="https://github.com/user-attachments/assets/eaa8069a-2e51-4456-a315-414aa64cd41a"> **Head:** Bindi, Full Blush **Head (Side):** Long Crystal Earrings (Left), Long Crystal Earrings (Right) **Left Hand:** Left Bracelet **Right Hand:** Right Bracelet **Right Arm:** Right Arm Bracelet ### Cyclops <img height=270px src="https://github.com/user-attachments/assets/55e67db9-0aa4-488d-a25b-32e8fd92044b"> **Head [Eyes]:** Bindi, Glabella, Nose Tape **Head [Cover for mouth area]:** Lip Corner (Left), Lip Corner (Right), Cheek Spot (Left), Cheek Spot (Right), Lips **Head (Side):** Cross Earrings (Left), Cross Earrings (Right) ### 😂 <img height=270px src="https://github.com/user-attachments/assets/4001b95a-60e1-431c-8463-1e2904cf767a"> ### Arachne ![image](https://github.com/user-attachments/assets/b9935347-8977-4424-9b9b-b08aecb458b2) **Head:** Left Arachne Eye, Right Arachne Eye, Lips, Neck Cover (Slim Thick) **Head (Side):** Long Crystal Earrings (Left), Long Crystal Earrings (Right) **Left Arm:** Left Robotic Arm from Hesphiastos Industries **Left Hand:** Left Robotic Arm from Bishop Cybernetics **Right Arm:** Right Arm Bracelet **Right Hand:** Right Watch (Colorable), Right Nail Polish ## Technical Details I did a quick fix in [MarkingsSet.cs](https://github.com/Simple-Station/Einstein-Engines/compare/master...angelofallars:Einstein-Engines:fashion-update-markings?expand=1#diff-54373833c74b35579f9b3293d5bb0c17eda0d214c11f27dcb40c334ef8c6b513) to handle a list index out of bounds error where the number of default markings was lower than the maximum allowed markings, like with Onis who have a default horn but can wear 2 earrings. # Changelog  :cl: Skubman - add: 80+ new markings have arrived, including earrings, makeup, bracelets, and watches. Sashay over to Character Setup to personalize your character like never before! - add: The Arachne species can now select markings above the leg, including cybernetics, makeup, tattoos, noses, earrings, heterochromia, bracelets, gauze, and more! - tweak: The available points for Head (Side), Left Hand, and Right Hand markings have been increased for most species to support the new markings. - tweak: The Nail Polish markings have been moved from the Overlay category to the Left Hand and Right Hand categories. (cherry picked from commit 932f9e31eab9b2c11c4429b7c9c36effc327e733) * Automatic Changelog Update (#1299) (cherry picked from commit b05ab8e0d1e8aa043a60ca96843061f4778136e6) * ♂️ Add Male Arachne (#1301) # Description Adds the ability for Arachne to be male. Also in this I added chest/arm Arachnid markings for Arachne to use. I enabled footstep sounds for Arachne since it doesn't seem that they were intended to have silent footsteps. ## Media <img height=160px src="https://github.com/user-attachments/assets/04e3b066-e75c-4ee7-bfd6-762c2defcaf8"> <img height=160px src="https://github.com/user-attachments/assets/d4582c12-72d8-413f-92e6-145cb90c76c3"> ## Changelog :cl: Skubman - add: Arachne can now be Male instead of only being Female. They can now also wear Facial Hair. - add: Arachne can use Arachnid chest and arm markings. - fix: Arachne will now have footstep sounds instead of being quiet when moving. (cherry picked from commit 1bab6b8844c679897b3a695b363620589292d783) * Automatic Changelog Update (#1301) (cherry picked from commit 5476ee090bd735d7791b4ae7f1e8aeea674cd55a) * Add Localization for Senior Physician and Senior Engineer (#1302)  # Description  Adds localization for the Senior Engineer and Senior Physician roles that were recently enabled. --- # TODO  n/a ---  <details><summary><h1>Media</h1></summary> <p> ![Snímka obrazovky 2024-12-01 164702](https://github.com/user-attachments/assets/ca69e08d-5adb-4e71-aeda-5969d595e429) ![Snímka obrazovky 2024-12-01 165626](https://github.com/user-attachments/assets/18289899-2314-4d21-9b09-9e3e3415a6e0) </p> </details> --- # Changelog  :cl: zelezniciar - fix: Fixed Senior Engineer and Physician names not appearing correctly (cherry picked from commit 4bf762411e866952c0257ce7d255b2610d7a3a21) * Automatic Changelog Update (#1302) (cherry picked from commit 9169818f60ef0cf156bb1b095d66e5e9d0b4575b) * Make Cultist Constructs Speak Eldritch (#1303) # Description Fixes cultist constructs only speaking Universal and not being able to understand anyone else due to a missing `LanguageKnowledgeComponent`. ## Changelog :cl: Skubman - tweak: Cultist constructs and soul shards now speak Tau-Ceti Basic and Eldritch. Co-authored-by: sleepyyapril <[email protected]> (cherry picked from commit 8573914e8b6183197abc250d3e8f3c186194b0a6) * Automatic Changelog Update (#1303) (cherry picked from commit 114ecde8384ae3d98350aa80d38b96766dc49cfa) * Fix Lobotomy (#1306) # Description Fixes several bugs in the lobotomy procedure. The lobotomy effect is now stored in the brain instead of the body, so transferring a lobotomized brain will still give the lobotomy effects, and a brain transplant to a body where a lobotomy occurred no longer applies the lobotomy effects. The "Mend brain tissue" procedure to reverse a lobotomy has been unlocked after a bug prevented it from showing in the surgery UI. Lobotomies now add the `ClumsyComponent`, which makes the lobotomized target as clumsy as clowns. ## Technical Details This deletes [SurgeryComponentConditionComponent.cs](https://github.com/Simple-Station/Einstein-Engines/compare/master...angelofallars:Einstein-Engines:fix-lobotomy?expand=1#diff-3786e2be1879fd877a8b501352bbd92baa3a17aecfa4a62827ad41497deb0fd7) which was only used for the lobotomy procedures (incorrectly, it was checking for `OhioAccentComponent` in the body part) in favor of [SurgeryPartComponentConditionComponent.cs](https://github.com/Simple-Station/Einstein-Engines/compare/master...angelofallars:Einstein-Engines:fix-lobotomy?expand=1#diff-7e180742b3a6f00b9f867d3ee4e8891dd00587dc4a2da8ad5e199180a387d18d) and [SurgeryBodyComponentConditionComponent.cs](https://github.com/Simple-Station/Einstein-Engines/compare/master...angelofallars:Einstein-Engines:fix-lobotomy?expand=1#diff-249e5a937ba929ffc76f85e8a43f17918afc9ba866e81f4ea4eba2c90fd0c408). These two components are currently unused as the lobotomy procedures use a new condition component checking for the brain's `OrganComponent.OnAdd` field, but they provide a way to check for components on the body part and on the body, respectively. ## Media **Lobotomy** ![image](https://github.com/user-attachments/assets/4deb80a8-30d1-4a01-9caa-bc288a88ba95) **Mend brain tissue** ![image](https://github.com/user-attachments/assets/44403092-cac1-4d12-bd25-ebb7f3f1bc53) **Remove organ step picture** ![image](https://github.com/user-attachments/assets/85d6960a-1f54-4525-ad53-84b039c91fda) ## Changelog  :cl: Skubman - add: The lobotomy procedure makes the target clumsy like the clown. This makes them bonk when climbing tables and makes guns they're shooting blow up on their face. - tweak: The lobotomy step now requires a scalpel instead of a drill. - fix: Enabled the "Mend brain tissue" surgical procedure on a lobotomized target. - fix: The lobotomized effect is now stored in the brain instead of the body. The same brain stays lobotomized throughout brain transplants, and transferring a normal brain to a body where a lobotomy occurred no longer applies the lobotomized effect. - fix: The lobotomy procedure now shows the proper popup during the lobotomization step. - fix: Removed the ability to perform lobotomies on bodies without a brain. - fix: The "Remove organ" surgery step on the UI now properly shows the retractor sprite instead of the hemostat. --------- Co-authored-by: sleepyyapril <[email protected]> (cherry picked from commit 1895f3addc871e3ad18845c22c61f422f9807107) * Automatic Changelog Update (#1306) (cherry picked from commit 71c641283a13fc79c68f8ad23fa1397052b7e74b) * You Can Now Drag People Into Deep Friers (#1279)  # Description  You can now drag entities like people into deep fryers. Yes, this will cook them. Yes, you can cannibalize your own dead crew. --- # TODO  - [ ] Add a doafter - [ ] Add a popup warning everyone of what you've done ---  <details><summary><h1>Media</h1></summary> <p> obs is broken part 295 </p> </details> --- # Changelog  :cl: - add: You can now shove people into deep fryers by drag-dropping them onto it. --------- Signed-off-by: Eris <[email protected]> Co-authored-by: VMSolidus <[email protected]> Co-authored-by: sleepyyapril <[email protected]> (cherry picked from commit 82b2b28f3ee0f534b7f32fe54a70ba58d9ebbe1c) * Automatic Changelog Update (#1279) (cherry picked from commit cbc76ef649396a827a6c3b38b83c4a20f1affc7b) * Revert "Emp Flashlight (#5)" This reverts commit 932f1f6c * Emp Flashlight (#5) (#1189) # Description Ports https://github.com/WWhiteDreamProject/wwdpublic/pull/5 # Changelog :cl: - add: Added the EMP Flashlight to Syndicate Uplinks. --------- Co-authored-by: Ivan <[email protected]> (cherry picked from commit 7c0c16e3f2c07bad045c09e13a95855c356024ac) * Automatic Changelog Update (#1189) (cherry picked from commit 7beea8901ceea287918f35bd33f8d9445582427a) * Add Europa Map to Rotation (#1152)  # Description  This PR adds an old map to rotation called "Europa", originally a planetary map, but due to several problems it was not able to be played, I updated a good part of the map adding things necessary to be able to be played in the EE code, using the same idea To make the Glacier map a "planet", I created a parallax using the desert texture for the map and set the atmosphere on the outer side to a temperature of 356.2 K (83 C) with a high presence of CO2 --- # TODO  - [x] Rework eng - [x] add Super Matter engine - [x] better layout - [x] Rework Epi - [x] Better layout - [x] missing content - [x] Minor fixes on the map - [x] test the map - [x] add image ---  <details><summary><h1>Media</h1></summary> <p> ![Europa-0](https://github.com/user-attachments/assets/12839795-60cd-44a2-adab-00d4f68b7ce3) </p> </details> --- # Changelog  :cl: - add: added a new map called "Europa" to rotation --------- Co-authored-by: VMSolidus <[email protected]> (cherry picked from commit 831a7b3092aaab0ef130072a8dfde5354d7809df) * Automatic Changelog Update (#1152) (cherry picked from commit b1c3703cdec223ba10aa8e46d28c88694f97450c) * Update medicine.yml (#1210) Merges the med doc by floof. At least one original change by XavierSomething (will update when other PRs are found) https://github.com/Fansana/floofstation1/pull/222 --------- Signed-off-by: VMSolidus <[email protected]> Co-authored-by: VMSolidus <[email protected]> Co-authored-by: FoxxoTrystan <[email protected]> (cherry picked from commit c22325983ecd0a90b8a042585d20568030d69aaf) * Atmospheric Alerts Computer Upgrades (#1313)  # Description  This PR upgrades the capabilities of the Atmospheric Alerts Computer by displaying colored zones on the station map corresponding to air alarm status. Additionally, it makes the Atmospheric Alerts Computer board obtainable in a Circuit Imprinter once Epi has researched "Atmospheric Technologies". This is a port of [Wizden #31910](https://github.com/space-wizards/space-station-14/pull/31910) by @chromiumboy --- # TODO  n/a ---  <details><summary><h1>Media</h1></summary> <p> ![Snímka obrazovky 2024-12-04 131829](https://github.com/user-attachments/assets/598fcfb4-2983-431e-8192-248880cba1b2) ![Snímka obrazovky 2024-12-04 134819](https://github.com/user-attachments/assets/2eb39995-f9fe-4f11-a01e-a457d3487231) </p> </details> --- # Changelog  :cl: zelezniciar - tweak: Atmospheric Alerts Computer now displays colored zones corresponding to air alarm status on the station map - fix: Atmospheric Alerts Computer board is printable in a circuit imprinter --------- Co-authored-by: chromiumboy <[email protected]> (cherry picked from commit e2ee77db5c7dd20958fa246c893d44b767826868) * Automatic Changelog Update (#1313) (cherry picked from commit 6c9270d0cf4526bd632d9d975eaa98c9d6767513) * More Bug Fixes (#1311)  # Description  [Mice pickup fixed!](https://github.com/space-wizards/space-station-14/pull/33602) [Mobs can no longer spill jugs](https://github.com/space-wizards/space-station-14/pull/33602) Rest in changelog. # Changelog :cl: - fix: You can pick up mobs again with left click. - fix: No more mob jug spill, including you revenants. - fix: Set the Gloves of the North Star to the proper attack speed. - fix: Medibots will no longer try to heal borgs. --------- Co-authored-by: MilenVolf <[email protected]> Co-authored-by: slarticodefast <[email protected]> (cherry picked from commit 978173efd5f6e7a7cd9f5a52234291e29ed862dc) * Automatic Changelog Update (#1311) (cherry picked from commit 1b156683af55eb6e4fef1f1be46f69ff6b258856) * ChemMaster Sorting (#1310)  # Description  [Ports this Frontier PR.](https://github.com/new-frontiers-14/frontier-station-14/pull/2498#issuecomment-2513268858) --- # Changelog  :cl: DmitriTheDemon - tweak: The ChemMaster is now sorted. --------- Signed-off-by: Remuchi <[email protected]> Co-authored-by: Dmitri <[email protected]> Co-authored-by: Whatstone <[email protected]> Co-authored-by: Remuchi <[email protected]> (cherry picked from commit 32e17a621bc78ba70b330036bb5ba2fd371286e0) * Automatic Changelog Update (#1310) (cherry picked from commit 01a13e3c9f0beaa595b03acd0e50af4cb6de40bf) * Port Shipyards (#1314) # Description I needed this extremely badly. # TODO - [x] Move all of this out of the DeltaV folders. # Changelog :cl: - add: Added Shipyards. --------- Signed-off-by: deltanedas <[email protected]> Co-authored-by: deltanedas <[email protected]> Co-authored-by: Null <[email protected]> Co-authored-by: Milon <[email protected]> Co-authored-by: Plykiya <[email protected]> Co-authored-by: plykiya <[email protected]> Co-authored-by: Ed <[email protected]> Co-authored-by: Radezolid <[email protected]> Co-authored-by: sleepyyapril <[email protected]> (cherry picked from commit d69b516ce2fe3f8da65db745f1157ae259f60e96) * Automatic Changelog Update (#1314) (cherry picked from commit 36cd6ca4706196e9c3097efcff3443bc30896c19) * Port UserActivateInWorldEvent and BypassInteractionChecksComponent (#1295)  # Description  See https://github.com/space-wizards/space-station-14/pull/28393 and https://github.com/space-wizards/space-station-14/pull/28236 for breaking changes and extra information Works perfectly on a downstream of EE. Changes in third commit have been tested with doors. --- # Changelog  nuh uh --------- Signed-off-by: sleepyyapril <[email protected]> Co-authored-by: Nemanja <[email protected]> Co-authored-by: DrSmugleaf <[email protected]> (cherry picked from commit 1016a0809c6636147647347e9736846cf0536e68) * Inverts the Check for Material Whitelist in CanChangeMaterialAmount (#1320) This change was actually suggested by April, I'm not the author. It fixes Pacman generators and god knows what else. Prior to the change you could insert steel in it, or just the wrong kind of fuel. Since you could only load the wrong kind of fuel the generators were not working at all.  # Description  Description. --- # TODO  ---  <details><summary><h1>Media</h1></summary> <p> Ejecting steel from a pacman gen ![image](https://github.com/user-attachments/assets/28771e24-4c46-48f1-94dc-c3db03b059a6) Them working after the fix. ![image](https://github.com/user-attachments/assets/cce907b2-097c-4d4a-837a-606e3c19b5b9) </p> </details> --- # Changelog  Co-authored-by: sleepyyapril <[email protected]> (cherry picked from commit 54d15c03617c5c33b3804ad233e6dc6d7444080d) * Build Your Own TEG! (#1316)  # Description  This PR adds the option of constructing a Thermoelectric Generator (TEG) from scratch, by adding flatpacks for the TEG Center and TEG Circulator, as well as a crate that can be ordered from logistics that contains the flatpacks. The aim is to give engineering crews the ability to add a TEG to stations that might lack one, as a "fun" engineering project that can be pursued on shift. This capability already exists for the Singularity Engine and Tesla Engines. The cost of the TEG Construction Kit is set at 8000 spesos, but this can be changed for balance reasons. Note: Kit may contain small parts not suitable for children under 3 years old. Some assembly required. --- # TODO  n/a ---  <details><summary><h1>Media</h1></summary> <p> ![Snímka obrazovky 2024-12-05 202816](https://github.com/user-attachments/assets/6c6c9f0d-89b2-4558-aa13-ca1c5bbca58d) ![Snímka obrazovky 2024-12-05 203211](https://github.com/user-attachments/assets/69227645-1382-45f0-848b-96b45e6da92f) </p> </details> --- # Changelog  :cl: zelezniciar - add: TEG components now be ordered from Logistics and assembled on station. (cherry picked from commit f1b8f960f7aa9f29e638cb794d6f2639b63225e8) * Automatic Changelog Update (#1316) (cherry picked from commit 3d2cdd73bfd52e89ae9c11d60cba5c801bf68c8e) * Several Small Map Fixes to Europa (#1319)  # Description  Description. --- # TODO  - [x] Lack of radiator underneath the SM crystal - [x] Wrong kind of vent and lack of connectors at the gas chambers - [x] Inverts one of the connector pumps in the SM's closed loop - [x] Adds a decal to this inverted pump which was missing - [x] Lack of Mv wire under a APC on a hallway at the north side - [x] Lack of Hv wire connection to a substation in the bridge which powers the bridge and the bar area - [x] Switches a medical records computer in medbay to a crew monitoring one - [x] Adds an autolathe to cargo - [x] Protrudes the cargo dock which was too tight to fit the shuttle ---  <details><summary><h1>Media</h1></summary> <p> Previous docking issue: ![image](https://github.com/user-attachments/assets/30ce4994-8294-40ff-8919-47fa28224dea) Change in cargo dock design ![2024-12-06_09-25](https://github.com/user-attachments/assets/f968d153-28fe-4007-9b47-d8e36522cfc2) Crew monitoring replacing medical records ![image](https://github.com/user-attachments/assets/719df986-fe72-4e6b-9263-9aa18b8c2237) Autolathe added to cargo ![2024-12-06_09-19](https://github.com/user-attachments/assets/4d527179-2242-4d05-a229-d0fcc0aed360) <h2>Atmos/SM/Wiring changes:</h2> Added missing Hv connection to a substation in the bridge ![image](https://github.com/user-attachments/assets/0449cf0a-83f4-4ae5-a7cf-49e2f55a5197) Added one missing Mv wire to this APC ![image](https://github.com/user-attachments/assets/79e939ed-1082-46e2-b572-2f5a31affa7c) Changed regular vents into passive vents, added connector slot and attached canisters to it ![image](https://github.com/user-attachments/assets/e8a9c686-f97e-46c3-a9e9-6b1da6776ba3) Radiator added to SM ![2024-12-06_08-51](https://github.com/user-attachments/assets/e30549dc-1ea3-40d3-b12e-168497e9f19b) These two pumps in the SM which were redundant, also one of them were missing decal to the same tile ![image](https://github.com/user-attachments/assets/66e4dcdf-6b8c-4778-910e-288dcc8168ef) Showing the changed pump after being inverted ![image](https://github.com/user-attachments/assets/ea571ad3-c6aa-4424-ae74-11319ac0f551) --- Recenter changes: There were three APC in cargo and north of in which one was connected with cargo's APC for no apparent reason and the other was missing wires entirely. I've put the one missing wires to work in the Lv wiring around it and cut the Lv wires were it seemed appropriate to prevent connecting multiple APCs with Lv for no reason. ![image](https://github.com/user-attachments/assets/b7a3f1e4-5d1e-48a8-8d54-31efecb9c691) ![image](https://github.com/user-attachments/assets/669d6827-510c-475a-9039-878fbc221faf) Excess lamps not included in the change ![image](https://github.com/user-attachments/assets/6f1bb7fc-3b5c-4f76-96da-1e362a0c3921) ![image](https://github.com/user-attachments/assets/3e25bd5b-02ff-438a-89da-91310ca3e473) ![image](https://github.com/user-attachments/assets/f2a7990d-f09f-4c44-b68b-830305743c8f) ![image](https://github.com/user-attachments/assets/953948fe-6b3b-48fb-a18f-4a1b2541ccaf) </p> </details> --- # Changelog  :cl: - fix: Several small fixes to Europa map, namely to cargo dock, SM and atmos piping and wires, adds autolathe to cargo and crew monitor to med (cherry picked from commit 50eb2173c25073d8bed2aaf3dc5a8e4db44a261d) * Automatic Changelog Update (#1319) (cherry picked from commit f4152a5597156c58731308e0ef0869862035dce2) * Fix Rules (#1321) # Description The latest update killed our generic rules, and made them not work anymore. This PR brings them back. ![image](https://github.com/user-attachments/assets/2c7c7a64-3f06-4635-afe4-e6e941a374b7) # Changelog :cl: - fix: Server rules work again. (cherry picked from commit 06a8cee785e74db4c820d072aa3fdafcf2e4c403) * Automatic Changelog Update (#1321) (cherry picked from commit 9989c4d3d2214b22f90045c15e32b04f93adb3b0) * fix * 237.2.0 * fix * 237.2.0 * Uplink: Remove Deception Category (#1309)  # Description  …

# Description  Link to every PR I cherry-picked: 1. new-frontiers-14/frontier-station-14#2283 2. space-wizards/space-station-14#29219 3. space-wizards/space-station-14#30075 4. space-wizards/space-station-14#28639 5. space-wizards/space-station-14#32527 6. space-wizards/space-station-14#28030 7. space-wizards/space-station-14#28178 The main purpose of this PR is the first cherry-picked PR. It adds the ability for admins to reply to ahelps via discord using an HTTP POST request. See all relevant details in the initial PR by Myzumi. --------- Co-authored-by: Myzumi <[email protected]> Co-authored-by: Whatstone <[email protected]> Co-authored-by: Whatstone <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> Co-authored-by: to4no_fix <[email protected]> Co-authored-by: Repo <[email protected]> Co-authored-by: Chief-Engineer <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Leon Friedrich <[email protected]> Co-authored-by: ShadowCommander <[email protected]>

Adding the admin prefix to the ahelp

e4e9670

chavonadelal requested review from DrSmugleaf and Chief-Engineer as code owners July 15, 2024 21:03

github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Jul 15, 2024

Chief-Engineer suggested changes Jul 16, 2024

View reviewed changes

Updating the admin prefix

2e4e4e7

chavonadelal requested a review from Chief-Engineer July 16, 2024 16:53

github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Jul 16, 2024

Chief-Engineer suggested changes Jul 17, 2024

View reviewed changes

Content.Server/Administration/Systems/BwoinkSystem.cs Outdated Show resolved Hide resolved

Content.Server/Administration/Systems/BwoinkSystem.cs Outdated Show resolved Hide resolved

Content.Shared/CCVar/CCVars.cs Show resolved Hide resolved

chavonadelal added 2 commits July 17, 2024 19:44

The second update of the admin prefix

fd71b17

Configuration correction

77c15ad

chavonadelal requested a review from Chief-Engineer July 17, 2024 17:09

Chief-Engineer approved these changes Jul 18, 2024

View reviewed changes

TheShuEd approved these changes Jul 30, 2024

View reviewed changes

Chief-Engineer merged commit 64273cb into space-wizards:master Aug 3, 2024
12 checks passed

sleepyyapril mentioned this pull request Nov 28, 2024

Admin Tooling Cherry Picks Simple-Station/Einstein-Engines#1290

Merged

Displaying the administrator's position in ahelp and webhook #30075

Displaying the administrator's position in ahelp and webhook #30075

Conversation

chavonadelal commented Jul 15, 2024 • edited by Chief-Engineer Loading

About the PR

Why / Balance

Technical details

Media

Breaking changes

deltanedas commented Jul 15, 2024

GrigoriyGalintano commented Jul 15, 2024

IProduceWidgets commented Jul 15, 2024 • edited Loading

chavonadelal commented Jul 15, 2024

chavonadelal commented Jul 15, 2024

NotSoDana commented Jul 15, 2024

chavonadelal commented Jul 15, 2024

chavonadelal commented Jul 15, 2024

Mirino97 commented Jul 15, 2024 • edited Loading

NotSoDana commented Jul 15, 2024

chavonadelal commented Jul 15, 2024 • edited Loading

chavonadelal commented Jul 15, 2024

IProduceWidgets commented Jul 16, 2024

IProduceWidgets commented Jul 16, 2024

chavonadelal commented Jul 16, 2024

Mirino97 commented Jul 16, 2024

Mirino97 commented Jul 16, 2024

chavonadelal commented Jul 16, 2024

metalgearsloth commented Jul 16, 2024

Mirino97 commented Jul 16, 2024

chavonadelal commented Jul 16, 2024

sleepyyapril commented Jul 16, 2024

LankLTE commented Jul 16, 2024

chavonadelal commented Jul 16, 2024

chavonadelal commented Jul 16, 2024 • edited Loading

Chief-Engineer left a comment

Choose a reason for hiding this comment

Chief-Engineer commented Jul 16, 2024

KingFroozy commented Jul 16, 2024

chavonadelal commented Jul 16, 2024

Chief-Engineer commented Jul 17, 2024

chavonadelal commented Jul 19, 2024

Chief-Engineer commented Jul 20, 2024

chavonadelal commented Jul 22, 2024

Chief-Engineer commented Jul 23, 2024

chavonadelal commented Jul 23, 2024

Chief-Engineer commented Jul 24, 2024

TheShuEd commented Jul 30, 2024

Chief-Engineer commented Aug 3, 2024

chavonadelal commented Jul 15, 2024 •

edited by Chief-Engineer

Loading

IProduceWidgets commented Jul 15, 2024 •

edited

Loading

Mirino97 commented Jul 15, 2024 •

edited

Loading

chavonadelal commented Jul 15, 2024 •

edited

Loading

chavonadelal commented Jul 16, 2024 •

edited

Loading