Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the powered examine text fully client predicted #30441

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

Mervill
Copy link
Member

@Mervill Mervill commented Jul 29, 2024

About the PR

The "it appears to be (un)powered." examine text is now client predicted. Meaning all powered objects (a huge section of common objects) should now have much snappier examine text.

Why / Balance

Technical details

Work done by ShadowCommander in #28206 set the stage for this.

Media

B4
power-examine-fail

After
power-examine-good

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

@Mervill Mervill requested a review from Plykiya July 29, 2024 07:11
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Jul 29, 2024
@Plykiya Plykiya enabled auto-merge (squash) July 29, 2024 07:28
@Plykiya Plykiya merged commit ec19f9f into space-wizards:master Jul 29, 2024
12 checks passed
@Mervill Mervill deleted the powered-examine-predicted branch July 29, 2024 07:30
themias pushed a commit to themias/space-station-14 that referenced this pull request Aug 9, 2024
…0441)

* Make the powered examine text fully client predicted

* switch to using the Entity<T> API for the examine event
Erisfiregamer1 pushed a commit to The-Arcadis-Team/arc-station-14 that referenced this pull request Jan 9, 2025
…0441)

* Make the powered examine text fully client predicted

* switch to using the Entity<T> API for the examine event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants