Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Station "Reach" changes #30552

Closed
wants to merge 4 commits into from
Closed

Station "Reach" changes #30552

wants to merge 4 commits into from

Conversation

SpaceLizardSky
Copy link
Contributor

@SpaceLizardSky SpaceLizardSky commented Aug 1, 2024 •
edited
Loading

About the PR

  • Botany now has a nutrimax and is slightly bigger.
  • The station now has an actual waste network

Why / Balance

  • You can't do botany without botany tools, so that's why i added a nutrimax
  • No waste system means everything dies after afew hours which is annoying.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
    Screenshot_1192
    bigger botany with a nutrimax included

Changelog

no cl because it's a mapping change

@SpaceLizardSky
reach changes
e96f2c0 
- make botany bigger
- add air alarms and a waste system, everything should be linked too.
@ss14-map-server
Copy link

ss14-map-server bot commented Aug 1, 2024 •
edited
Loading

This PR contains new or changed maps:

Reach

image

08/05/24 09:49

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Map Changes: Might require knowledge of mapping. labels Aug 1, 2024
@SpaceLizardSky
Copy link
Contributor Author

fixes #29613 i think

@lzk228
Copy link
Contributor

lzk228 commented Aug 1, 2024

would be good to map a fax

@Tayrtahn
Copy link
Member

Tayrtahn commented Aug 1, 2024

Test failure is real
Screenshot_20240801-155110.png

@SpaceLizardSky
Copy link
Contributor Author

Test failure is real Screenshot_20240801-155110.png

Screenshot_1223

i just checked the map file and it didnt have anything with uid 0. any idea what could be causing this?

@SlamBamActionman
Copy link
Member

Test failure is real Screenshot_20240801-155110.png

Screenshot_1223

i just checked the map file and it didnt have anything with uid 0. any idea what could be causing this?

I think this can also happen if an item is trying to reference a uid that has been deleted. An example of this could be linking a conveyor belt to a lever and then removing the conveyor belt. Sometimes the lever fails to remove the link on its end and it stays there invisibly in the map file, causing the error.

@Emisse
Copy link
Contributor

Emisse commented Aug 4, 2024

you need to remove invalids from map file

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Aug 6, 2024
@SpaceLizardSky
Copy link
Contributor Author

aaa merge conflict.. i'll deal with it

@SpaceLizardSky
Merge branch 'master' of https://github.com/space-wizards/space-stati…
617f333 
…on-14 into make-reach-better

# Conflicts:
#	Resources/Maps/reach.yml
@SpaceLizardSky
Copy link
Contributor Author

SpaceLizardSky commented Aug 6, 2024 •
edited
Loading

somehow messed up stuff with robusttoolbox.. any idea how to fix that?

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Aug 6, 2024
@SpaceLizardSky
Copy link
Contributor Author

trying with a second PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Changes: Map Changes: Might require knowledge of mapping. Changes: No C# Changes: Requires no C# knowledge to review or fix this item.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SpaceLizardSky @lzk228 @Tayrtahn @SlamBamActionman @Emisse