Add failure logging to DiscordWebhook.cs #30835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new function that logs errors with discord webhook's http requests. Create, Delete, and Edit functions were modified slightly to call the log function but return the same information as before. The log function logs the error code, caller method using a simple constant (could be better), and attempts to log headers mentioned in issue space-wizards#30248.
metalgearsloth
previously requested changes
Aug 14, 2024
Comment on lines
127
to
136
|
|
||
| if (response.Headers.TryGetValues("Retry-After", out var retryAfter)) | ||
| _sawmill.Error($"Retry-After: {string.Join(", ", retryAfter)}"); | ||
|
|
||
| if (response.Headers.TryGetValues("X-RateLimit-Global", out var globalRateLimit)) | ||
| _sawmill.Error($"X-RateLimit-Global: {string.Join(", ", globalRateLimit)}"); | ||
|
|
||
| if (response.Headers.TryGetValues("X-RateLimit-Scope", out var rateLimitScope)) | ||
| _sawmill.Error($"X-RateLimit-Scope: {string.Join(", ", rateLimitScope)}"); | ||
| } |
There was a problem hiding this comment.
Not sure on logging these, I think the default one is fine.
metalgearsloth
added
the
S: Awaiting Changes
Co-authored-by: metalgearsloth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Add a new function that logs errors with discord webhook's http requests.
Why / Balance
Added as a response to issue #30248. Also created for a Open Source Software course, any review is appreciated but this does not need to be accepted.
Technical details
Create, Delete, and Edit functions were modified slightly to call the log function but return the same information as before.
The log function logs the error code, caller method using a simple constant (could be better), and attempts to log headers mentioned in issue #30248.
Media
Nothing of note.
Requirements
Breaking changes
No obvious breaking changes. Testing was not as extensive as I would have liked.
Changelog
🆑