Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red crowbars no longer fit in pockets #30939

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

UbaserB
Copy link
Member

@UbaserB UbaserB commented Aug 12, 2024

About the PR

It's not good for balance when one of the variants is stronger than the rest. It was mistakenly changed in #30828 and I bet Emisse totally skimmed over it, which is how it got merged.

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑 Ubaser

  • fix: Red crowbars no longer fit in pockets.

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Aug 12, 2024
Copy link
Contributor

@lzk228 lzk228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then you also should remove "A pocket crowbar" part from its description

@Pumkin69
Copy link
Contributor

i mean i agree but i also think crowbars should fit in pockets all together

@UbaserB
Copy link
Member Author

UbaserB commented Aug 12, 2024

then you also should remove "A pocket crowbar" part from its description

yea true

@thebadman4662
Copy link

If its smaller than 2x2 it should fit in pocket to be consistent with other items.

@UbaserB
Copy link
Member Author

UbaserB commented Aug 12, 2024

test fail doesnt look related

@keronshb
Copy link
Contributor

I believe Pocket Crowbars are fine.

@ninruB
Copy link

ninruB commented Aug 12, 2024

I'm not even sure why we're removing pocket crowbars as a whole considering that in the original PR discussion Emisse, among others, agreed that pocket crowbars are fine.

@UbaserB UbaserB mentioned this pull request Aug 13, 2024
2 tasks
@UbaserB
Copy link
Member Author

UbaserB commented Aug 13, 2024

I'm not even sure why we're removing pocket crowbars as a whole considering that in the original PR discussion Emisse, among others, agreed that pocket crowbars are fine.

I'm going to be checking in with the maintainer team again to see what's best, especially considering the new PR.

@slarticodefast slarticodefast merged commit 9d62570 into space-wizards:master Aug 17, 2024
11 checks passed
@UbaserB UbaserB deleted the standardise-red-crowbar branch August 17, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants