Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loadout names #31303

Merged
merged 15 commits into from
Feb 11, 2025
Merged

Add loadout names #31303

merged 15 commits into from
Feb 11, 2025

Conversation

metalgearsloth
Copy link
Contributor

From AI branch nothing using it atm but open to suggestions. DB migrations so requires contrib ping (the pgsql one may be breaking).

@metalgearsloth
Add loadout names
401fa49 
Did it for AI, breaking change for pgsql + migrations in general. Nothing atm uses it.
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted Changes: UI Changes: Might require knowledge of UI design or code. labels Aug 22, 2024
@ilyamikcoder
Copy link
Contributor

if i understand correctly that this is the pr about allowing to set separate character names in loadouts, then i suggest that clowns, mimes and borgs get this functionality

@DogZeroX
Copy link
Contributor

That's the whole point

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Aug 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Everturning
Copy link

add this to musicians maybe?
they could have like a stage name, like slim shady or something like that

@AverageNotDoingAnythingEnjoyer
Copy link
Contributor

@metalgearsloth , how's the progress?

@LaOubliette
Copy link

I fucking beg please

@lzk228 lzk228 mentioned this pull request Sep 17, 2024
Open
2 tasks
@lzk228 lzk228 mentioned this pull request Oct 1, 2024
Closed
PJB3005
PJB3005 reviewed Oct 2, 2024
View reviewed changes
Resources/Locale/en-US/preferences/loadouts.ftl Outdated
@@ -1,3 +1,7 @@
# Name
loadout-name-edit-label = Custom name
loadout-name-edit-tooltip = 32 characters max. If no name is specified a random one may be chosen for you.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unhardcode

PJB3005
PJB3005 reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@PJB3005 PJB3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix conflicts and the one nit I guess

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Oct 2, 2024
PJB3005
PJB3005 requested changes Oct 2, 2024
View reviewed changes
Copy link
Member

@PJB3005 PJB3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff seems to be missing changes for the DB model, I'm assuming this is in error due to the DB migrations being present

@Cojoke-dot Cojoke-dot mentioned this pull request Oct 12, 2024
Closed
@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@eoineoineoin eoineoineoin added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D2: Medium Difficulty: A good amount of codebase knowledge required. A: Character/Species Area: Player characters and species features and content. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 20, 2024
@slarticodefast slarticodefast removed the P3: Standard Priority: Default priority for repository items. label Nov 26, 2024
@slarticodefast slarticodefast added the P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. label Nov 26, 2024
Merged
2 tasks
@muburu muburu mentioned this pull request Dec 8, 2024
Merged
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-99 lines. label Dec 24, 2024
@PJB3005 PJB3005 self-assigned this Dec 24, 2024
@PJB3005
Copy link
Member

PJB3005 commented Dec 24, 2024

Is this ready for review or can it be made a draft? I don't see the DB side anymore.

@github-actions github-actions bot added size/L Denotes a PR that changes 1000-4999 lines. and removed size/S Denotes a PR that changes 10-99 lines. labels Dec 26, 2024
PJB3005
PJB3005 reviewed Jan 31, 2025
View reviewed changes
Resources/Prototypes/Loadouts/role_loadouts.yml
Comment on lines +29 to +32
#- type: roleLoadout
# id: JobBorg
# nameDataset: roleloadout doesn't support both so need to update that first.
# canCustomizeName: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Borgs use dataset but AI is localized dataset so the choice was either update borgs to use it or make it compatible with both (which seemed skrunkly).

Copy link
Contributor

@lzk228 lzk228 Feb 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, doesn't localized dataset do the same thing as default dataset and in result they are both the same?

@PJB3005 PJB3005 merged commit 15b2893 into space-wizards:master Feb 11, 2025
12 checks passed
@lzk228 lzk228 mentioned this pull request Feb 14, 2025
Open
2 tasks
@VasilisThePikachu
Copy link
Member

In the future please fill out the pr template as i had to dig what this does in the maintainer meeting. Or at least provide some screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzk228 lzk228 lzk228 left review comments

@PJB3005 PJB3005 PJB3005 approved these changes

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

Assignees

@PJB3005 PJB3005

Labels
A: Character/Species Area: Player characters and species features and content. Changes: UI Changes: Might require knowledge of UI design or code. D2: Medium Difficulty: A good amount of codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted size/L Denotes a PR that changes 1000-4999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.