Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused IoC dependency references. #31704

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Remove unused IoC dependency references. #31704

merged 1 commit into from
Sep 1, 2024

Conversation

Mervill
Copy link
Member

@Mervill Mervill commented Sep 1, 2024 •
edited
Loading

About the PR

Aggressively culls unused [Dependency] definitions in content, since they cause CS0414 warnings. If you need the dependency then just re-add it with a usage. Simple as.

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted Changes: UI Changes: Might require knowledge of UI design or code. labels Sep 1, 2024
@Mervill Mervill mentioned this pull request Sep 1, 2024
Merged
@PJB3005 PJB3005 merged commit 3414abb into space-wizards:master Sep 1, 2024
17 checks passed
@Mervill Mervill deleted the remove-deps branch September 1, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalgearsloth metalgearsloth Awaiting requested review from metalgearsloth metalgearsloth is a code owner

@ficcialfaint ficcialfaint Awaiting requested review from ficcialfaint ficcialfaint is a code owner

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

@EmoGarbage404 EmoGarbage404 Awaiting requested review from EmoGarbage404

@Chief-Engineer Chief-Engineer Awaiting requested review from Chief-Engineer

Assignees
No one assigned
Labels
Changes: UI Changes: Might require knowledge of UI design or code. S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mervill @PJB3005