Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the rolling pin craftable #32285

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

august-sun
Copy link
Contributor

About the PR

Made the rolling pin craftable

Why / Balance

Given that it's a relatively simple object with specific uses and not super beneficial otherwise, it would be nice for chefs to create them easier!

Technical details

Edited relevant construction files and graphs.

Media

image

Requirements

Breaking changes

Changelog

🆑

  • tweak: Rolling pins are now craftable.

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Sep 18, 2024
@lzk228
Copy link
Contributor

lzk228 commented Sep 18, 2024

looks unneeded because you can use gas tanks as rolling pins
like, use rolling pin from chef in normal cooking and gas tanks in ghetto-cooking

@august-sun
Copy link
Contributor Author

looks unneeded because you can use gas tanks as rolling pins like, use rolling pin from chef in normal cooking and gas tanks in ghetto-cooking

rolling pins specifically count as a tool and can be added to the chef's belt, which makes it stand out from alternatives!

@lzk228
Copy link
Contributor

lzk228 commented Sep 18, 2024

looks unneeded because you can use gas tanks as rolling pins like, use rolling pin from chef in normal cooking and gas tanks in ghetto-cooking

rolling pins specifically count as a tool and can be added to the chef's belt, which makes it stand out from alternatives!

sounds like it should be like that??
choose normal way - get better performance
choose ghetto way - get worse performance

@slarticodefast slarticodefast added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Sep 18, 2024
@august-sun
Copy link
Contributor Author

looks unneeded because you can use gas tanks as rolling pins like, use rolling pin from chef in normal cooking and gas tanks in ghetto-cooking

rolling pins specifically count as a tool and can be added to the chef's belt, which makes it stand out from alternatives!

sounds like it should be like that?? choose normal way - get better performance choose ghetto way - get worse performance

Right, I agree. The only reason this lives in "improvised" is because there's not quite another contained space for this to live, other than maybe creating a specific section for it.

I figured it would possibly be okay because A. It's a simple object comparable to a baseball bat, realistically speaking and B. It provides such a specific value (a rolling object that fits into a chef tool belt) that there's little to no avenue for abuse.

@lzk228
Copy link
Contributor

lzk228 commented Sep 18, 2024

i really cannot understand your point

@beck-thompson
Copy link
Contributor

I don't see the issue with it being craftable though 🤷. It makes sense!

@august-sun
Copy link
Contributor Author

i really cannot understand your point

The gas tank, as you're suggesting, can't fit into the chef's tool belt, only pockets. The rolling pin does. So you don't NEED to use a rolling pin for cooking, sure, but it's convenient for storage!

@lzk228
Copy link
Contributor

lzk228 commented Sep 18, 2024

to begin with, where did you get chef's belt from if you don't have access to chef vendor where the rolling pin is stored?

@Cojoke-dot
Copy link
Contributor

Cojoke-dot commented Sep 18, 2024

I don't see the issue with it being craftable though 🤷. It makes sense!

Crafting menu bloat... there are so many things in the crafting menu that are never made because they are either pointless or hidden under 1000 other items. When was the last time you saw someone make a silver wall or... almost anything past the normal few items that people see as useful?

Why do we need to craft these? Do chefs have issues getting them? If they do why not just add more to the vend instead of forcing chefs to make one? Why not just talk to hop/chef for access/the item if your not a chef?

@august-sun
Copy link
Contributor Author

I don't see the issue with it being craftable though 🤷. It makes sense!

Crafting menu bloat... there are so many things in the crafting menu that are never made because they are either pointless or hidden under 1000 other items.

Why do we need to craft these? Do chefs have issues getting them? If they do why not just add more to the vend instead of forcing chefs to make one? Why not just talk to hop/chef for access/the item if your not a chef?

Totally get this; at a minimum, it'd be okay at least to make it more available as a whole, so instead of in-hand craftable, it could be made at an autolathe (since it's not there, despite making sense to be there since a lot of dinnerware and other tools are). This also accounts for a few factors, namely:

  • The vending machine may be depowered, rendering it inaccessible
  • It may be out of stock, making it inconvenient/impossible to find another without specifically finding another relevant vending machine (I wasn't even able to find cooking related crates that included one).

I could see limiting a more complicated or desired item to "vending machine only", but for something as relatively innocuous, I didn't think it'd be a major issue.

@beck-thompson
Copy link
Contributor

Crafting menu bloat... there are so many things in the crafting menu that are never made because they are either pointless or hidden under 1000 other items.

Honestly this sounds more like a crafting UI issue (And I do agree its an issue)!

@lzk228
Copy link
Contributor

lzk228 commented Sep 18, 2024

it'd be okay at least to make it more available as a whole

ehh... you can get it from dinnerware
if you CANNOT you should use GHETTO methods - GAS TANKS
like with other ghetto methods, you don't have access to something? use something more available, but it would work a little worse

it could be made at an autolathe

a lot better

The vending machine may be depowered, rendering it inaccessible

i may be a dick but sorry, should we put ointments and bruisepacks in craft menu because nanomed may be unpowered?

It may be out of stock

oh, ointments also may be out of stock!

@Cojoke-dot
Copy link
Contributor

Cojoke-dot commented Sep 18, 2024

it'd be okay at least to make it more available as a whole

ehh... you can get it from dinnerware if you CANNOT you should use GHETTO methods - GAS TANKS like with other ghetto methods, you don't have access to something? use something more available, but it would work a little worse

it could be made at an autolathe

a lot better

The vending machine may be depowered, rendering it inaccessible

i may be a dick but sorry, should we put ointments and bruisepacks in craft menu because nanomed may be unpowered?

It may be out of stock

oh, ointments also may be out of stock!

guah, whoa, calm down

Honestly this sounds more like a crafting UI issue (And I do agree its an issue)!

True, maybe there should be dropdowns for categories like walls and stuff so you can look through stuff without seeing all the junk that nobody cares about.

I could see limiting a more complicated or desired item to "vending machine only", but for something as relatively innocuous, I didn't think it'd be a major issue.

lol, it's not a major issue, I just like consistency between stuff like this. You can't really craft any other dinnerwear equipment and it really is a super minor item. Sure cargo can be a pain but they do exist for a reason, not everything needs to be made by hand.

@august-sun
Copy link
Contributor Author

august-sun commented Sep 18, 2024

it'd be okay at least to make it more available as a whole

ehh... you can get it from dinnerware if you CANNOT you should use GHETTO methods - GAS TANKS like with other ghetto methods, you don't have access to something? use something more available, but it would work a little worse

it could be made at an autolathe

a lot better

The vending machine may be depowered, rendering it inaccessible

i may be a dick but sorry, should we put ointments and bruisepacks in craft menu because nanomed may be unpowered?

It may be out of stock

oh, ointments also may be out of stock!

guah, whoa, calm down

I could see limiting a more complicated or desired item to "vending machine only", but for something as relatively innocuous, I didn't think it'd be a major issue.

lol, it's not a major issue, I just like consistency between stuff like this. You can't really craft any other dinner equipment and it really is a super minor item. Sure cargo can be a pain but they do exist for a reason, not everything needs to be made by hand.

Yeah that was both a major false equivalence between how important topical medicine is and... a rolling pin and, yeah, kind of rude!

Regarding this, then it might be better to have it moved over to being made at the lathe. Appreciate the feedback! I'll wait on maintainer feedback for a final say.

@Killerqu00
Copy link
Contributor

Mechanics cannot be location specific or require items that cannot be obtained after roundstart.

there is also zero way to know that gas tank can be used as a rolling pin unless you look into the code

@Ertanic
Copy link
Contributor

Ertanic commented Sep 24, 2024

Maybe you should add as a crafting step a knife or something? It sounds logical that crafting a round rolling pin out of planks would use something sharp to shape it, than just... sticking the planks on a rod.

@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Sep 25, 2024
@slarticodefast
Copy link
Member

Shouldn't be a problem to have this craftable. Maybe at some point we need to reorganize the crafting menu though.
Thank you for your contribution.

@slarticodefast slarticodefast merged commit b2dad9f into space-wizards:master Sep 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Needs Review Status: Requires additional reviews before being fully accepted S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants