Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flora.yml cleanup #33803

Closed
wants to merge 1 commit into from
Closed

flora.yml cleanup #33803

wants to merge 1 commit into from

Conversation

Tunguso4ka
Copy link
Contributor

About the PR

Cleaned up trees in flora.yml:

  • Moved names from tree variants to parent entities.
  • Moved parent entities closer to variant entities.

Requirements

@github-actions github-actions bot added size/L Denotes a PR that changes 1000-4999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Dec 9, 2024
@beck-thompson beck-thompson added P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 9, 2024
@beck-thompson
Copy link
Contributor

Negative diff ymal beast 💪

slarticodefast
slarticodefast approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for the cleanup!

@slarticodefast slarticodefast self-assigned this Dec 10, 2024
@slarticodefast slarticodefast added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Dec 10, 2024
@TheShuEd
Copy link
Member

wait wtf #33839
we almost simultaneously decided to clean out that file

@Tunguso4ka
Copy link
Contributor Author

wait wtf #33839 we almost simultaneously decided to clean out that file

great minds think alike.

@slarticodefast
Copy link
Member

I merged #33839 instead because that PR also makes trees use random sprites instead of having lots of hardcoded prototypes, so this PR is now redundant. Thank you for contributing anyways!

@Tunguso4ka Tunguso4ka deleted the 20241209_clearup_flora_file branch December 16, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarticodefast slarticodefast slarticodefast approved these changes

Assignees

@slarticodefast slarticodefast

Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/L Denotes a PR that changes 1000-4999 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tunguso4ka @beck-thompson @TheShuEd @slarticodefast