Store Refund - Add more disable scenerios & time to disable refund. #34671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Disables refund on action use.
…e current time before disabling refund
…und for more consistency and easier tracking
github-actions
bot
added
S: Untriaged
ArtisticRoomba
added
P3: Standard
github-actions
bot
added
the
S: Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
S: Merge Conflict
ScarKy0
requested changes
Feb 8, 2025
ScarKy0
added
S: Awaiting Changes
|
1 maint approval + 1 PM making PR = merg |
This was referenced Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Added more routes for us to disable refunds after some entity events and so a time can be provided to disable events instead of just relying on the grid.
Why / Balance
Just relying on grid changes is not great and is really mostly for the wizard.
As an extra security measure we also now check if the allotted time has passed before also disabling refunds & checking grid.
Technical details
Method was made to check if we should disable refunds.
Subscriptions to events for using an item, using an action, and shooting a gun were added so we can disable refunds.
Media
Requirements
Breaking changes
Removed action check from refund disable method, so we can disable refund on action use.
Refund disable method now checks grid & if the time is eligible.
Changelog