Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[April Fools] Stunbaton #35576

Open
wants to merge 2 commits into
base: april-fools-2025
Choose a base branch
from
Open

[April Fools] Stunbaton #35576

wants to merge 2 commits into from
+6 −4

Conversation

notquitehadouken
Copy link
Contributor

About the PR

Stun baton now go stun fast yes

Why / Balance

Comedy

Technical details

Media

MyServer.-.Space.Station.14.2025-02-27.23-38-49.online-video-cutter.com.mp4

Requirements

Breaking changes

Changelog

🆑

  • tweak: Stun batons go WEEEEEEEEEEEEEEE

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 28, 2025
@Compilatron144
Copy link
Contributor

Compilatron144 commented Feb 28, 2025 •
edited
Loading

This combined with #35436, security is finally playable again

the showcase video is also peak

slarticodefast
slarticodefast requested changes Feb 28, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will create admin logs at a rate of 120 entries per second for each target, more if you hit multiple with wideswing.
This could bring down the admin infrastructure, in addition to possible performance problems for the server.
I don't hink this is something we can merge, even for april fools.

@notquitehadouken
Copy link
Contributor Author

This will create admin logs at a rate of 120 entries per second for each target, more if you hit multiple with wideswing.
This could bring down the admin infrastructure, in addition to possible performance problems for the server.
I don't hink this is something we can merge, even for april fools.

what if i made it log only once every second or so

@slarticodefast
Copy link
Member

It will still cause a massive amounts of events to be raised each time an enemy is hit.
I just gave it a test and if you hit like 10 mobs at once you cause severe server lag.
Someone could easily crash a server with a few monkey cubes with this.

@notquitehadouken
Copy link
Contributor Author

It will still cause a massive amounts of events to be raised each time an enemy is hit.
I just gave it a test and if you hit like 10 mobs at once you cause severe server lag.
Someone could easily crash a server with a few monkey cubes with this.

ok I'll lower the attack speed

@tutoumi
Copy link

tutoumi commented Feb 28, 2025

jjba aah stunbaton

@notquitehadouken
Copy link
Contributor Author

i'm keeping the current media because it's funnier

@Pumkin69
Copy link
Contributor

Finally security is playable.

slarticodefast
slarticodefast approved these changes Mar 1, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave the new values a test and they seem fine to me!

@slarticodefast slarticodefast added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Mar 1, 2025
@BramvanZijp BramvanZijp added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. P3: Standard Priority: Default priority for repository items. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. Branch: April Fools Intended for the yearly April Fools' branch. A: Combat Area: Combat features and changes, balancing, feel A: Security Area: Security department, including Detectives, HoS and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Mar 1, 2025
@slarticodefast slarticodefast self-assigned this Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarticodefast slarticodefast slarticodefast approved these changes

Assignees

@slarticodefast slarticodefast

Labels
A: Combat Area: Combat features and changes, balancing, feel A: Security Area: Security department, including Detectives, HoS Branch: April Fools Intended for the yearly April Fools' branch. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/S Denotes a PR that changes 10-99 lines. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@notquitehadouken @Compilatron144 @slarticodefast @tutoumi @Pumkin69 @BramvanZijp