Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix two pointing bugs #5766

Merged
merged 3 commits into from
Dec 14, 2021
Merged

fix two pointing bugs #5766

merged 3 commits into from
Dec 14, 2021

Conversation

ElectroJr
Copy link
Member

this PR

  • Fixes a bug preventing players from pointing at entities (a has-component check somehow become just an entity-exists check during IEntity purge)
  • Stops incapacitated (dead/crit) players from pointing.
  • Replaces EntityManager calls with proxy methods.

🆑

  • fix: Pointing at entities works again.

@ElectroJr ElectroJr mentioned this pull request Dec 13, 2021
Closed
4 tasks
PaulRitter
PaulRitter suggested changes Dec 13, 2021
View reviewed changes
Copy link
Member

@PaulRitter PaulRitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ElectroJr ElectroJr requested a review from PaulRitter December 13, 2021 11:59
@ElectroJr
Revert "add Exists()"
4ff2cec 
This reverts commit fc440e4.
@metalgearsloth metalgearsloth merged commit f2d0319 into space-wizards:master Dec 14, 2021
@ElectroJr ElectroJr deleted the fix-pointing branch March 24, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShadowCommander ShadowCommander ShadowCommander approved these changes

@PJB3005 PJB3005 Awaiting requested review from PJB3005

@gradientvera gradientvera Awaiting requested review from gradientvera

@PaulRitter PaulRitter Awaiting requested review from PaulRitter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ElectroJr @ShadowCommander @PaulRitter @metalgearsloth