Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix widget crashing on Android 12 #24

Merged
merged 3 commits into from
Sep 4, 2022

Conversation

FriederHannenheim
Copy link

@FriederHannenheim FriederHannenheim commented Aug 29, 2022

Fixes #25

@dbrgn
Copy link

dbrgn commented Sep 3, 2022

Does the widget actually work for you?

In the emulator with Android 12, if I add the widget to the homescreen, it's stuck on the loading animation:

screenshot-20220903-123027

I can dismiss the loading indicator, but the list of spaces remains empty.

(So far I did not debug the widget, and I don't actually know how it works, I mainly concentrated my efforts after forking into modernizing the main app.)

@dbrgn
Copy link

dbrgn commented Sep 3, 2022

Ah, this seems to be #23. You're right, it just seems to be very slow.

After adding the widget, it looks like this:

screenshot-20220903-123405

@niccokunzmann
Copy link
Member

I think, since it is a small fix and I can not reproduce it, I would like to see it merged. It looks like it adds parameters only in case the condition of the OS version identified in the issue is used to change the default. So, I would trust the author with having good intentions and also invested the time.

@dbrgn
Copy link

dbrgn commented Sep 4, 2022

You're right. From my point of view the widget was broken before and still doesn't work, but we can find out later what the reason for this is 🙂 Further fixes and improvements welcome.

@dbrgn
Copy link

dbrgn commented Sep 4, 2022

I did a small cleanup commit for consistency (SDK_INT was imported statically, VERSION_CODES.S was not). Merging as soon as the build succeeds!

@dbrgn dbrgn merged commit a05089e into spaceapi-community:main Sep 4, 2022
@FriederHannenheim
Copy link
Author

You're right. From my point of view the widget was broken before and still doesn't work, but we can find out later what the reason for this is 🙂 Further fixes and improvements welcome.

The widget is working. The loading just takes very long ~1 min but after that it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes when trying to create a widget on Android 12
3 participants