Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added a search function #647

Merged
merged 7 commits into from
Mar 3, 2025

Conversation

Friendly-Banana
Copy link
Contributor

@Friendly-Banana Friendly-Banana commented Feb 28, 2025

Allows searching in titles and snippets, one of the features mentioned in #464.

I am new to Kotlin and Compose, so please let me know if there's a better way to do things.

fixes #368

Copy link
Owner

@spacecowboy spacecowboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I've left some feedback.

It doesn't look great on Tablets but I think the value it brings is important enough not to let that block it:

tablet_search

@spacecowboy
Copy link
Owner

Thanks for you work on this! I think many will be happy to see it.

@spacecowboy spacecowboy changed the title Add a Search function feat: added a search function Mar 3, 2025
@spacecowboy spacecowboy merged commit 5e6ef96 into spacecowboy:master Mar 3, 2025
8 of 11 checks passed
@spacecowboy spacecowboy mentioned this pull request Mar 6, 2025
4 tasks
@Friendly-Banana Friendly-Banana deleted the search branch March 7, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global or title search function
2 participants