v2alpha1: Add NumUnits to Activation and extend request filters #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kacpersaw
commented
Jun 21, 2024
•
kacpersaw
commented
- Add NumUnits to Activation message
- Change name of NodeId filter to SmesherId.
- Modify Id to allow multiple entries.
brusherru
approved these changes
Jun 21, 2024
poszu
reviewed
Jun 21, 2024
| @@ -13,6 +13,7 @@ message Activation { | |||
| string coinbase = 6; | |||
| uint64 weight = 7; | |||
| uint64 height = 8; | |||
| uint32 num_units = 9; // number of PoST data commitment units | |||
There was a problem hiding this comment.
NIT:
Suggested change
| uint32 num_units = 9; // number of PoST data commitment units | |
| uint32 units = 9; // number of effective PoST data commitment units |
This value might be smaller than the actual number of units in the ATX because we take the minimum of previous ATX and the current ATX. So somebody grewing their space and publishing ATXs with increasing size gets:
- units = 4 SU, effective units = 4 SU
- units = 8 SU, effective units = 4 SU
- units = 8 SU, effective units = 8 SU
If you need the exact number of units (as it results from the commited PoST size in this ATX), we would need to read it from the ATX blob.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.