Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-split poc: Add PROPOSAL_PUBLISH_FAILED state #397

Merged
merged 1 commit into from
Dec 4, 2024
Merged

node-split poc: Add PROPOSAL_PUBLISH_FAILED state #397

merged 1 commit into from
Dec 4, 2024

Conversation

kacpersaw
Copy link
Contributor

Description

This pull request introduces changes to the API and protocol buffer definitions to handle a new state, PROPOSAL_PUBLISH_FAILED.

Changes to protocol buffer definitions:

  • Updated the IdentityState enum to include PROPOSAL_PUBLISH_FAILED and adjusted the value of PROPOSAL_PUBLISHED in smeshing_identities.proto.
  • Added a new message ProposalPublishFailedState in smeshing_identities.proto.
  • Updated the IdentityStateInfo message to include ProposalPublishFailedState in smeshing_identities.proto.

@kacpersaw kacpersaw requested a review from poszu December 4, 2024 12:01
@kacpersaw kacpersaw merged commit 34acdbf into node-split-poc Dec 4, 2024
1 check passed
@jellonek jellonek deleted the node-split-poc-failed-proposal branch December 4, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poszu poszu poszu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kacpersaw @poszu