refactor: opinion hasher to be pooled

spacemeshos · Jun 17, 2024 · fb48a6e · fb48a6e
1 parent c74972d
commit fb48a6e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/common/types/proposal.go b/common/types/proposal.go
@@ -113,8 +113,7 @@ func (p *Proposal) HashInnerProposal() []byte {
 	if err != nil {
 		log.With().Fatal("failed to encode InnerProposal for hashing", log.Err(err))
 	}
-	sum := h.Sum(nil)
-	return sum
+	return h.Sum(nil)
 }
 
 // ID returns the ProposalID.

diff --git a/tortoise/state.go b/tortoise/state.go
@@ -180,7 +180,8 @@ type layerInfo struct {
 }
 
 func (l *layerInfo) computeOpinion(hdist uint32, last types.LayerID) {
-	hasher := opinionhash.New()
+	hasher := opinionhash.GetHasher()
+	defer opinionhash.PutHasher(hasher)
 	if l.prevOpinion != nil {
 		hasher.WritePrevious(*l.prevOpinion)
 	}
@@ -372,7 +373,8 @@ func (l *layerVote) sortSupported() {
 }
 
 func (l *layerVote) computeOpinion() {
-	hasher := opinionhash.New()
+	hasher := opinionhash.GetHasher()
+	defer opinionhash.PutHasher(hasher)
 	if l.prev != nil {
 		hasher.WritePrevious(l.prev.opinion)
 	}