Skip to content

Commit

Permalink
Review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
fasmat committed Apr 9, 2024
1 parent 11bf544 commit fcda067
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion api/grpcserver/post_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func (s *PostService) connectionAllowed() bool {
// requests to the PoST node and receive responses.
func (s *PostService) Register(stream pb.PostService_RegisterServer) error {
if !s.connectionAllowed() {
return status.Error(codes.PermissionDenied, "connection not allowed: node has no coinbase set in config")
return status.Error(codes.FailedPrecondition, "connection not allowed: node has no coinbase set in config")
}

err := stream.SendMsg(&pb.NodeRequest{
Expand Down
2 changes: 1 addition & 1 deletion api/grpcserver/post_service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,6 @@ func Test_PostService_Connection_NotAllowed(t *testing.T) {

_, err = stream.Recv()
require.Error(t, err)
require.Equal(t, codes.PermissionDenied, status.Code(err))
require.Equal(t, codes.FailedPrecondition, status.Code(err))
require.ErrorContains(t, err, "connection not allowed")
}
6 changes: 5 additions & 1 deletion node/node.go
Original file line number Diff line number Diff line change
Expand Up @@ -1436,7 +1436,11 @@ func (app *App) grpcService(svc grpcserver.Service, lg log.Log) (grpcserver.Serv
return service, nil
case grpcserver.Post:
service := grpcserver.NewPostService(app.addLogger(PostServiceLogger, lg).Zap())
service.AllowConnections(app.Config.SMESHING.CoinbaseAccount != "")
isCoinbaseSet := app.Config.SMESHING.CoinbaseAccount != ""
if !isCoinbaseSet {
lg.Warning("coinbase account is not set, connections from remote post services will be rejected")
}
service.AllowConnections(isCoinbaseSet)
app.grpcServices[svc] = service
return service, nil
case grpcserver.PostInfo:
Expand Down

0 comments on commit fcda067

Please sign in to comment.