[Merged by Bors] - hare3 implementation #4765

dshulyak · 2023-08-02T10:20:51Z

implementation is splitted into several files:

protocol.go

implements protocol execution logic close to the original paper, baring several differences in syntax and things that we need but are not covered in the paper. interface for interacting with protocol has two methods:

onMessage
next(active bool)

only active nodes are publishing messages

types.go

types that go over the wire

type Message struct {
	Body
	Sender    types.NodeID
	Signature types.EdSignature
}

type Body struct {
	Layer types.LayerID
	IterRound
	Value       Value
	Eligibility types.HareEligibility
}

type Value struct {
	// Proposals is set in messages for preround and propose rounds.
	Proposals []types.ProposalID `scale:"max=200"`
	// Reference is set in messages for commit and notify rounds.
	Reference *types.Hash32
}

signature domain and malfeasance proof remains the same, as we don't intend to run more than one hare in parallel.

hare.go

integrates protocol with spacemesh data model, network, synchronization. manages multiple protocol instances (one per layer).

legacy_oracle.go

wrapper for oracle that uses active set in consensus, it outputs maximum grades for identities that are in consensus and 0 for everyone else.

compat

intergration for weakcoin and hare results to avoid changes across the app

remaining:

test commit with different locked value in protocol_test.go (remaining for 100%)

dshulyak · 2023-08-02T10:23:12Z

bors try

codecov · 2023-08-02T10:36:40Z

Codecov Report

Merging #4765 (2c86042) into develop (2ffb4e0) will increase coverage by 0.3%.
The diff coverage is 84.0%.

@@            Coverage Diff            @@
##           develop   #4765     +/-   ##
=========================================
+ Coverage     76.7%   77.0%   +0.3%     
=========================================
  Files          256     263      +7     
  Lines        29665   30528    +863     
=========================================
+ Hits         22772   23531    +759     
- Misses        5423    5500     +77     
- Partials      1470    1497     +27

Files Changed	Coverage Δ
hare/config/config.go	`100.0% <ø> (ø)`
hare/hare.go	`74.6% <0.0%> (-0.6%)`	⬇️
hare3/compat/result.go	`0.0% <0.0%> (ø)`
hare3/compat/weakcoin.go	`0.0% <0.0%> (ø)`
hare3/tracer.go	`0.0% <0.0%> (ø)`
node/node.go	`63.1% <0.0%> (-1.3%)`	⬇️
codec/codec.go	`54.9% <50.0%> (-0.3%)`	⬇️
hare3/legacy_oracle.go	`73.1% <73.1%> (ø)`
hare3/hare.go	`84.5% <84.5%> (ø)`
common/types/malfeasance.go	`52.8% <85.7%> (+3.1%)`	⬆️
... and 5 more

... and 5 files with indirect coverage changes

bors · 2023-08-02T11:09:32Z

try

Build failed:

systest-status

dshulyak · 2023-08-02T12:59:28Z

tx count in 21 and 22 layers is a bit off, might be mistimed somehow

dshulyak · 2023-08-05T10:35:10Z

bors try

bors · 2023-08-05T10:57:50Z

try

Build failed:

ci-status

dshulyak · 2023-08-05T11:01:04Z

bors try

bors · 2023-08-05T11:23:06Z

try

Build failed:

ci-status

dshulyak · 2023-08-05T12:40:22Z

bors try

bors · 2023-08-05T13:49:53Z

try

Build failed:

systest-status

implementation is splitted into several files: #### protocol.go implements protocol execution logic close to the original paper, baring several differences in syntax and things that we need but are not covered in the paper. interface for interacting with protocol has two methods: - onMessage - next(active bool) only active nodes are publishing messages #### types.go types that go over the wire ```go type Message struct { Body Sender types.NodeID Signature types.EdSignature } type Body struct { Layer types.LayerID IterRound Value Value Eligibility types.HareEligibility } type Value struct { // Proposals is set in messages for preround and propose rounds. Proposals []types.ProposalID `scale:"max=200"` // Reference is set in messages for commit and notify rounds. Reference *types.Hash32 } ``` signature domain and malfeasance proof remains the same, as we don't intend to run more than one hare in parallel. #### hare.go integrates protocol with spacemesh data model, network, synchronization. manages multiple protocol instances (one per layer). #### legacy_oracle.go wrapper for oracle that uses active set in consensus, it outputs maximum grades for identities that are in consensus and 0 for everyone else. #### compat intergration for weakcoin and hare results to avoid changes across the app remaining: - [ ] test commit with different locked value in protocol_test.go (remaining for 100%)

bors · 2023-08-30T10:12:22Z

Build failed:

systest-status

dshulyak · 2023-08-30T10:16:00Z

bors try

dshulyak · 2023-08-30T10:21:17Z

cluster was prematurely terminated. can't find any failures

bors · 2023-08-30T11:03:34Z

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

dshulyak · 2023-08-30T11:04:17Z

bors merge

implementation is splitted into several files: #### protocol.go implements protocol execution logic close to the original paper, baring several differences in syntax and things that we need but are not covered in the paper. interface for interacting with protocol has two methods: - onMessage - next(active bool) only active nodes are publishing messages #### types.go types that go over the wire ```go type Message struct { Body Sender types.NodeID Signature types.EdSignature } type Body struct { Layer types.LayerID IterRound Value Value Eligibility types.HareEligibility } type Value struct { // Proposals is set in messages for preround and propose rounds. Proposals []types.ProposalID `scale:"max=200"` // Reference is set in messages for commit and notify rounds. Reference *types.Hash32 } ``` signature domain and malfeasance proof remains the same, as we don't intend to run more than one hare in parallel. #### hare.go integrates protocol with spacemesh data model, network, synchronization. manages multiple protocol instances (one per layer). #### legacy_oracle.go wrapper for oracle that uses active set in consensus, it outputs maximum grades for identities that are in consensus and 0 for everyone else. #### compat intergration for weakcoin and hare results to avoid changes across the app remaining: - [ ] test commit with different locked value in protocol_test.go (remaining for 100%)

bors · 2023-08-30T11:48:02Z

Build failed:

systest-status

dshulyak · 2023-08-30T12:34:48Z

bors try

bors · 2023-08-30T12:49:40Z

try

Build failed:

ci-status

dshulyak · 2023-08-30T12:56:05Z

bors try

bors · 2023-08-30T13:48:26Z

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

dshulyak · 2023-08-30T13:49:30Z

bors try

bors · 2023-08-30T14:04:30Z

try

Build failed:

ci-status

dshulyak · 2023-08-30T14:39:42Z

bors try

bors · 2023-08-30T15:24:26Z

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

dshulyak · 2023-08-30T15:25:29Z

bors merge

implementation is splitted into several files: #### protocol.go implements protocol execution logic close to the original paper, baring several differences in syntax and things that we need but are not covered in the paper. interface for interacting with protocol has two methods: - onMessage - next(active bool) only active nodes are publishing messages #### types.go types that go over the wire ```go type Message struct { Body Sender types.NodeID Signature types.EdSignature } type Body struct { Layer types.LayerID IterRound Value Value Eligibility types.HareEligibility } type Value struct { // Proposals is set in messages for preround and propose rounds. Proposals []types.ProposalID `scale:"max=200"` // Reference is set in messages for commit and notify rounds. Reference *types.Hash32 } ``` signature domain and malfeasance proof remains the same, as we don't intend to run more than one hare in parallel. #### hare.go integrates protocol with spacemesh data model, network, synchronization. manages multiple protocol instances (one per layer). #### legacy_oracle.go wrapper for oracle that uses active set in consensus, it outputs maximum grades for identities that are in consensus and 0 for everyone else. #### compat intergration for weakcoin and hare results to avoid changes across the app remaining: - [ ] test commit with different locked value in protocol_test.go (remaining for 100%)

bors · 2023-08-30T16:17:45Z

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

dshulyak added 4 commits August 2, 2023 09:11

squash hare3

de3d42a

integrate into codebase

ca90c2e

validation

42538d3

linter

c575e1d

bors bot added a commit that referenced this pull request Aug 2, 2023

Try #4765:

abf4b19

dshulyak added 6 commits August 3, 2023 06:37

progress

8ea1178

add more references

2ec5578

add fuzzer for decode

d85de6d

cleanup and more tests

0f4e364

add sufficient metrics for debug

68ff558

cleanup

a41d87c

bors bot added a commit that referenced this pull request Aug 5, 2023

Try #4765:

3d8c68b

Merge branch 'develop' into hare3-fresh

d12a2ae

dshulyak force-pushed the hare3-fresh branch from 374c128 to d12a2ae Compare August 5, 2023 10:52

linter

6710ae7

bors bot added a commit that referenced this pull request Aug 5, 2023

Try #4765:

6df5d98

move message key back

8ebdd81

bors bot added a commit that referenced this pull request Aug 5, 2023

Try #4765:

8635b58

limit iterations in test

1fd9531

dshulyak force-pushed the hare3-fresh branch from 19f3b1b to 1fd9531 Compare August 5, 2023 13:49

bors bot added a commit that referenced this pull request Aug 30, 2023

Try #4765:

7ca4f5f

bors bot added a commit that referenced this pull request Aug 30, 2023

Try #4765:

031779e

dshulyak force-pushed the hare3-fresh branch from fe5666d to 666f447 Compare August 30, 2023 12:42

remove debug log

2c86042

bors bot added a commit that referenced this pull request Aug 30, 2023

Try #4765:

04f2610

bors bot added a commit that referenced this pull request Aug 30, 2023

Try #4765:

78f7fbf

bors bot added a commit that referenced this pull request Aug 30, 2023

Try #4765:

0c1b5ae

bors bot changed the title ~~hare3 implementation~~ [Merged by Bors] - hare3 implementation Aug 30, 2023

bors bot closed this Aug 30, 2023

acud mentioned this pull request Jul 2, 2024

feat: hare to use shorter hashes on preround #6060

Closed

8 tasks

acud mentioned this pull request Jul 11, 2024

[Merged by Bors] - feat: hare preround proposal compaction #6129

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - hare3 implementation #4765

[Merged by Bors] - hare3 implementation #4765

dshulyak commented Aug 2, 2023 •

edited

Loading

dshulyak commented Aug 2, 2023

codecov bot commented Aug 2, 2023 •

edited

Loading

bors bot commented Aug 2, 2023

dshulyak commented Aug 2, 2023

dshulyak commented Aug 5, 2023

bors bot commented Aug 5, 2023

dshulyak commented Aug 5, 2023

bors bot commented Aug 5, 2023

dshulyak commented Aug 5, 2023

bors bot commented Aug 5, 2023

bors bot commented Aug 30, 2023

dshulyak commented Aug 30, 2023

dshulyak commented Aug 30, 2023

bors bot commented Aug 30, 2023

dshulyak commented Aug 30, 2023

bors bot commented Aug 30, 2023

dshulyak commented Aug 30, 2023

bors bot commented Aug 30, 2023

dshulyak commented Aug 30, 2023

bors bot commented Aug 30, 2023

dshulyak commented Aug 30, 2023

bors bot commented Aug 30, 2023

dshulyak commented Aug 30, 2023

bors bot commented Aug 30, 2023

dshulyak commented Aug 30, 2023

bors bot commented Aug 30, 2023

[Merged by Bors] - hare3 implementation #4765

[Merged by Bors] - hare3 implementation #4765

Conversation

dshulyak commented Aug 2, 2023 • edited Loading

protocol.go

types.go

hare.go

legacy_oracle.go

compat

dshulyak commented Aug 2, 2023

codecov bot commented Aug 2, 2023 • edited Loading

Codecov Report

bors bot commented Aug 2, 2023

try

dshulyak commented Aug 2, 2023

dshulyak commented Aug 5, 2023

bors bot commented Aug 5, 2023

try

dshulyak commented Aug 5, 2023

bors bot commented Aug 5, 2023

try

dshulyak commented Aug 5, 2023

bors bot commented Aug 5, 2023

try

bors bot commented Aug 30, 2023

dshulyak commented Aug 30, 2023

dshulyak commented Aug 30, 2023

bors bot commented Aug 30, 2023

try

dshulyak commented Aug 30, 2023

bors bot commented Aug 30, 2023

dshulyak commented Aug 30, 2023

bors bot commented Aug 30, 2023

try

dshulyak commented Aug 30, 2023

bors bot commented Aug 30, 2023

try

dshulyak commented Aug 30, 2023

bors bot commented Aug 30, 2023

try

dshulyak commented Aug 30, 2023

bors bot commented Aug 30, 2023

try

dshulyak commented Aug 30, 2023

bors bot commented Aug 30, 2023

dshulyak commented Aug 2, 2023 •

edited

Loading

codecov bot commented Aug 2, 2023 •

edited

Loading