[Merged by Bors] - update majority calculation for optimistic filtering #4879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4879 +/- ##
=========================================
- Coverage 76.7% 76.7% -0.1%
=========================================
Files 256 256
Lines 29655 29665 +10
=========================================
- Hits 22774 22772 -2
- Misses 5408 5423 +15
+ Partials 1473 1470 -3
|
dshulyak
approved these changes
Aug 21, 2023
blocks/utils.go
Outdated
| @@ -69,15 +69,22 @@ func getProposalMetadata( | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| upgrade := proposals[0].Layer.Uint32() >= types.OpUpgradeLayer() | |||
There was a problem hiding this comment.
it is not obvious that proposals[0] exists
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
## Motivation Closes #4878 ## Changes this change will take effect at the first layer of epoch 3
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4878
Changes
this change will take effect at the first layer of epoch 3