[Merged by Bors] - optimize ballot eligibility validation #4923
Conversation
dshulyak
force-pushed
the
optiimize-eligibility-validation
branch
from
ccf928b to
afa329f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4923 +/- ##
=======================================
Coverage 77.0% 77.0%
=======================================
Files 263 263
Lines 30532 30532
=======================================
+ Hits 23529 23540 +11
+ Misses 5505 5501 -4
+ Partials 1498 1491 -7
|
|
i synced node with this change couple of times. another related improvement #4927 |
|
bors try |
tryBuild failed: |
|
bors try |
proposals/interface.go
Outdated
| type vrfVerifier interface { | ||
| Verify(types.NodeID, []byte, types.VrfSignature) bool | ||
| } | ||
|
|
tryBuild failed: |
|
bors merge |
|
Canceled. |
|
bors merge |
closes: #4883 related: #4841 active set is validated only for reference ballot in current epoch, for all other ballots eligibilities validated against declared slots in the reference ballot. beside making validation more efficient, it will allow to prune active set data in future changes. reference ballots is still loading data from cached datastore, i plan to remove eventually but not in this change. additionally i rewrote all tests for eligibility validator to get to 100% coverage and make them less dependent on the implementation.
|
bors cancel |
|
Canceled. |
dshulyak
changed the title
|
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
bors merge |
closes: #4883 related: #4841 active set is validated only for reference ballot in current epoch, for all other ballots eligibilities validated against declared slots in the reference ballot. beside making validation more efficient, it will allow to prune active set data in future changes. reference ballots is still loading data from cached datastore, i plan to remove eventually but not in this change. additionally i rewrote all tests for eligibility validator to get to 100% coverage and make them less dependent on the implementation.
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
closes: #4883
related: #4841
active set is validated only for reference ballot in current epoch, for all other ballots eligibilities validated against declared slots in the reference ballot. beside making validation more efficient, it will allow to prune active set data in future changes. reference ballots is still loading data from cached datastore, i plan to remove eventually but not in this change.
additionally i rewrote all tests for eligibility validator to get to 100% coverage and make them less dependent on the implementation.