Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - 4783 poet client logging #4988

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - 4783 poet client logging #4988

wants to merge 4 commits into from

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Sep 8, 2023 •
edited
Loading

Motivation

Part of #4751
Closes #4783

Changes

  • use local logger in poet clients
  • provide the logger to retryablehttp to gain visibility on performed requests, retries, responses etc.
  • cleanup poet test harness

Test Plan

Existing tests pass

@poszu poszu marked this pull request as ready for review September 8, 2023 11:26
@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited
Loading

Codecov Report

Merging #4988 (ae739f2) into develop (ac07d76) will increase coverage by 0.0%.
Report is 5 commits behind head on develop.
The diff coverage is 82.0%.

@@           Coverage Diff           @@
##           develop   #4988   +/-   ##
=======================================
  Coverage     77.1%   77.1%           
=======================================
  Files          254     254           
  Lines        30253   30274   +21     
=======================================
+ Hits         23339   23356   +17     
- Misses        5400    5403    +3     
- Partials      1514    1515    +1
Files Changed Coverage Δ
activation/poet.go 75.2% <77.4%> (-0.4%) ⬇️
activation/nipost.go 81.0% <100.0%> (-0.8%) ⬇️
activation/poet_test_harness.go 85.3% <100.0%> (+4.9%) ⬆️

... and 4 files with indirect coverage changes

fasmat
fasmat reviewed Sep 8, 2023
View reviewed changes
activation/poet.go Outdated Show resolved Hide resolved
activation/poet.go Show resolved Hide resolved
@poszu
Copy link
Contributor Author

poszu commented Sep 8, 2023

Bors merge

bors bot pushed a commit that referenced this pull request Sep 8, 2023
@poszu
4783 poet client logging (#4988)
5f02d52 
## Motivation
Part of  #4751 
Closes #4783

## Changes
- use local logger in poet clients
- provide the logger to `retryablehttp` to gain visibility on performed requests, retries, responses etc.
- cleanup poet test harness

## Test Plan
Existing tests pass
@bors
Copy link

bors bot commented Sep 8, 2023

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request Sep 8, 2023
@poszu
4783 poet client logging (#4988)
24286d1 
## Motivation
Part of  #4751 
Closes #4783

## Changes
- use local logger in poet clients
- provide the logger to `retryablehttp` to gain visibility on performed requests, retries, responses etc.
- cleanup poet test harness

## Test Plan
Existing tests pass
@bors
Copy link

bors bot commented Sep 8, 2023

Build failed (retrying...):

  • systest-status

bors bot pushed a commit that referenced this pull request Sep 8, 2023
@poszu
4783 poet client logging (#4988)
16f717e 
## Motivation
Part of  #4751 
Closes #4783

## Changes
- use local logger in poet clients
- provide the logger to `retryablehttp` to gain visibility on performed requests, retries, responses etc.
- cleanup poet test harness

## Test Plan
Existing tests pass
@bors
Copy link

bors bot commented Sep 8, 2023

Build failed:

@poszu
Copy link
Contributor Author

poszu commented Sep 8, 2023

Failed TestCheckpoint which seems unrelated.

Bors merge

bors bot pushed a commit that referenced this pull request Sep 8, 2023
@poszu
4783 poet client logging (#4988)
900f5b5 
## Motivation
Part of  #4751 
Closes #4783

## Changes
- use local logger in poet clients
- provide the logger to `retryablehttp` to gain visibility on performed requests, retries, responses etc.
- cleanup poet test harness

## Test Plan
Existing tests pass
@poszu poszu added the area/poet label Sep 8, 2023
@bors
Copy link

bors bot commented Sep 8, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title 4783 poet client logging [Merged by Bors] - 4783 poet client logging Sep 8, 2023
@bors bors bot closed this Sep 8, 2023
@bors bors bot deleted the 4783-poet-client-logging branch September 8, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fasmat fasmat fasmat approved these changes

@countvonzero countvonzero Awaiting requested review from countvonzero

@dshulyak dshulyak Awaiting requested review from dshulyak dshulyak is a code owner

Assignees
No one assigned
Labels
area/poet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't use a global logger in the poet client
2 participants
@poszu @fasmat