[Merged by Bors] - Add workaround for PoET round 4 #5031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
requested review from
countvonzero,
dshulyak and
poszu
as code owners
fasmat
force-pushed
the
5029-fetch-poet-112-round-4
branch
from
ea8626d to
a56a9ed
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5031 +/- ##
=========================================
- Coverage 77.1% 77.0% -0.1%
=========================================
Files 257 257
Lines 30254 30274 +20
=========================================
- Hits 23328 23326 -2
- Misses 5400 5421 +21
- Partials 1526 1527 +1
|
poszu
reviewed
Sep 20, 2023
poszu
approved these changes
Sep 20, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
## Motivation Closes #5029 ## Changes - For PoET round 4 / publish epoch 5 PoET 112 will be added to the local state to fetch proofs from if the node registered to PoET 110 for that round. ## Test Plan Added tests to ensure workaround works for the correct epoch / round ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #5029
Changes
Test Plan
Added tests to ensure workaround works for the correct epoch / round
TODO