[Merged by Bors] - implement pruner for activesets #5169
Conversation
| activesetEpoch types.EpochID | ||
| } | ||
|
|
||
| func Run(ctx context.Context, p *Pruner, clock *timesync.NodeClock, interval time.Duration) { |
There was a problem hiding this comment.
Could this be a method of Pruner?
There was a problem hiding this comment.
it can be, i thought that it is better to remove dependencies from Pruner that can be passed only to Run
There was a problem hiding this comment.
Run takes a pruner as an argument, so someone calling it has to instantiate it anyway?
pruner := prune.New(...)
prune.Run(ctx, pruner, ...)
// vs
pruner := prune.New(...)
pruner.Run(ctx, ...)merge before that change #5169 we use active sets only to verify eligibilities for ballots in the current epoch. as there is an incentive to create as little ballots as possible. for older ballots we use eligibility counter provided in the reference ballots
|
bors merge |
closes: #5114 pruning activesets will significantly reduce space (as of now ~1.5GB / 2.9GB).
|
Build failed: |
merge before that change #5169 we use active sets only to verify eligibilities for ballots in the current epoch. as there is an incentive to create as little ballots as possible. for older ballots we use eligibility counter provided in the reference ballots
|
bors merge |
Codecov Report
@@ Coverage Diff @@
## develop #5169 +/- ##
=========================================
- Coverage 77.7% 77.7% -0.1%
=========================================
Files 259 259
Lines 30781 30809 +28
=========================================
+ Hits 23947 23967 +20
- Misses 5345 5351 +6
- Partials 1489 1491 +2
|
closes: #5114 pruning activesets will significantly reduce space (as of now ~1.5GB / 2.9GB).
|
Build failed: |
merge before that change #5169 we use active sets only to verify eligibilities for ballots in the current epoch. as there is an incentive to create as little ballots as possible. for older ballots we use eligibility counter provided in the reference ballots
|
bors cancel |
|
bors merge |
closes: #5114 pruning activesets will significantly reduce space (as of now ~1.5GB / 2.9GB).
|
Build failed: |
dshulyak
force-pushed
the
prune-activesets
branch
from
6e4b0d7 to
e51ab13
Compare
|
bors merge |
closes: #5114 pruning activesets will significantly reduce space (as of now ~1.5GB / 2.9GB).
|
Build failed: |
|
bors merge |
closes: #5114 pruning activesets will significantly reduce space (as of now ~1.5GB / 2.9GB).
|
Build failed: |
|
bors merge |
closes: #5114 pruning activesets will significantly reduce space (as of now ~1.5GB / 2.9GB).
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
closes: #5114
pruning activesets will significantly reduce space (as of now ~1.5GB / 2.9GB).