Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - activation: Remove deprecated best provider option #5189

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - activation: Remove deprecated best provider option #5189

wants to merge 2 commits into from
+50 −113

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Oct 23, 2023

Motivation

Closes #4801

Changes

  • remove -1 as option for providerID
  • remove autobenchmarking

Test Plan

  • removed tests for autobenchmarking
  • updated existing tests to reject -1 as valid option for Provider ID

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat self-assigned this Oct 23, 2023
@fasmat fasmat force-pushed the 4801-remove-deprecated-best-provider branch from 44d31ad to fca7031 Compare October 23, 2023 11:01
@fasmat fasmat mentioned this pull request Oct 23, 2023
Closed
4 tasks
@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited
Loading

Codecov Report

Merging #5189 (bbc4265) into develop (c5f37b5) will increase coverage by 0.0%.
Report is 1 commits behind head on develop.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           develop   #5189   +/-   ##
=======================================
  Coverage     77.7%   77.7%           
=======================================
  Files          262     262           
  Lines        31144   31112   -32     
=======================================
- Hits         24216   24197   -19     
+ Misses        5419    5409   -10     
+ Partials      1509    1506    -3
Files Coverage Δ
activation/post.go 87.7% <ø> (+1.8%) ⬆️
activation/post_types.go 100.0% <100.0%> (ø)
api/grpcserver/smesher_service.go 70.5% <100.0%> (ø)
config/presets/fastnet.go 100.0% <100.0%> (ø)
config/presets/standalone.go 100.0% <100.0%> (ø)
config/presets/testnet.go 95.6% <100.0%> (ø)
node/mapstructureutil/postproviderid.go 88.8% <100.0%> (-0.6%) ⬇️

... and 2 files with indirect coverage changes

@fasmat
Copy link
Member Author

fasmat commented Oct 23, 2023

bors merge

bors bot pushed a commit that referenced this pull request Oct 23, 2023
@fasmat
activation: Remove deprecated best provider option (#5189)
b481c3a 
## Motivation
Closes #4801

## Changes
- remove `-1` as option for `providerID`
- remove autobenchmarking

## Test Plan
- removed tests for autobenchmarking
- updated existing tests to reject `-1` as valid option for Provider ID

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed
- [x] Update [changelog](../CHANGELOG.md) as needed
@bors
Copy link

bors bot commented Oct 23, 2023

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Oct 23, 2023

bors merge

bors bot pushed a commit that referenced this pull request Oct 23, 2023
@fasmat
activation: Remove deprecated best provider option (#5189)
d7de223 
## Motivation
Closes #4801

## Changes
- remove `-1` as option for `providerID`
- remove autobenchmarking

## Test Plan
- removed tests for autobenchmarking
- updated existing tests to reject `-1` as valid option for Provider ID

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed
- [x] Update [changelog](../CHANGELOG.md) as needed
@bors
Copy link

bors bot commented Oct 23, 2023

Build failed:

@fasmat fasmat force-pushed the 4801-remove-deprecated-best-provider branch from fca7031 to bbc4265 Compare October 23, 2023 16:43
@fasmat
Copy link
Member Author

fasmat commented Oct 23, 2023

bors merge

bors bot pushed a commit that referenced this pull request Oct 23, 2023
@fasmat
activation: Remove deprecated best provider option (#5189)
e1327c8 
## Motivation
Closes #4801

## Changes
- remove `-1` as option for `providerID`
- remove autobenchmarking

## Test Plan
- removed tests for autobenchmarking
- updated existing tests to reject `-1` as valid option for Provider ID

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed
- [x] Update [changelog](../CHANGELOG.md) as needed
@bors
Copy link

bors bot commented Oct 23, 2023

Build failed:

  • systest-status

@fasmat
Copy link
Member Author

fasmat commented Oct 23, 2023

bors merge

bors bot pushed a commit that referenced this pull request Oct 23, 2023
@fasmat
activation: Remove deprecated best provider option (#5189)
6da9e61 
## Motivation
Closes #4801

## Changes
- remove `-1` as option for `providerID`
- remove autobenchmarking

## Test Plan
- removed tests for autobenchmarking
- updated existing tests to reject `-1` as valid option for Provider ID

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed
- [x] Update [changelog](../CHANGELOG.md) as needed
@bors
Copy link

bors bot commented Oct 23, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title activation: Remove deprecated best provider option [Merged by Bors] - activation: Remove deprecated best provider option Oct 23, 2023
@bors bors bot closed this Oct 23, 2023
@bors bors bot deleted the 4801-remove-deprecated-best-provider branch October 23, 2023 18:28
bors bot pushed a commit that referenced this pull request Oct 25, 2023
@fasmat
Move initialization to supervisor (#5187)
55fe9e0 
## Motivation
Part of #5149  merge after #5186 & #5189

This moves the initialization code into the PoST supervisor. The ATX builder should not concern itself with initialization:
- A remote PoST service that connects is expected to already be fully initialized 
- In supervised mode the supervisor takes care of initialization

This allows to simplify the ATX builder, which has partially already been done in this PR and will continue in future PRs.

## Changes
- Removed dependency on `postSetupManager` from `atxBuilder`
- Simplified `atxBuilder`
  - Initial Proofs are not verified any more (PoST service is trusted)
  - Information about the PoST is fetched from the PoST service rather than accessed via the `postSetupManager`
- Simplified `postSetupManager`
  - Since meta information is now fetched via the client everything besides `StartSession`, `StopSession` and `Reset` has been removed from the interface
  - `postSetupManager` isn't used by the gRPC `SmeshingService` any more, instead it's now used by `PostSupervisor` to init a supervised node before starting it

For next PR: 
- change `atxBuilder` from `Start`/`Stop` to `Run`
  - a post service connecting triggers the builder loop (one per connected service)
  - simplify `atxBuilder` further and consider merging `nipostBuilder` into it.

## Test Plan
- added new tests to PoST supervisor to cover new functionality
- updated existing tests

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed
- [x] Update [changelog](../CHANGELOG.md) as needed
bors bot pushed a commit that referenced this pull request Oct 25, 2023
@fasmat
Move initialization to supervisor (#5187)
ba3b4b5 
## Motivation
Part of #5149  merge after #5186 & #5189

This moves the initialization code into the PoST supervisor. The ATX builder should not concern itself with initialization:
- A remote PoST service that connects is expected to already be fully initialized 
- In supervised mode the supervisor takes care of initialization

This allows to simplify the ATX builder, which has partially already been done in this PR and will continue in future PRs.

## Changes
- Removed dependency on `postSetupManager` from `atxBuilder`
- Simplified `atxBuilder`
  - Initial Proofs are not verified any more (PoST service is trusted)
  - Information about the PoST is fetched from the PoST service rather than accessed via the `postSetupManager`
- Simplified `postSetupManager`
  - Since meta information is now fetched via the client everything besides `StartSession`, `StopSession` and `Reset` has been removed from the interface
  - `postSetupManager` isn't used by the gRPC `SmeshingService` any more, instead it's now used by `PostSupervisor` to init a supervised node before starting it

For next PR: 
- change `atxBuilder` from `Start`/`Stop` to `Run`
  - a post service connecting triggers the builder loop (one per connected service)
  - simplify `atxBuilder` further and consider merging `nipostBuilder` into it.

## Test Plan
- added new tests to PoST supervisor to cover new functionality
- updated existing tests

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed
- [x] Update [changelog](../CHANGELOG.md) as needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshulyak dshulyak dshulyak approved these changes

@countvonzero countvonzero Awaiting requested review from countvonzero

@poszu poszu Awaiting requested review from poszu poszu is a code owner

Assignees

@fasmat fasmat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated option for best provider
2 participants
@fasmat @dshulyak