Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - hare3/compat: exit if hare channel got closed #5247

Closed
wants to merge 2 commits into from

Conversation

dshulyak
Copy link
Contributor

@dshulyak dshulyak commented Nov 9, 2023

on close empty value will be emitted, this commit checks that and exit if channel was closed

@dshulyak dshulyak requested review from fasmat and poszu as code owners November 9, 2023 08:54
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #5247 (80d9e2a) into develop (a66b274) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           develop   #5247     +/-   ##
=========================================
- Coverage     78.1%   78.0%   -0.1%     
=========================================
  Files          266     266             
  Lines        31943   31949      +6     
=========================================
- Hits         24953   24933     -20     
- Misses        5481    5503     +22     
- Partials      1509    1513      +4     
Files Coverage Δ
hare3/compat/result.go 53.8% <100.0%> (-6.2%) ⬇️
hare3/compat/weakcoin.go 43.7% <100.0%> (-33.2%) ⬇️

... and 7 files with indirect coverage changes

@dshulyak
Copy link
Contributor Author

dshulyak commented Nov 9, 2023

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Nov 9, 2023
on close empty value will be emitted, this commit checks that and exit if channel was closed
@spacemesh-bors
Copy link

spacemesh-bors bot commented Nov 9, 2023

Build failed (retrying...):

spacemesh-bors bot pushed a commit that referenced this pull request Nov 9, 2023
on close empty value will be emitted, this commit checks that and exit if channel was closed
@spacemesh-bors
Copy link

spacemesh-bors bot commented Nov 9, 2023

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title hare3/compat: exit if hare channel got closed [Merged by Bors] - hare3/compat: exit if hare channel got closed Nov 9, 2023
@spacemesh-bors spacemesh-bors bot closed this Nov 9, 2023
dshulyak added a commit that referenced this pull request Nov 9, 2023
on close empty value will be emitted, this commit checks that and exit if channel was closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants