[Merged by Bors] - sync, cache: update sync atxs limits and increase cache size again #5264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshulyak
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5264 +/- ##
=======================================
Coverage 78.0% 78.0%
=======================================
Files 266 266
Lines 31977 31977
=======================================
+ Hits 24964 24965 +1
+ Misses 5499 5498 -1
Partials 1514 1514 ☔ View full report in Codecov by Sentry. |
fasmat
approved these changes
Nov 14, 2023
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Nov 14, 2023
…5264) long term solution for sync protocol limits is to refactor code to use stream and enforce limits in a way that doesn't require re-compilation (spacemeshos/pm#272). for cache size, we will soon switch to smarter cache in atxsdata module, but until then we have to keep all atxs in memory.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
dshulyak
added a commit
that referenced
this pull request
Nov 15, 2023
…5264) long term solution for sync protocol limits is to refactor code to use stream and enforce limits in a way that doesn't require re-compilation (spacemeshos/pm#272). for cache size, we will soon switch to smarter cache in atxsdata module, but until then we have to keep all atxs in memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
long term solution for sync protocol limits is to refactor code to use stream and enforce limits in a way that doesn't require re-compilation (spacemeshos/pm#272).
for cache size, we will soon switch to smarter cache in atxsdata module, but until then we have to keep all atxs in memory.