[Merged by Bors] - node: Remove option to configure services per endpoint

[fasmat]

Motivation

Part of #5267
Closes #5260

This changes the node configuration to not allow an operator to decide any more which GRPC handlers are exposed on which endpoint. Instead it hard codes the following:

• public: GlobalState, Mesh, Transaction, Node, Activation
• private: Admin, Debug, Smesher, Post
• mTLS: Post

Additionally it removes all configuration options for the PoST service and sets them automatically if the node is started with smeshing-start=true via the command line or via the config.

Changes

• remove ability to set which handlers are available on which endpoint and hardcode them instead
• remove workaround code added in [Merged by Bors] - Extend README and check config for inconsistencies with supervised PoST service #5259 that was necessary when the operator could still configure the supervised post service
  • supervised post service binary is now always expected to be in the same directory as the node binary
  • the supervised post service is now instructed to always connect to the node via the private listener
  • remote post services can connect via the TLS listener

Test Plan

updated existing tests

TODO

• Explain motivation or link existing issue(s)
• Test changes and document test plan
• Update documentation as needed
• Update changelog as needed

[dshulyak]

public: Debug, GlobalState, Mesh, Transaction, Node, Activation

in reality none of them can be exposed on internet facing public address.

[fasmat]

in reality none of them can be exposed on internet facing public address.

I wanted to avoid breaking backwards compatibility. At the moment they are all exposed by default. How do you suggest to proceed?

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (785cf12) 77.5% compared to head (e2d4da5) 77.6%.

Files	Patch %	Lines
node/node.go	90.0%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #5276   +/-   ##
=======================================
  Coverage     77.5%   77.6%           
=======================================
  Files          251     251           
  Lines        29494   29477   -17     
=======================================
+ Hits         22873   22878    +5     
+ Misses        5172    5155   -17     
+ Partials      1449    1444    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dshulyak]

I wanted to avoid breaking backwards compatibility. At the moment they are all exposed by default. How do you suggest to proceed?

i don't know honestly. any solution seems sketchy. i don't mind doing what you suggested if it works for smapp.
maybe remove Debug from public to private though?

[fasmat]

bors try

[spacemesh-bors]

try

Build failed:

• systest-status

[fasmat]

bors try

[spacemesh-bors]

try

Build failed:

• systest-status

[fasmat]

bors try

[spacemesh-bors]

try

Build succeeded:

• ci-status
• systest-status

[fasmat]

bors merge

[spacemesh-bors]

Pull request successfully merged into develop.

Build succeeded:

• systest-status
• ci-status