[Merged by Bors] - parametrize gossip sub queue and validation parameters #5291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5291 +/- ##
========================================
Coverage 77.5% 77.5%
========================================
Files 253 251 -2
Lines 29632 29479 -153
========================================
- Hits 22966 22872 -94
+ Misses 5204 5162 -42
+ Partials 1462 1445 -17 ☔ View full report in Codecov by Sentry. |
dshulyak
changed the title
|
bors try |
tryBuild failed: |
|
bors try |
fasmat
approved these changes
Nov 24, 2023
tryBuild succeeded: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
added 3 new metrics:
- spacemesh_p2p_queue_full{"protocol"}
counter for number of dropped messages due to inbox queue being full.
- spacemesh_p2p_throttled{"protocol"}
counter for number of dropped messages due to gossipsub global or per topic throttling
- spacemesh_p2p_rejected{"protocol"}
dropped messages for any other reason, such as validation didn't pass
and 3 new parameters in p2p section:
```json
{
"gossip-queue-size": 10000,
"gossip-validation-throttle": 10000,
"gossip-atx-validation-throttle": 10000
}
```
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
dshulyak
added a commit
that referenced
this pull request
Nov 24, 2023
added 3 new metrics:
- spacemesh_p2p_queue_full{"protocol"}
counter for number of dropped messages due to inbox queue being full.
- spacemesh_p2p_throttled{"protocol"}
counter for number of dropped messages due to gossipsub global or per topic throttling
- spacemesh_p2p_rejected{"protocol"}
dropped messages for any other reason, such as validation didn't pass
and 3 new parameters in p2p section:
```json
{
"gossip-queue-size": 10000,
"gossip-validation-throttle": 10000,
"gossip-atx-validation-throttle": 10000
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added 3 new metrics:
counter for number of dropped messages due to inbox queue being full.
counter for number of dropped messages due to gossipsub global or per topic throttling
dropped messages for any other reason, such as validation didn't pass
and 3 new parameters in p2p section:
{ "gossip-queue-size": 10000, "gossip-validation-throttle": 10000, "gossip-atx-validation-throttle": 10000 }