[Merged by Bors] - Revert part of #5339 #5340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pigmej
approved these changes
Dec 11, 2023
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
## Motivation Reverts part of #5339 ## Changes `PutUvarint` from standard library and `github.com/multiformats/go-varint` do not behave exactly the same. With Go 1.20 to the stdlib implementation was fixed to detect short reads, but in contrast to `github.com/multiformats/go-varint` it will still not return an error when decoding non-minimal encodings of integers. ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5340 +/- ##
=========================================
- Coverage 77.5% 77.5% -0.1%
=========================================
Files 252 252
Lines 29651 29651
=========================================
- Hits 22987 22985 -2
- Misses 5207 5208 +1
- Partials 1457 1458 +1 ☔ View full report in Codecov by Sentry. |
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
fasmat
added a commit
that referenced
this pull request
Dec 11, 2023
Reverts part of #5339 `PutUvarint` from standard library and `github.com/multiformats/go-varint` do not behave exactly the same. With Go 1.20 to the stdlib implementation was fixed to detect short reads, but in contrast to `github.com/multiformats/go-varint` it will still not return an error when decoding non-minimal encodings of integers. n/a <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
lrettig
pushed a commit
that referenced
this pull request
Dec 14, 2023
## Motivation Reverts part of #5339 ## Changes `PutUvarint` from standard library and `github.com/multiformats/go-varint` do not behave exactly the same. With Go 1.20 to the stdlib implementation was fixed to detect short reads, but in contrast to `github.com/multiformats/go-varint` it will still not return an error when decoding non-minimal encodings of integers. ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
dsmello
pushed a commit
that referenced
this pull request
Dec 28, 2023
## Motivation Reverts part of #5339 ## Changes `PutUvarint` from standard library and `github.com/multiformats/go-varint` do not behave exactly the same. With Go 1.20 to the stdlib implementation was fixed to detect short reads, but in contrast to `github.com/multiformats/go-varint` it will still not return an error when decoding non-minimal encodings of integers. ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Reverts part of #5339
Changes
PutUvarintfrom standard library andjackfan.us.kg/multiformats/go-varintdo not behave exactly the same. With Go 1.20 to the stdlib implementation was fixed to detect short reads, but in contrast tojackfan.us.kg/multiformats/go-varintit will still not return an error when decoding non-minimal encodings of integers.Test Plan
n/a
TODO