[backport] avoid processing same ATX in parallel (#5379) #5382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Motivation There is no mechanism preventing duplicated processing of ATX in parallel. An ATX might be gossiped multiple times while the same one is already being processed. Related issue: #4426 ## Changes The ATX handler now registers the ATXID when it starts processing it. The subsequent calls to `handleATX()` will find that the handler is already processing this ATX and will register themself for the result, which is sent over a channel after the ATX processing is finished. ## Test Plan Added a UT in which an ATX is gossiped 10x in parallel. The expectation is that it's processed only once.
fasmat
approved these changes
Dec 20, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v1.2 #5382 +/- ##
=======================================
- Coverage 77.6% 77.5% -0.1%
=======================================
Files 256 256
Lines 30478 30506 +28
=======================================
+ Hits 23659 23672 +13
- Misses 5334 5351 +17
+ Partials 1485 1483 -2 ☔ View full report in Codecov by Sentry. |
poszu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #5379