[Merged by Bors] - Wait for ATX-synced before selecting commitment ATX #5423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #5423 +/- ##
=======================================
Coverage 77.4% 77.4%
=======================================
Files 265 265
Lines 30880 30890 +10
=======================================
+ Hits 23929 23937 +8
- Misses 5430 5432 +2
Partials 1521 1521 ☔ View full report in Codecov by Sentry. |
fasmat
reviewed
Jan 10, 2024
fasmat
approved these changes
Jan 11, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
## Motivation We need to wait to be ATX-synced before selecting a commitment ATX to select the best possible one. ## Changes - moved waiting for ATX-synced to the function that finds the best ATX for commitment ATX - post supervisor doesn't always wait for ATX-synced before it starts post-service ## Test Plan Existing tests pass
|
Build failed (retrying...):
|
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
## Motivation We need to wait to be ATX-synced before selecting a commitment ATX to select the best possible one. ## Changes - moved waiting for ATX-synced to the function that finds the best ATX for commitment ATX - post supervisor doesn't always wait for ATX-synced before it starts post-service ## Test Plan Existing tests pass
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
spacemesh-bors
bot
deleted the
wait-for-atx-sync-before-selecting-commitment-atx
branch
poszu
added a commit
that referenced
this pull request
Jan 16, 2024
## Motivation We need to wait to be ATX-synced before selecting a commitment ATX to select the best possible one. ## Changes - moved waiting for ATX-synced to the function that finds the best ATX for commitment ATX - post supervisor doesn't always wait for ATX-synced before it starts post-service ## Test Plan Existing tests pass
poszu
added a commit
that referenced
this pull request
Jan 17, 2024
## Motivation We need to wait to be ATX-synced before selecting a commitment ATX to select the best possible one. ## Changes - moved waiting for ATX-synced to the function that finds the best ATX for commitment ATX - post supervisor doesn't always wait for ATX-synced before it starts post-service ## Test Plan Existing tests pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to wait to be ATX-synced before selecting a commitment ATX to select the best possible one.
Changes
Test Plan
Existing tests pass