[Merged by Bors] - fetch: make request timeout configurable #5464
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #5464 +/- ##
=========================================
- Coverage 77.7% 77.7% -0.1%
=========================================
Files 267 267
Lines 30901 30901
=========================================
- Hits 24019 24016 -3
- Misses 5369 5371 +2
- Partials 1513 1514 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
The RequestTimeout is already configurable. Specifying the tag is optional: https://pkg.go.dev/github.com/mitchellh/mapstructure#hdr-Field_Tags
When decoding to a struct, mapstructure will use the field name by default to perform the mapping.
(...)
You can change the behavior of mapstructure by using struct tags. The default struct tag that mapstructure looks for is "mapstructure" (...)
The "default tag" for this field is requestTimeout.
|
bors merge |
## Motivation After merging #5462, it might make sense to try and reduce request timeout, as the deadlines will no longer be hit due to long transfers ## Changes Add `request-timeout` key to the `fetch` config. Also, fix a typo
|
Build failed: |
|
bors merge |
## Motivation After merging #5462, it might make sense to try and reduce request timeout, as the deadlines will no longer be hit due to long transfers ## Changes Add `request-timeout` key to the `fetch` config. Also, fix a typo
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
After merging #5462, it might make sense to try and reduce request timeout, as the deadlines will no longer be hit due to long transfers Add `request-timeout` key to the `fetch` config. Also, fix a typo
Motivation
After merging #5462, it might make sense to try and reduce request timeout, as the deadlines will no longer be hit due to long transfers
Changes
Add
request-timeoutkey to thefetchconfig. Also, fix a typo