[Merged by Bors] - Make routing discovery more configurable and less spammy by default #5494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `discovery-timings` section in the p2p config for tuning routing discovery intervals and timeouts. Less spammy defaults: * only start advertising after 1h of uptime (but still start discovering the peers behind NAT immediately) * use 1h TTL / re-advertise interval * use 1m interval for discovery / advertisement retries
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #5494 +/- ##
=======================================
Coverage 77.6% 77.6%
=======================================
Files 267 267
Lines 31068 31095 +27
=======================================
+ Hits 24119 24142 +23
- Misses 5420 5424 +4
Partials 1529 1529 ☔ View full report in Codecov by Sentry. |
poszu
approved these changes
Jan 25, 2024
Co-authored-by: Bartosz Różański <[email protected]>
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
…5494) ## Motivation Enabling routing discovery advertisement causes too much of kad (DHT) traffic on the nodes with DHT server mode enabled (public IP) Co-authored-by: Ivan Shvedunov <[email protected]>
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
…5494) ## Motivation Enabling routing discovery advertisement causes too much of kad (DHT) traffic on the nodes with DHT server mode enabled (public IP) Co-authored-by: Ivan Shvedunov <[email protected]>
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
ivan4th
added a commit
that referenced
this pull request
Jan 25, 2024
…5494) Enabling routing discovery advertisement causes too much of kad (DHT) traffic on the nodes with DHT server mode enabled (public IP) Co-authored-by: Ivan Shvedunov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Enabling routing discovery advertisement causes too much of kad (DHT) traffic on the nodes with DHT server mode enabled (public IP)
Description
Add
discovery-timingssection in the p2p config for tuning routing discovery intervals and timeouts.Less spammy defaults:
Test Plan
Tested by running a node on mainnet and observing discovery of other peers