[Merged by Bors] - Adjust to 2.2M ATXs #5571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Epoch 14 had ~1.1M ATXs. Strongest epoch-over-epoch growth in the past epochs was ~90%. This change adjusts ATX limits to handle another 90% growth (with some wiggle room) in the current epoch. Details: Increase EpochData and EpochActiveSet wire types to accommodate up to 2.2M ATXs. Increase fetcher data size limit to 85MiB, to adjust for these wire types. Increase the ATX cache to 4.4M, per the 2*EpochData guideline. Add a comment to hint at the necessity of adjusting ResponseMessage size when adjusting EpochData size. Also, fix a comment typo misleading about the ATX ID size.
xearl4
requested review from
dshulyak,
fasmat,
poszu and
ivan4th
as code owners
dshulyak
approved these changes
Feb 14, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 14, 2024
## Motivation Current limits allow for 1.5M ATXs. This leaves room for a ~36% increase over the previous epoch. Growth in the current epoch may exceed this, so prepare for that chance and increase the limits. (I realise that this change _may_ be obsolete with upcoming changes to sync. It may be helpful to merge and backport this change to a 1.3.x release early anyway, just in the sync changes either won't obsolete the ATX limit increase or the sync changes don't become ready in time for the next CG.)
|
Build failed:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5571 +/- ##
=========================================
- Coverage 79.7% 79.7% -0.1%
=========================================
Files 267 267
Lines 26833 26857 +24
=========================================
+ Hits 21403 21420 +17
- Misses 3913 3917 +4
- Partials 1517 1520 +3 ☔ View full report in Codecov by Sentry. |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 14, 2024
## Motivation Current limits allow for 1.5M ATXs. This leaves room for a ~36% increase over the previous epoch. Growth in the current epoch may exceed this, so prepare for that chance and increase the limits. (I realise that this change _may_ be obsolete with upcoming changes to sync. It may be helpful to merge and backport this change to a 1.3.x release early anyway, just in the sync changes either won't obsolete the ATX limit increase or the sync changes don't become ready in time for the next CG.)
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 14, 2024
## Motivation Current limits allow for 1.5M ATXs. This leaves room for a ~36% increase over the previous epoch. Growth in the current epoch may exceed this, so prepare for that chance and increase the limits. (I realise that this change _may_ be obsolete with upcoming changes to sync. It may be helpful to merge and backport this change to a 1.3.x release early anyway, just in the sync changes either won't obsolete the ATX limit increase or the sync changes don't become ready in time for the next CG.)
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
pigmej
pushed a commit
that referenced
this pull request
Feb 15, 2024
Current limits allow for 1.5M ATXs. This leaves room for a ~36% increase over the previous epoch. Growth in the current epoch may exceed this, so prepare for that chance and increase the limits. (I realise that this change _may_ be obsolete with upcoming changes to sync. It may be helpful to merge and backport this change to a 1.3.x release early anyway, just in the sync changes either won't obsolete the ATX limit increase or the sync changes don't become ready in time for the next CG.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Current limits allow for 1.5M ATXs. This leaves room for a ~36% increase over the previous epoch. Growth in the current epoch may exceed this, so prepare for that chance and increase the limits.
(I realise that this change may be obsolete with upcoming changes to sync. It may be helpful to merge and backport this change to a 1.3.x release early anyway, just in the sync changes either won't obsolete the ATX limit increase or the sync changes don't become ready in time for the next CG.)
Description
Epoch 14 had ~1.1M ATXs. The strongest epoch-over-epoch growth in the past epochs was ~90%. This change adjusts ATX limits to handle another 90% growth (with some wiggle room) in the current epoch.
Details: Increase EpochData and EpochActiveSet wire types to accommodate up to 2.2M ATXs. Increase fetcher data size limit to 85MiB, to adjust for these wire types. Increase the ATX cache to 4.4M, per the 2*EpochData guideline.
Add a comment to hint at the necessity of adjusting ResponseMessage size when adjusting EpochData size.
Also, fix a comment typo misleading about the ATX ID size.