[Merged by Bors] - Do not try to sync over transient connections #5603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transient connections are relayed connections which should only be used for hole punching. Testing this change is possible in theory, but it's a little too involved compared to the change itself as it requires starting a relay host, obtaining a reservation with it, etc.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5603 +/- ##
=======================================
Coverage 79.7% 79.7%
=======================================
Files 270 270
Lines 27225 27231 +6
=======================================
+ Hits 21708 21721 +13
+ Misses 3971 3964 -7
Partials 1546 1546 ☔ View full report in Codecov by Sentry. |
dshulyak
approved these changes
Feb 26, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
## Motivation Transient connections are relayed connections which should only be used for hole punching. Trying to sync over them never succeeds due to resource limits, etc.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
ivan4th
added a commit
that referenced
this pull request
Feb 28, 2024
## Motivation Transient connections are relayed connections which should only be used for hole punching. Trying to sync over them never succeeds due to resource limits, etc.
ivan4th
added a commit
that referenced
this pull request
Feb 29, 2024
Backport #5603: Do not try to sync over transient connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Transient connections are relayed connections which should only be used for hole punching. Trying to sync over them never succeeds due to resource limits, etc.
Description
Do not try to use transient connections for sync.
Test Plan
Verified by syncing a node with routing discovery and relay enabled, so that hole punching is happening continuously and there are always some temporary relayed connections.
Writing a proper test case for this change is possible in theory, but it's a little too involved compared to the change itself as it requires starting a relay host, obtaining a reservation with it, etc.