-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Update mockgen to the same version as go-mock dependency #5604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
changed the title
Update mockgen
Update mockgen to the same version as go-mock dependency
Feb 26, 2024
poszu
approved these changes
Feb 26, 2024
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
## Motivation `go-mock` has been updated a while ago. When the dependency was updated we forgot to also update `mockgen`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5604 +/- ##
=========================================
- Coverage 79.7% 79.7% -0.1%
=========================================
Files 270 270
Lines 27229 27229
=========================================
- Hits 21719 21708 -11
- Misses 3965 3974 +9
- Partials 1545 1547 +2 ☔ View full report in Codecov by Sentry. |
Build failed: |
random flake. bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
## Motivation `go-mock` has been updated a while ago. When the dependency was updated we forgot to also update `mockgen`
Build failed: |
flaky tests bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
## Motivation `go-mock` has been updated a while ago. When the dependency was updated we forgot to also update `mockgen`
Canceled. |
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
## Motivation `go-mock` has been updated a while ago. When the dependency was updated we forgot to also update `mockgen`
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Update mockgen to the same version as go-mock dependency
[Merged by Bors] - Update mockgen to the same version as go-mock dependency
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
go-mock
has been updated a while ago. When the dependency was updated we forgot to also updatemockgen
Description
Update of
mockgen
and one run ofmake generate
Test Plan
n/a
TODO