Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Update mockgen to the same version as go-mock dependency #5604

Closed
wants to merge 3 commits into from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Feb 26, 2024

Motivation

go-mock has been updated a while ago. When the dependency was updated we forgot to also update mockgen

Description

Update of mockgen and one run of make generate

Test Plan

n/a

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat self-assigned this Feb 26, 2024
@fasmat fasmat changed the title Update mockgen Update mockgen to the same version as go-mock dependency Feb 26, 2024
@fasmat
Copy link
Member Author

fasmat commented Feb 26, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Feb 26, 2024
## Motivation

`go-mock` has been updated a while ago. When the dependency was updated we forgot to also update `mockgen`
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.7%. Comparing base (15f8c31) to head (f349e14).

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #5604     +/-   ##
=========================================
- Coverage     79.7%   79.7%   -0.1%     
=========================================
  Files          270     270             
  Lines        27229   27229             
=========================================
- Hits         21719   21708     -11     
- Misses        3965    3974      +9     
- Partials      1545    1547      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spacemesh-bors
Copy link

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Feb 26, 2024

random flake.

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Feb 26, 2024
## Motivation

`go-mock` has been updated a while ago. When the dependency was updated we forgot to also update `mockgen`
@spacemesh-bors
Copy link

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Feb 26, 2024

flaky tests

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Feb 26, 2024
## Motivation

`go-mock` has been updated a while ago. When the dependency was updated we forgot to also update `mockgen`
@spacemesh-bors
Copy link

Canceled.

@fasmat
Copy link
Member Author

fasmat commented Feb 26, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Feb 26, 2024
## Motivation

`go-mock` has been updated a while ago. When the dependency was updated we forgot to also update `mockgen`
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Update mockgen to the same version as go-mock dependency [Merged by Bors] - Update mockgen to the same version as go-mock dependency Feb 26, 2024
@spacemesh-bors spacemesh-bors bot closed this Feb 26, 2024
@spacemesh-bors spacemesh-bors bot deleted the update-mockgen branch February 26, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants