[Merged by Bors] - Update size of Ballot #5619
Closed
+77
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
force-pushed
the
increase-ballot-size
branch
from
ff1a415 to
db573da
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5619 +/- ##
=========================================
- Coverage 79.8% 79.8% -0.1%
=========================================
Files 271 271
Lines 27347 27346 -1
=========================================
- Hits 21842 21841 -1
- Misses 3972 3973 +1
+ Partials 1533 1532 -1 ☔ View full report in Codecov by Sentry. |
fasmat
force-pushed
the
increase-ballot-size
branch
from
db573da to
a9af7e0
Compare
fasmat
force-pushed
the
increase-ballot-size
branch
from
7897095 to
997c608
Compare
dshulyak
reviewed
Feb 29, 2024
| // | ||
| // Assuming the largest smesher won't control more than 10% of space in the network, we can assume that the | ||
| // highest number of eligibilities in a single ballot will be below 25000. (10% of 4032 * 50 = 20160) | ||
| EligibilityProofs []VotingEligibility `scale:"max=25000"` |
There was a problem hiding this comment.
we are not concerned about number of eligibility proofs for a single identity.
instead number of identities will grow, and therefore number of proposals/ballots. so we have to update collections that references proposals/ballots per layer.
- hare preround message
- LayerData for sync
- number of rewards in the block
There was a problem hiding this comment.
I checked those and updated the maximum allowed number for each of them.
dshulyak
approved these changes
Feb 29, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 29, 2024
## Motivation This updates max scale collection sizes to support a network with up to 2.2 mio unique (valid) identities.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
fasmat
added a commit
that referenced
this pull request
Feb 29, 2024
## Motivation This updates max scale collection sizes to support a network with up to 2.2 mio unique (valid) identities.
4 tasks
fasmat
added a commit
that referenced
this pull request
Feb 29, 2024
## Motivation This updates max scale collection sizes to support a network with up to 2.2 mio unique (valid) identities.
fasmat
added a commit
that referenced
this pull request
Feb 29, 2024
## Motivation This updates max scale collection sizes to support a network with up to 2.2 mio unique (valid) identities.
fasmat
added a commit
that referenced
this pull request
Feb 29, 2024
* Update size of Ballot (#5619) ## Motivation This updates max scale collection sizes to support a network with up to 2.2 mio unique (valid) identities. * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This updates max scale collection sizes to support a network with up to 2.2 mio unique (valid) identities.
Description
EligibilityProofsinBallotis misleading. Additionally the current maximum size is too small when ATX merging will be introduced. The new limit is based on the same assumption that no single identity will control more than 10% of the networks PoST size. See the added comment for details.Rewardsin aBlock,Ballotsin aLayerandProposalsfor a hare message all depend on the total number of ATXs that are valid for a given epoch. Since those are probabilistic (randomly distributed) I calculated the expected value with a 6 sigma (99.997%) safety margin and used this as new maximum for the collection. For 2.2 mio ATXs that turned out to be ~ 743 so I chose 800.Test Plan
n/a
TODO