Backport #5586: Do not try to publish proofs for malicious ATXs during sync #5622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.3 #5622 +/- ##
=======================================
+ Coverage 77.3% 77.4% +0.1%
=======================================
Files 261 261
Lines 30929 30769 -160
=======================================
- Hits 23932 23844 -88
+ Misses 5494 5437 -57
+ Partials 1503 1488 -15 ☔ View full report in Codecov by Sentry. |
poszu
approved these changes
Feb 29, 2024
|
Possible test flake: Re-running CI |
|
@pigmej @andres-spacemesh that seems to be the same error that I had with one of the mac runners some time ago as well. |
ivan4th
force-pushed
the
backport-5586
branch
from
7c58c94 to
b02561a
Compare
## Motivation The `requester::Request(...)` interface from the `fetch` package seems unnecessarily complicated with its callback methods. It can be made blocking instead, simplifying the code using this interface. ## Changes - make `fetch::requester::Request(...)` blocking and remove the callbacks. It returns the result directly now, - make `GetMaliciousIDs`, `GetLayerData` and `GetLayerOpinions` from `syncer::fetcher` interface blocking, - remove `fetch::poll(...)` - refactor the code and tests to use the new approach ## Test Plan existing tests pass
Publishing is blocked during sync because `Syncer::ListenToATXGossip()` returns false, and thus every malicious ATX being synced is causing an error resulting in an interruption of sync.
ivan4th
force-pushed
the
backport-5586
branch
from
b02561a to
140efcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Backport #5586 and also #5453 as a prerequisite