[Merged by Bors] - sql: fix epoch ATX ID cache deadlock #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
approved these changes
Mar 19, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
## Motivation SQL query cache deadlocks b/c during transactions, SQLite lock is held while cache update lock is being acquired.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5738 +/- ##
=======================================
Coverage 80.0% 80.0%
=======================================
Files 279 279
Lines 29046 29048 +2
=======================================
+ Hits 23265 23267 +2
- Misses 4183 4184 +1
+ Partials 1598 1597 -1 ☔ View full report in Codecov by Sentry. |
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
SQL query cache deadlocks b/c during transactions, SQLite lock is held while cache update lock is being acquired.
Description
Fixes the deadlock by bringing cached slice update out of the transactions.
Test Plan
Verified on mainnet