Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - dont interrupt sync if ballots in the layer were ignored or rejected #5761

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - dont interrupt sync if ballots in the layer were ignored or rejected #5761

wants to merge 5 commits into from

Conversation

dshulyak
Copy link
Contributor

related: #5701

in the implementation sync loop will repeatedly asks for objects even if it can't process them.
in this pr we allow sync to make progress if the remaining objects in the layer can't be processed with retries.

@dshulyak dshulyak mentioned this pull request Mar 22, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 80.2%. Comparing base (da627d2) to head (181edd6).
Report is 1 commits behind head on develop.

Files Patch % Lines
syncer/syncer.go 66.6% 1 Missing and 2 partials ⚠️
fetch/mesh_data.go 84.6% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           develop   #5761   +/-   ##
=======================================
  Coverage     80.1%   80.2%           
=======================================
  Files          282     282           
  Lines        29321   29351   +30     
=======================================
+ Hits         23515   23540   +25     
- Misses        4188    4190    +2     
- Partials      1618    1621    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dshulyak
Copy link
Contributor Author

bors merge

@dshulyak
Copy link
Contributor Author

bors cancel

@spacemesh-bors
Copy link

Canceled.

@dshulyak
Copy link
Contributor Author

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Mar 22, 2024
@dshulyak
dont interrupt sync if ballots in the layer were ignored or rejected (#…
776f66c 
…5761)

related: #5701

in the implementation sync loop will repeatedly asks for objects even if it can't process them.
in this pr we allow sync to make progress if the remaining objects in the layer can't be processed with retries.
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title dont interrupt sync if ballots in the layer were ignored or rejected [Merged by Bors] - dont interrupt sync if ballots in the layer were ignored or rejected Mar 22, 2024
@spacemesh-bors spacemesh-bors bot closed this Mar 22, 2024
@spacemesh-bors spacemesh-bors bot deleted the sync-layers-without-being-stuck branch March 22, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fasmat fasmat fasmat approved these changes

@poszu poszu Awaiting requested review from poszu poszu is a code owner

@ivan4th ivan4th Awaiting requested review from ivan4th ivan4th is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dshulyak @fasmat