[Merged by Bors] - increase tortoise window for past layers on mainnet #5762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
approved these changes
Mar 22, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
closes: #5659 in order to decode ballots while syncing layers before 30_000 window needs to be set to 10_000 (this is what this value was originally). otherwise many ballots can't be decoded as they reference base ballots outside of 4032 window. this breaks the chain of votes and make tortoise unable to cross necessary weight. this change introduces HistoricalWindowSize parameter in tortoise, that sets window size to 10_000 for layers before 30_000. it also removes eviction logic from atxsdata and moves it inside tortoise, so that we don't have to have similar conditionals in more than 1 place.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5659
in order to decode ballots while syncing layers before 30_000 window needs to be set to 10_000 (this is what this value was originally). otherwise many ballots can't be decoded as they reference base ballots outside of 4032 window. this breaks the chain of votes and make tortoise unable to cross necessary weight.
this change introduces HistoricalWindowSize parameter in tortoise, that sets window size to 10_000 for layers before 30_000.
it also removes eviction logic from atxsdata and moves it inside tortoise, so that we don't have to have similar conditionals in more than 1 place.