Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Improve logging in ATX Builder #5797

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Improve logging in ATX Builder #5797

wants to merge 4 commits into from
+32 −16

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Apr 3, 2024 •
edited
Loading

Motivation

Added logs around building a NiPoST challenge to understand its progress better.

Description

Test Plan

n/a

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@codecov Codecov
Copy link

codecov bot commented Apr 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.2%. Comparing base (455f0de) to head (6fe2152).

❗ Current head 6fe2152 differs from pull request most recent head dbefe01. Consider uploading reports for the commit dbefe01 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           develop   #5797   +/-   ##
=======================================
  Coverage     80.2%   80.2%           
=======================================
  Files          285     285           
  Lines        29738   29747    +9     
=======================================
+ Hits         23850   23878   +28     
+ Misses        4242    4221   -21     
- Partials      1646    1648    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poszu poszu force-pushed the improve-logging-around-building-nipost-challenge branch from 9067d5a to 6fe2152 Compare April 3, 2024 14:36
@fasmat
Copy link
Member

fasmat commented Apr 3, 2024

btw. I have a similar PR here: #5798

@poszu
Copy link
Contributor Author

poszu commented Apr 3, 2024

btw. I have a similar PR here: #5798

How about merging changes from it to this PR to avoid running ci twice?

@fasmat
Copy link
Member

fasmat commented Apr 3, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Apr 3, 2024
@poszu @fasmat
Improve logging in ATX Builder (#5797)
eb7d957 
## Motivation

Added logs around building a NiPoST challenge to understand its progress better.



Co-authored-by: Matthias <[email protected]>
@fasmat
Copy link
Member

fasmat commented Apr 3, 2024

How about merging changes from it to this PR to avoid running ci twice?

cherry-picked the commit

@fasmat fasmat mentioned this pull request Apr 3, 2024
Closed
4 tasks
@spacemesh-bors
Copy link

spacemesh-bors bot commented Apr 3, 2024

Build failed:

@poszu
Copy link
Contributor Author

poszu commented Apr 4, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Apr 4, 2024
@poszu @fasmat
Improve logging in ATX Builder (#5797)
e0c7444 
## Motivation

Added logs around building a NiPoST challenge to understand its progress better.



Co-authored-by: Matthias <[email protected]>
@spacemesh-bors
Copy link

spacemesh-bors bot commented Apr 4, 2024

This PR was included in a batch that was canceled, it will be automatically retried

spacemesh-bors bot pushed a commit that referenced this pull request Apr 4, 2024
@poszu @fasmat
Improve logging in ATX Builder (#5797)
ce0c1ca 
## Motivation

Added logs around building a NiPoST challenge to understand its progress better.



Co-authored-by: Matthias <[email protected]>
@spacemesh-bors
Copy link

spacemesh-bors bot commented Apr 4, 2024

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Improve logging in ATX Builder [Merged by Bors] - Improve logging in ATX Builder Apr 4, 2024
@spacemesh-bors spacemesh-bors bot closed this Apr 4, 2024
@spacemesh-bors spacemesh-bors bot deleted the improve-logging-around-building-nipost-challenge branch April 4, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fasmat fasmat fasmat approved these changes

@dshulyak dshulyak Awaiting requested review from dshulyak dshulyak is a code owner

@ivan4th ivan4th Awaiting requested review from ivan4th ivan4th is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poszu @fasmat