[Merged by Bors] - Implement SMIP-0002: Remove vesting vault cliff #5807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lrettig imo we definitely need changelog mention here too. |
|
Yup will do!
…On Sat, Apr 6, 2024 at 00:29 Jędrzej Nowak ***@***.***> wrote:
@lrettig <https://github.com/lrettig> imo we definitely need changelog
mention here too.
—
Reply to this email directly, view it on GitHub
<#5807 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZJWNGK3DB67E56RTVUW53Y36P4NAVCNFSM6AAAAABFZ4JOECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGAYDENZUGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
dshulyak
approved these changes
Apr 8, 2024
lrettig
force-pushed
the
smip-0002-remove-vault-vesting-cliff
branch
from
fabb4a9 to
e432a24
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5807 +/- ##
=======================================
Coverage 80.3% 80.4%
=======================================
Files 283 283
Lines 29320 29282 -38
=======================================
- Hits 23568 23561 -7
+ Misses 4156 4130 -26
+ Partials 1596 1591 -5 ☔ View full report in Codecov by Sentry. |
|
@dshulyak would you mind taking one more look? Thanks! |
2 tasks
lrettig
force-pushed
the
smip-0002-remove-vault-vesting-cliff
branch
from
d30fb51 to
f548c64
Compare
fasmat
approved these changes
Apr 10, 2024
dshulyak
approved these changes
Apr 10, 2024
lrettig
force-pushed
the
smip-0002-remove-vault-vesting-cliff
branch
from
f548c64 to
f97a897
Compare
Ignore InitialUnlockAmount vault argument. Update tests accordingly, including a regression test.
Need to give vesting addr a little more gas so it can make one additional drain tx, since the first one fails. Make tx success/failure more explicit.
lrettig
force-pushed
the
smip-0002-remove-vault-vesting-cliff
branch
from
f97a897 to
5d676db
Compare
|
bors merge |
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See https://github.com/smfoundation/smips/blob/main/proposals/smip-0002-remove-vault-vesting-clff.md
See also spacemeshos/economics#40
Description
Removes vesting cliff for vesting vault
Test Plan
No new tests required. Updates existing tests.
TODO