Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix verifying ATX chain containing a checkpointed ATX #5877

Closed
wants to merge 2 commits into from

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Apr 24, 2024

Motivation

All ATXs in the checkpoint are considered to be valid and don't require checking POST.

Description

Because a checkpointed ATX doesn't have a blob in the database - it's not possible to obtain its PoST.

Test Plan

Added a unit test for the fixed scenario.

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

activation/validation.go Show resolved Hide resolved
@poszu
Copy link
Contributor Author

poszu commented Apr 25, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Apr 25, 2024
## Motivation

All ATXs in the checkpoint are considered to be valid and don't require checking POST.
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Fix verifying ATX chain containing a checkpointed ATX [Merged by Bors] - Fix verifying ATX chain containing a checkpointed ATX Apr 25, 2024
@spacemesh-bors spacemesh-bors bot closed this Apr 25, 2024
@spacemesh-bors spacemesh-bors bot deleted the fix/verify-atx-chain-after-checkpoint branch April 25, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants