[Merged by Bors] - p2p: handle discovery startup errors properly #5888
+46
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5888 +/- ##
=========================================
- Coverage 80.6% 80.6% -0.1%
=========================================
Files 285 285
Lines 29512 29521 +9
=========================================
Hits 23801 23801
- Misses 4122 4128 +6
- Partials 1589 1592 +3 ☔ View full report in Codecov by Sentry. |
poszu
approved these changes
Apr 26, 2024
Co-authored-by: Bartosz Różański <[email protected]>
|
bors merge |
|
Merge conflict. |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
## Motivation There was no error checking for DHT discovery startup, yet it could fail e.g. during LevelDB corruption: ``` Error: init services: error starting discovery: open leveldb at /opt/go-spacemesh/go-spacemesh-0/p2p: leveldb/journal: block/chunk corrupted: chunk length overflows block (1270 bytes) [file=000247.log] ``` In this case, error was being swallowed and DHT not started, breaking acquisition of new peers. Co-authored-by: Ivan Shvedunov <[email protected]>
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
ivan4th
added a commit
that referenced
this pull request
Apr 29, 2024
There was no error checking for DHT discovery startup, yet it could fail e.g. during LevelDB corruption: ``` Error: init services: error starting discovery: open leveldb at /opt/go-spacemesh/go-spacemesh-0/p2p: leveldb/journal: block/chunk corrupted: chunk length overflows block (1270 bytes) [file=000247.log] ``` In this case, error was being swallowed and DHT not started, breaking acquisition of new peers. Co-authored-by: Ivan Shvedunov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There was no error checking for DHT discovery startup, yet it could fail e.g. during LevelDB corruption:
In this case, error was being swallowed and DHT not started, breaking acquisition of new peers.
Description
This PR adds error checking for DHT startup and also fixes panics that were happening if app startup was interrupted this early.
Test Plan
Verified on a mainnet node
TODO